mcsauder
f9a5c91f8c
Deprecate vehicle_attitude_sub from MulticopterLandDetector as it is no longer utilized.
2019-10-09 09:48:17 +02:00
mcsauder
6066300757
Set a default signal_quality value in the MavlinkReciever::handle_message_distance_sensor() method.
2019-10-08 21:19:47 +01:00
mcsauder
5ccba5541d
Added missing fields and a TODO with commented field to the MavlinkReciever::handle_message_distance_sensor().
2019-10-08 21:19:47 +01:00
Mark Sauder
3ce58f7102
sensors: organize vars in voted_sensors_update.h
2019-10-02 19:54:38 -04:00
Mark Sauder
508ffa1b39
land_detector: Remove recently added vehicle_attitude.timestamp check from MulticopterLandDetector::_get_maybe_landed_state(). ( #13072 )
...
PR #12681 added a check to the MulticopterLandDetector::_get_maybe_landed_state() method for a valid vehicle_attitude.timstamp value to finish work in PR #9756 . It was discovered that the addition of that check leaves it possible to fly in acro mode without a valid attitude and auto-disarm can engage, allowing the multicopter to fall out of the sky.
2019-10-02 16:31:06 -04:00
mcsauder
2644742b37
Deprecate RoverLandDetector virtual methods that are redundant.
2019-10-02 16:02:30 -04:00
mcsauder
4f71c4e123
Change #defines to static constexpr types in LidateLite.h, updated the docs link in ll40ls.cpp, and shortened comments to allow uniform indentation in LidarLiteI2C.h.
2019-09-27 07:55:53 +01:00
mcsauder
9023030931
LidarLite driver minor comment updates/formatting and change instances of OK to PX4_OK.
2019-09-27 07:55:53 +01:00
mcsauder
7b16c3482d
Refactor the ll40ls namespace driver methods to more closely match the cm8jl65, mappydot, leddar_one, and other distance sensor driver implementations.
2019-09-27 07:55:53 +01:00
Mark Sauder
db8e203a7a
Update the Integrator class local variable dt from double to float and utilize the hrt_abstime typedef. ( #12935 )
2019-09-25 14:41:54 +02:00
Mark Sauder
4a6742c3e6
Deprecate the non-functioning HC_SR04 driver. ( #13021 )
2019-09-25 10:34:50 +02:00
mcsauder
cdbe4a3ee8
Refactor the terraranger driver.
2019-09-22 12:23:25 -04:00
mcsauder
410dd85289
Comment out the ll40ls (LidarLite) driver from the fmu-v2 build.
2019-09-13 11:03:13 -04:00
mcsauder
e4509486e8
Correct a typo and create a #define for the LeddarOne FOV.
2019-09-06 11:59:29 +02:00
mcsauder
aea139bc1b
Correct the LeddarOne FOV and deprecate the unneeded _distance_sensor_topic after migrating to PX4RangeFinder.
2019-09-06 11:59:29 +02:00
mcsauder
ddd9a97d42
Modify the LeddarOne driver class to utilize the PX4RangeFinder library.
2019-09-06 11:59:29 +02:00
mcsauder
94d39e4466
Return from LeddarOne::collect() via LeddarOne::measure() and alphabetize #includes.
2019-09-06 11:59:29 +02:00
mcsauder
f31ac44289
Const correctness and fix leddar_one::test().
2019-09-06 11:59:29 +02:00
mcsauder
c0e8b37d96
Add collect() validation to the LeddarOne::init() method, format whitespace and console output.
...
Reduce measure/collect timing logic complexity to use ScheduleOnInterval() rather than SchuleDelayed().
2019-09-06 11:59:29 +02:00
mcsauder
04073f2c71
Deprecate the LeddarOne request() and publish() methods to match other distance sensor driver classes and fix perf counter errata.
2019-09-06 11:59:29 +02:00
Mark Sauder
60e5e0821a
land_detector: Add and max_altitude and timestamp validity checks to MulticopterLandDetector class. ( #12681 )
...
* Rename local camelCase vars to snake_case and control_mode -> vehicle_control_mode to match typdef with established class convention.
2019-09-02 00:30:46 -04:00
mcsauder
0817ee40f8
Add generic vtol tailsitter airframe/mixer and incorporate modifications from PR 9849 in 4001_quad_x and 13001_caipirinha_vtol.
2019-09-01 18:35:14 -04:00
mcsauder
d4fedca1ee
Rename _accel_horz_lp -> _xy_accel_filtered to standardize naming, use time literal, and delete unneeded #includes in the FixedwingLandDetector class.
2019-08-14 23:10:20 -04:00
mcsauder
9e055e9b21
Implement ModuleParams inheritance in the VtolLandDetector class. Requires PR #12356 .
2019-08-14 11:58:14 -04:00
Mark Sauder
6abf2203a3
sensors: uniform initialization and whitespace formatting in voted_sensors_update.h
2019-08-10 02:14:22 -04:00
Mark Sauder
056c8000a1
MultiCopterLandDetector: Implement ModuleParams inheritance ( #12356 )
2019-08-09 07:57:42 +02:00
mcsauder
887b55269a
Delete whitespace to quiet githooks.
2019-08-08 18:56:26 -04:00
mcsauder
2e3926b577
Fix a corner case that prevented mavlink config streams from being indexed appropriately when USB is not connected at boot.
...
Break out Mavlink class constructor logic into set_instance() and set_channel() methods. and add const specifiers and default arguments to Mavlink::mavlink_open_uart().
2019-08-05 05:02:20 -07:00
Mark Sauder
e0c85c8831
ll40ls: correct a write_reg issue ( #12604 )
...
* deprecate a goto statement
* migrate to uniform initialization in LidarLite base class.
2019-08-01 23:41:05 -04:00
Mark Sauder
f432f74611
ulanding: refactor driver to utilize ScheduledWorkQueue class inheritance ( #11894 )
...
* Migrate variable initialization from constructor list to declaration uniform initialization, format whitespace, alphabetize/group/order variables and methods in ulanding.cpp.
* Refactor the uLanding driver to utilize the ScheduledWorkQueue.
2019-07-28 10:51:01 -04:00
Mark Sauder
4a02475dd1
rcS: reduce a few LOC in AUTOCNF logic ( #12467 )
...
* Set/unset rcS vars at beginning and end of rcS script and reduce a few LOC checking SYS_AUTOCONFIG with improved logic.
* Restore current placement of set/unset vars in rcS script to leave only the SYS_AUTOCONFIG logic modification.
* Replace set AUTOCNF no after inadvertent deletion.
2019-07-16 16:48:25 +02:00
Mark Sauder
4e5974f1ca
srf02 driver: Move member variable initialization to declarations, standardize against other drivers and format. ( #11891 )
...
* Migrate variable initialization from constructor list to declarations, standardize whitespace formatting, and alphabetize/organize order of methods and variables in srf02.cpp.
* Increase stack allocation size for the srf02 driver main.
2019-07-10 23:05:02 -04:00
mcsauder
c1e4970841
Delete uneccessary #includes from the lights driver directory.
2019-07-08 23:45:01 -04:00
mcsauder
f3af3217c7
Delete unnecessary #includes from the irlock driver.
2019-07-08 23:45:01 -04:00
mcsauder
b495ddbdd3
Delete unnecessary #includes from the imu driver directory.
2019-07-08 23:45:01 -04:00
mcsauder
be414f7ab1
Alphabetize the heater driver #include list.
2019-07-08 23:45:01 -04:00
mcsauder
35e5327cc9
Delete unnecessary #includes in the gps driver directory.
2019-07-08 23:45:01 -04:00
mcsauder
2ef6e18640
Delete unnecessary #includes in the differential_pressure drivers directory.
2019-07-08 23:45:01 -04:00
mcsauder
2a3b98a463
Deprecate unneeded #includes from the camera_capture driver.
2019-07-08 23:45:01 -04:00
mcsauder
b10cb2a24e
Deprecate unnecessary #includes from the batt_smbus driver.
2019-07-08 23:45:01 -04:00
mcsauder
d1e46737a3
Organize, alphabetize, and deprecate unneeded #includes from the barometer drivers.
2019-07-08 21:32:52 -04:00
Mark Sauder
423219c60e
pga460: Change variable initialization to uniform initialization style, format whitespace, and change baud rate unsigned to speed_t type. ( #11861 )
2019-06-28 21:52:16 -04:00
Mark Sauder
db96b6c08d
cm8jl65: Refactor driver, employ uniform initialization, format, and deprecate ringbuffer and IOCTL. ( #11853 )
...
* Move cm8jl65 class member variable initialization from constructor list to declarations. Format whitespace and move method doxy comments to declarations.
* Refactor the cm8jl65 driver start() method, and rename info()->status().
* Continued refactoring of the cm8jl65 driver class:
- Condense all class files into a single *.cpp file and give class scope resolution to previously unscoped methods.
- Refactor cm8jl65 namespace level driver entry methods to reduce code and improve clarity.
- Breakout CDev specific initialization LOC into the device_init() method.
- Move the endian modification inside of the crc16_calc() method.
* Deprecate the hardware ringbuffer, _class_instance, and ioctl() from the cm8jl65 driver.
2019-06-28 21:46:02 -04:00
Mark Sauder
5857cf4799
LeddarOne: Refactor the driver to standardize against other distance sensor drivers. ( #11858 )
...
* Migrate remaining member variable intialization to declarations and employ uniform initialization style. Copy/paste help() and main() methods to the bottom of the file to match convention with other distance sensor drivers.
* Refactor the LeddarOne driver class to give scope resultion to the methods that were global and to standardize the implementation against most of the other distance sensor drivers.
* Deprecate _reports member var, use of hardware ring buffer, and LeddarOne::read() method.
* Deprecate commented (dead) code from the LeddarOne class init() method.
* Refactor the LeddarOne class cycle() and collect() methods and create measure() method to untangle the previous logic implementation.
2019-06-28 21:29:44 -04:00
Mark Sauder
c22ed9397e
land_detector: Implement ModuleParams inheritance in the FixedwingLandDetector class.
2019-06-28 10:26:59 -04:00
Mark Sauder
1466d11acc
land_detector: cleanup actuator_armed and battery_status naming
...
* Rename _arming -> _actuator_armed
* Rename _battery -> _battery_status in the MulticopterLandDetector class.
2019-06-27 12:02:14 -04:00
Mark Sauder
94c1f21473
mb12xx: Refactor driver class to allow for multiple sensors and cleanup ( #11859 )
...
* Migrate mb12xx driver class member variable initialization to declarations.
Format whitespace and alphabetize/group/order var declarations.
Refactor driver reset() and mb12xx_main() methods for readability.
Deprecate usage of IOCTL.
* Deprecate the _reports ringbuffer, _class_instance, and read() method and minor formatting in the mb12xx driver.
* Add time_literal usage and #define MB12XX_BUS_SPEED.
* Refactor the mb12xx driver to mirror the mappy_dot driver implementation and create functionality for multiple sensors.
* Add stack size for the mb12xx driver.
2019-06-27 11:59:40 -04:00
mcsauder
6e9f706b12
Standardize remaining class member variable naming convention in the MulticopterLandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
df662245a2
Standardize class member variable naming convention in the LandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
6b6d82447e
Standardize class member variable naming convention in the MulticopterLandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
3f0159d784
Standardize class member variable naming convention in the VtolLandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
2b9ad179a2
Standardize class member variable naming convention in the FixedWingLandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
d7cfebe0a3
Add check_params(true) call to the LandDetector start() method. Break out _update_total_flight_time() method in the LandDetector class.
2019-06-26 09:23:02 +02:00
mcsauder
f783982edb
Revert changes to the check_params(const bool force) declaration/definition to match current PX4:master.
2019-06-26 09:23:02 +02:00
mcsauder
0ec7efcfc4
Delete _measure_interval and redundant parentheses in LandDetector.h.
2019-06-26 09:23:02 +02:00
mcsauder
faa3c3dc6f
Refactor the LandDetector class to
...
- Reduce duplicate code in LandDetector _check_params() method.
- Standardize naming cases.
- Implement DEFINE_PARAMETERS() macro.
2019-06-26 09:23:02 +02:00
mcsauder
8811c8315c
Modify the update_params() comment to better reflect what is taking place in mavlink_receiver.h.
2019-06-17 09:41:30 +02:00
mcsauder
742c22d099
Rename _param_sub to _param_update_sub and initialize. Re-define and re-implement the update_params() method and only call if parameters have been updated.
2019-06-17 09:41:30 +02:00
mcsauder
c92b8b03cd
Move variable initialization from constructor to declarations in MavlinkReceiver class, alphabetize var lists. Added update_params() method to ensure that parameters subscribed to are updated routinely.
2019-06-17 09:41:30 +02:00
Mark Sauder
f1c66749e3
vl53lxx: migrate variable initialization from constructor list to declaration uniform initialization ( #11896 )
...
* Format whitespace
* Alphabetize/group/order variables and methods.
* Deprecate IOCTL usage and simplify a few methods.
2019-06-15 23:18:46 -04:00
Mark Sauder
eaa3d4a24f
tfmini: migrate driver class member variable initialization to declarations ( #11893 )
...
* format whitespace
* alphabetize/group/order var/method declarations
* added a default port to start the tfmini driver without requiring arguments.
2019-06-15 21:01:36 -04:00
Mark Sauder
ae6fed4f29
Migrate remaining variable initializations from constructor list to declarations in mavlink_main.cpp/h.
2019-06-12 12:53:09 -04:00
mcsauder
8966ad59c7
Add distance sensor id to the the MavlinkStreamDistanceSensor class and format whitespace in mavlink_messages.cpp.
2019-06-01 14:23:49 -04:00
mcsauder
e6b427022a
Add missing underscore prefix to a member variable in mavlink_main.cpp.h and delete unnecessary struct specifiers in mavlink_main.h.
2019-04-26 11:33:17 +02:00
mcsauder
73fb30f251
Migrate an additional set of 16 variable initilializations from the Mavlink class constructor list to their respective declarations.
2019-04-26 11:33:17 +02:00
Mark Sauder
74bc6870ed
simulator: uorb and initialization cleanup ( #11825 )
...
* Cherry pick the vehicle_imu PR #9756 src/modules/simulator directory work to submit as standalone PR.
* Modify the accelsim init method mag_report usage to match usage in measure() and mag_measure() methods in the class.
* Incorporate review comments in the accelsim.cpp init() method and also make the same modifications in gyrosim.cpp.
* Delete unneeded mag_report initialization from accelsim init() method.
* Deprecate unneeded measure() call from accelsim.cpp init() and gyrosim.cpp init().
2019-04-16 08:29:53 +02:00
mcsauder
9540869c20
Alphabetize a few methods and variable orders in mavlink_receiver.h.
2019-04-11 08:31:30 +02:00
mcsauder
e6f1a2db12
Delete trailing whitespace, extra newlines, to quiet git hooks and add an extra = so that it does not appear to git as a merge conflict marker.
2019-04-02 15:31:37 -04:00
mcsauder
a6315d4e6e
Delete Simulator class subscription vars that are not used and add orb_unsubscribe() calls.
2019-03-18 10:00:39 +01:00
Mark Sauder
164fe00df7
mc_att_control: replace math::min() and additional limit logic with math::constrain() calls ( #11658 )
2019-03-17 10:48:27 -04:00
Mark Sauder
4c228eaf4a
cmake whitespace fixes to quiet git hook.
2019-03-16 14:48:44 -04:00
mcsauder
2ae2331c15
Delete extra newline character in qmc5883/CMakeLists.txt to quiet git hook.
2019-03-12 14:59:08 -04:00
mcsauder
2773fe6a54
Deprecate _hil_frames and _old_timestamp member vars and dead logic from MavlinkReceiver class.
2019-03-11 08:03:37 +01:00
mcsauder
1f65887982
Migrate a few more var initializations from the Mavlink class constructor list to the respective declarations.
2019-03-09 14:53:24 -05:00
mcsauder
7b3482adf0
Whitespace formatting in mavlink_main.cpp/h and begin work of some variable initialization at declaration in mavlink_main.h.
2019-03-09 13:32:26 -05:00
mcsauder
cb49ed55fe
Delete unnecessary #includes from mavlink_main.cpp and relocate a few #defines to mavlink_main.h for future variable initialization work.
2019-03-08 22:10:11 -05:00
mcsauder
d12cec81ba
Add const specifier to remaining methods utilizing mavlink_message_t and similar message pointer types.
2019-03-07 08:22:44 +01:00
mcsauder
278fddb585
Cut case MAVLINK_MSG_ID_ODOMETRY content and paste into handle_message_odometry() method.
2019-03-07 08:22:44 +01:00
mcsauder
3918d0ce0a
Cut case MAVLINK_MSG_ID_VISION_POSITION_ESTIMATE content and paste into handle_message_vision_position_estimate() method. Add const specifier to publish_odometry_topic() method.
2019-03-07 08:22:44 +01:00
mcsauder
c3acd3bad3
Delete unnecessary curly braces in simulator_mavlink.cpp
2019-03-07 08:22:44 +01:00
mcsauder
e43a0bbf1d
Cut case MAVLINK_MSG_ID_RC_CHANNELS content and paste into handle_message_rc_channels() method.
2019-03-07 08:22:44 +01:00
mcsauder
801cbc856e
Cut case MAVLINK_MSG_ID_HIL_GPS content and paste into handle_message_hil_gps() method.
2019-03-07 08:22:44 +01:00
mcsauder
b705bf6b1c
Cut case MAVLINK_MSG_ID_HIL_SENSOR content and paste into handle_message_hil_sensor() method.
2019-03-07 08:22:44 +01:00
mcsauder
a97151feed
Set default set_publlish() argument to true.
2019-03-05 09:16:31 +01:00
mcsauder
0bd5d6caff
Refactor set_publish() logic so that a default false value is not (re)set each loop in simulator_mapvlink.cpp and provide a default argument to set_publish() in simulator.h.
2019-03-05 09:16:31 +01:00
mcsauder
6e0fc150c0
Create Simulator::set_publish() method and Simulator::_publish member variable to allow redefinition of the Simulator::handle_message() prototype to match MavlinkReceiver::handle_message().
2019-03-05 09:16:31 +01:00
mcsauder
9f3937e2d2
Formatted and edited a few comments in mavlink_receiver.h.
2019-03-02 23:39:25 -05:00
mcsauder
d60d802194
Correct board-config PIN1/PIN0 typo in fmu-v5/src/board_config.h.
2019-03-02 14:31:02 -08:00
mcsauder
d42bb01e0c
Standardize method definition newlines in mavlink_receiver.cpp.
2019-03-02 13:09:41 -05:00
mcsauder
1eced05359
Rename Simulator class private methods names to match snake case of other private class methods.
2019-02-28 19:26:45 +01:00
mcsauder
b0a79996ae
Cut case MAVLINK_MSG_ID_HIL_STATE_QUATERNION content and paste into handle_message_hil_state_quaternion() method.
2019-02-28 19:24:50 +01:00
mcsauder
8b42045546
Cut case MAVLINK_MSG_ID_HIL_OPTICAL_FLOW content and paste into handle_message_hil_optical_flow() method.
2019-02-28 19:24:50 +01:00
mcsauder
24e55e4d4d
Cut case MAVLINK_MSG_ID_DISTANCE_SENSOR content and paste into handle_message_distance_sensor() method.
2019-02-28 19:24:50 +01:00
mcsauder
411db781eb
Cut case MAVLINK_MSG_ID_LANDING_TARGET content and paste into handle_message_landing_target() method.
2019-02-28 19:24:50 +01:00
Mark Sauder
c04147c53c
Mavlink receiver: Move most variable initializations out of the constructor to the variable declarations
2019-02-26 11:48:02 -05:00
mcsauder
ca92b8016d
Move member variable initialization out of the constructor list to variable declarations, format whitespaces/tabs in sf1xx.cpp.
2019-02-26 10:42:00 -05:00
mcsauder
6762f09490
Move variable initializations to header file that were no longer in the correct order in the constructor list.
2019-02-21 09:22:01 -05:00
mcsauder
8a6a5cc310
Deprecate #defines that are not needed, format whitespace and minor (incomplete) alphebetization of a few lists.
2019-02-21 09:22:01 -05:00
mcsauder
b5be8d9fd1
Add perf_free() calls orb_unsubscribe and remove delete _instance in the Simulator class destructor.
2019-02-21 08:12:22 +01:00
mcsauder
437a9e0260
Move remaining variable initialization from constructor list and alphabetize/organize methods and vars ordering.
2019-02-21 08:12:22 +01:00