Mark Sauder
4a02475dd1
rcS: reduce a few LOC in AUTOCNF logic ( #12467 )
...
* Set/unset rcS vars at beginning and end of rcS script and reduce a few LOC checking SYS_AUTOCONFIG with improved logic.
* Restore current placement of set/unset vars in rcS script to leave only the SYS_AUTOCONFIG logic modification.
* Replace set AUTOCNF no after inadvertent deletion.
2019-07-16 16:48:25 +02:00
Mark Sauder
4e5974f1ca
srf02 driver: Move member variable initialization to declarations, standardize against other drivers and format. ( #11891 )
...
* Migrate variable initialization from constructor list to declarations, standardize whitespace formatting, and alphabetize/organize order of methods and variables in srf02.cpp.
* Increase stack allocation size for the srf02 driver main.
2019-07-10 23:05:02 -04:00
mcsauder
c1e4970841
Delete uneccessary #includes from the lights driver directory.
2019-07-08 23:45:01 -04:00
mcsauder
f3af3217c7
Delete unnecessary #includes from the irlock driver.
2019-07-08 23:45:01 -04:00
mcsauder
b495ddbdd3
Delete unnecessary #includes from the imu driver directory.
2019-07-08 23:45:01 -04:00
mcsauder
be414f7ab1
Alphabetize the heater driver #include list.
2019-07-08 23:45:01 -04:00
mcsauder
35e5327cc9
Delete unnecessary #includes in the gps driver directory.
2019-07-08 23:45:01 -04:00
mcsauder
2ef6e18640
Delete unnecessary #includes in the differential_pressure drivers directory.
2019-07-08 23:45:01 -04:00
mcsauder
2a3b98a463
Deprecate unneeded #includes from the camera_capture driver.
2019-07-08 23:45:01 -04:00
mcsauder
b10cb2a24e
Deprecate unnecessary #includes from the batt_smbus driver.
2019-07-08 23:45:01 -04:00
mcsauder
d1e46737a3
Organize, alphabetize, and deprecate unneeded #includes from the barometer drivers.
2019-07-08 21:32:52 -04:00
Mark Sauder
423219c60e
pga460: Change variable initialization to uniform initialization style, format whitespace, and change baud rate unsigned to speed_t type. ( #11861 )
2019-06-28 21:52:16 -04:00
Mark Sauder
db96b6c08d
cm8jl65: Refactor driver, employ uniform initialization, format, and deprecate ringbuffer and IOCTL. ( #11853 )
...
* Move cm8jl65 class member variable initialization from constructor list to declarations. Format whitespace and move method doxy comments to declarations.
* Refactor the cm8jl65 driver start() method, and rename info()->status().
* Continued refactoring of the cm8jl65 driver class:
- Condense all class files into a single *.cpp file and give class scope resolution to previously unscoped methods.
- Refactor cm8jl65 namespace level driver entry methods to reduce code and improve clarity.
- Breakout CDev specific initialization LOC into the device_init() method.
- Move the endian modification inside of the crc16_calc() method.
* Deprecate the hardware ringbuffer, _class_instance, and ioctl() from the cm8jl65 driver.
2019-06-28 21:46:02 -04:00
Mark Sauder
5857cf4799
LeddarOne: Refactor the driver to standardize against other distance sensor drivers. ( #11858 )
...
* Migrate remaining member variable intialization to declarations and employ uniform initialization style. Copy/paste help() and main() methods to the bottom of the file to match convention with other distance sensor drivers.
* Refactor the LeddarOne driver class to give scope resultion to the methods that were global and to standardize the implementation against most of the other distance sensor drivers.
* Deprecate _reports member var, use of hardware ring buffer, and LeddarOne::read() method.
* Deprecate commented (dead) code from the LeddarOne class init() method.
* Refactor the LeddarOne class cycle() and collect() methods and create measure() method to untangle the previous logic implementation.
2019-06-28 21:29:44 -04:00
Mark Sauder
c22ed9397e
land_detector: Implement ModuleParams inheritance in the FixedwingLandDetector class.
2019-06-28 10:26:59 -04:00
Mark Sauder
1466d11acc
land_detector: cleanup actuator_armed and battery_status naming
...
* Rename _arming -> _actuator_armed
* Rename _battery -> _battery_status in the MulticopterLandDetector class.
2019-06-27 12:02:14 -04:00
Mark Sauder
94c1f21473
mb12xx: Refactor driver class to allow for multiple sensors and cleanup ( #11859 )
...
* Migrate mb12xx driver class member variable initialization to declarations.
Format whitespace and alphabetize/group/order var declarations.
Refactor driver reset() and mb12xx_main() methods for readability.
Deprecate usage of IOCTL.
* Deprecate the _reports ringbuffer, _class_instance, and read() method and minor formatting in the mb12xx driver.
* Add time_literal usage and #define MB12XX_BUS_SPEED.
* Refactor the mb12xx driver to mirror the mappy_dot driver implementation and create functionality for multiple sensors.
* Add stack size for the mb12xx driver.
2019-06-27 11:59:40 -04:00
mcsauder
6e9f706b12
Standardize remaining class member variable naming convention in the MulticopterLandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
df662245a2
Standardize class member variable naming convention in the LandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
6b6d82447e
Standardize class member variable naming convention in the MulticopterLandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
3f0159d784
Standardize class member variable naming convention in the VtolLandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
2b9ad179a2
Standardize class member variable naming convention in the FixedWingLandDetector class.
2019-06-26 14:06:56 -04:00
mcsauder
d7cfebe0a3
Add check_params(true) call to the LandDetector start() method. Break out _update_total_flight_time() method in the LandDetector class.
2019-06-26 09:23:02 +02:00
mcsauder
f783982edb
Revert changes to the check_params(const bool force) declaration/definition to match current PX4:master.
2019-06-26 09:23:02 +02:00
mcsauder
0ec7efcfc4
Delete _measure_interval and redundant parentheses in LandDetector.h.
2019-06-26 09:23:02 +02:00
mcsauder
faa3c3dc6f
Refactor the LandDetector class to
...
- Reduce duplicate code in LandDetector _check_params() method.
- Standardize naming cases.
- Implement DEFINE_PARAMETERS() macro.
2019-06-26 09:23:02 +02:00
mcsauder
8811c8315c
Modify the update_params() comment to better reflect what is taking place in mavlink_receiver.h.
2019-06-17 09:41:30 +02:00
mcsauder
742c22d099
Rename _param_sub to _param_update_sub and initialize. Re-define and re-implement the update_params() method and only call if parameters have been updated.
2019-06-17 09:41:30 +02:00
mcsauder
c92b8b03cd
Move variable initialization from constructor to declarations in MavlinkReceiver class, alphabetize var lists. Added update_params() method to ensure that parameters subscribed to are updated routinely.
2019-06-17 09:41:30 +02:00
Mark Sauder
f1c66749e3
vl53lxx: migrate variable initialization from constructor list to declaration uniform initialization ( #11896 )
...
* Format whitespace
* Alphabetize/group/order variables and methods.
* Deprecate IOCTL usage and simplify a few methods.
2019-06-15 23:18:46 -04:00
Mark Sauder
eaa3d4a24f
tfmini: migrate driver class member variable initialization to declarations ( #11893 )
...
* format whitespace
* alphabetize/group/order var/method declarations
* added a default port to start the tfmini driver without requiring arguments.
2019-06-15 21:01:36 -04:00
Mark Sauder
ae6fed4f29
Migrate remaining variable initializations from constructor list to declarations in mavlink_main.cpp/h.
2019-06-12 12:53:09 -04:00
mcsauder
8966ad59c7
Add distance sensor id to the the MavlinkStreamDistanceSensor class and format whitespace in mavlink_messages.cpp.
2019-06-01 14:23:49 -04:00
mcsauder
e6b427022a
Add missing underscore prefix to a member variable in mavlink_main.cpp.h and delete unnecessary struct specifiers in mavlink_main.h.
2019-04-26 11:33:17 +02:00
mcsauder
73fb30f251
Migrate an additional set of 16 variable initilializations from the Mavlink class constructor list to their respective declarations.
2019-04-26 11:33:17 +02:00
Mark Sauder
74bc6870ed
simulator: uorb and initialization cleanup ( #11825 )
...
* Cherry pick the vehicle_imu PR #9756 src/modules/simulator directory work to submit as standalone PR.
* Modify the accelsim init method mag_report usage to match usage in measure() and mag_measure() methods in the class.
* Incorporate review comments in the accelsim.cpp init() method and also make the same modifications in gyrosim.cpp.
* Delete unneeded mag_report initialization from accelsim init() method.
* Deprecate unneeded measure() call from accelsim.cpp init() and gyrosim.cpp init().
2019-04-16 08:29:53 +02:00
mcsauder
9540869c20
Alphabetize a few methods and variable orders in mavlink_receiver.h.
2019-04-11 08:31:30 +02:00
mcsauder
e6f1a2db12
Delete trailing whitespace, extra newlines, to quiet git hooks and add an extra = so that it does not appear to git as a merge conflict marker.
2019-04-02 15:31:37 -04:00
mcsauder
a6315d4e6e
Delete Simulator class subscription vars that are not used and add orb_unsubscribe() calls.
2019-03-18 10:00:39 +01:00
Mark Sauder
164fe00df7
mc_att_control: replace math::min() and additional limit logic with math::constrain() calls ( #11658 )
2019-03-17 10:48:27 -04:00
Mark Sauder
4c228eaf4a
cmake whitespace fixes to quiet git hook.
2019-03-16 14:48:44 -04:00
mcsauder
2ae2331c15
Delete extra newline character in qmc5883/CMakeLists.txt to quiet git hook.
2019-03-12 14:59:08 -04:00
mcsauder
2773fe6a54
Deprecate _hil_frames and _old_timestamp member vars and dead logic from MavlinkReceiver class.
2019-03-11 08:03:37 +01:00
mcsauder
1f65887982
Migrate a few more var initializations from the Mavlink class constructor list to the respective declarations.
2019-03-09 14:53:24 -05:00
mcsauder
7b3482adf0
Whitespace formatting in mavlink_main.cpp/h and begin work of some variable initialization at declaration in mavlink_main.h.
2019-03-09 13:32:26 -05:00
mcsauder
cb49ed55fe
Delete unnecessary #includes from mavlink_main.cpp and relocate a few #defines to mavlink_main.h for future variable initialization work.
2019-03-08 22:10:11 -05:00
mcsauder
d12cec81ba
Add const specifier to remaining methods utilizing mavlink_message_t and similar message pointer types.
2019-03-07 08:22:44 +01:00
mcsauder
278fddb585
Cut case MAVLINK_MSG_ID_ODOMETRY content and paste into handle_message_odometry() method.
2019-03-07 08:22:44 +01:00
mcsauder
3918d0ce0a
Cut case MAVLINK_MSG_ID_VISION_POSITION_ESTIMATE content and paste into handle_message_vision_position_estimate() method. Add const specifier to publish_odometry_topic() method.
2019-03-07 08:22:44 +01:00
mcsauder
c3acd3bad3
Delete unnecessary curly braces in simulator_mavlink.cpp
2019-03-07 08:22:44 +01:00
mcsauder
e43a0bbf1d
Cut case MAVLINK_MSG_ID_RC_CHANNELS content and paste into handle_message_rc_channels() method.
2019-03-07 08:22:44 +01:00
mcsauder
801cbc856e
Cut case MAVLINK_MSG_ID_HIL_GPS content and paste into handle_message_hil_gps() method.
2019-03-07 08:22:44 +01:00
mcsauder
b705bf6b1c
Cut case MAVLINK_MSG_ID_HIL_SENSOR content and paste into handle_message_hil_sensor() method.
2019-03-07 08:22:44 +01:00
mcsauder
a97151feed
Set default set_publlish() argument to true.
2019-03-05 09:16:31 +01:00
mcsauder
0bd5d6caff
Refactor set_publish() logic so that a default false value is not (re)set each loop in simulator_mapvlink.cpp and provide a default argument to set_publish() in simulator.h.
2019-03-05 09:16:31 +01:00
mcsauder
6e0fc150c0
Create Simulator::set_publish() method and Simulator::_publish member variable to allow redefinition of the Simulator::handle_message() prototype to match MavlinkReceiver::handle_message().
2019-03-05 09:16:31 +01:00
mcsauder
9f3937e2d2
Formatted and edited a few comments in mavlink_receiver.h.
2019-03-02 23:39:25 -05:00
mcsauder
d60d802194
Correct board-config PIN1/PIN0 typo in fmu-v5/src/board_config.h.
2019-03-02 14:31:02 -08:00
mcsauder
d42bb01e0c
Standardize method definition newlines in mavlink_receiver.cpp.
2019-03-02 13:09:41 -05:00
mcsauder
1eced05359
Rename Simulator class private methods names to match snake case of other private class methods.
2019-02-28 19:26:45 +01:00
mcsauder
b0a79996ae
Cut case MAVLINK_MSG_ID_HIL_STATE_QUATERNION content and paste into handle_message_hil_state_quaternion() method.
2019-02-28 19:24:50 +01:00
mcsauder
8b42045546
Cut case MAVLINK_MSG_ID_HIL_OPTICAL_FLOW content and paste into handle_message_hil_optical_flow() method.
2019-02-28 19:24:50 +01:00
mcsauder
24e55e4d4d
Cut case MAVLINK_MSG_ID_DISTANCE_SENSOR content and paste into handle_message_distance_sensor() method.
2019-02-28 19:24:50 +01:00
mcsauder
411db781eb
Cut case MAVLINK_MSG_ID_LANDING_TARGET content and paste into handle_message_landing_target() method.
2019-02-28 19:24:50 +01:00
Mark Sauder
c04147c53c
Mavlink receiver: Move most variable initializations out of the constructor to the variable declarations
2019-02-26 11:48:02 -05:00
mcsauder
ca92b8016d
Move member variable initialization out of the constructor list to variable declarations, format whitespaces/tabs in sf1xx.cpp.
2019-02-26 10:42:00 -05:00
mcsauder
6762f09490
Move variable initializations to header file that were no longer in the correct order in the constructor list.
2019-02-21 09:22:01 -05:00
mcsauder
8a6a5cc310
Deprecate #defines that are not needed, format whitespace and minor (incomplete) alphebetization of a few lists.
2019-02-21 09:22:01 -05:00
mcsauder
b5be8d9fd1
Add perf_free() calls orb_unsubscribe and remove delete _instance in the Simulator class destructor.
2019-02-21 08:12:22 +01:00
mcsauder
437a9e0260
Move remaining variable initialization from constructor list and alphabetize/organize methods and vars ordering.
2019-02-21 08:12:22 +01:00
mcsauder
31f23c1e76
Rename tune_control_s strength to volume to match Nuttx and Linux standard nomenclature for audio (loudness) control.
2019-02-19 10:07:53 +01:00
mcsauder
a6d186dfed
Rename Tunes::get_next_tune() to Tunes::get_next_note().
2019-02-19 08:00:11 +01:00
mcsauder
d6dc5a7302
Rename MB12XX_MAX_RANGEFINDERS to RANGE_FINDER_MAX_SENSORS.
2019-02-18 13:07:47 -05:00
Mark Sauder
352be14bbe
Alphabetizing/standardizing orders in tunes.cpp and tunes.h files
...
- Remove a constructor overload by adding default values, and disambiguate a few variables by adding verbosity to naming.
2019-02-10 20:31:12 -05:00
mcsauder
2fa70fca80
Added audio tune signals for unit tests passing and failing.
2019-02-10 17:47:16 -05:00
mcsauder
0032df3e87
Update the test_tone() unit test to use orb_advertise() and orb_publish() instead of IOCTL() and alphabetize tests_main.h.
2019-02-10 17:47:16 -05:00
mcsauder
6dc840ac6a
Break test_tone and test_ppm out of the test_hrt.cpp file into their own respective files.
2019-02-10 17:47:16 -05:00
mcsauder
9d67bbc328
Standardized/updated copyright file headers in the src/systemcmds/tests/ directory.
2019-01-30 14:25:18 -05:00
mcsauder
dc5f18bdcd
ToneAlarm class refactoring to implement an interface for hardware specific methods and a single ToneAlarm class.
2019-01-28 18:58:04 -08:00
mcsauder
cced80edf9
Correct the mpu6000 temperature correction scalar value to match the datasheet.
2019-01-28 12:48:03 +01:00
Mark Sauder
ad8539bd15
Deprecate the tap_common directory, nuttx, driver, and makefile references to tap-v1. ( #10629 )
2018-10-15 11:53:29 -04:00
mcsauder
2d208b1524
Edited aerofc-v1 file comments to not reference tap-v1.
2018-10-03 15:47:04 -04:00
mcsauder
c390d02f1c
Tidy up an OUTPUT_DEV set/unset in rc.interace and rcS.
2018-09-25 07:55:03 +02:00
mcsauder
a1af7ffdcf
Remove whitespaces to quiet git commit trailing whitespace warnings.
2018-09-21 23:28:31 +02:00
mcsauder
0ecf6436f8
Modify 500001_axialracing_ax10 to utilize rc.ugv_defaults to allow deprecating rc.axialracing_ax10_apps and rc.axialracing_ax10_defaults and update CMakeLists.txt.
2018-09-19 14:07:30 -04:00
mcsauder
31f3bcfc3a
Remove logic from rc.vehicle_setup that resulted in redundantly setting the MAV_TYPE to the same initial default value set within the script.
2018-09-18 22:49:01 -04:00
mcsauder
e79fa1773d
Alphabetize vehicle type logic block order and Update param set MAV_TYPE logic to only set the parameter if no MAV_TYPE was previously set.
2018-09-18 19:46:59 -04:00
mcsauder
0d0fcb140c
Updated rc.vtol_defaults to correct PWM_AUX behavior for VTOL airframes. Added PWM_AUX_RATE to rc.vtol_default and set parameters directly instead of environment variables.
2018-09-17 20:28:09 -04:00
mcsauder
615348189e
Remove doxy comments from private member variables.
2018-09-06 12:03:26 +02:00
mcsauder
e7666aa5d8
Added an imu heater driver, formatted whitespace, standardized comments, and added doxy documentation.
2018-09-06 12:03:26 +02:00
mcsauder
0c08b7035b
Edit the init.d-posix files to set MAV_TYPE script variables, and alphabetize lists in a few places.
2018-09-04 10:23:27 +02:00
mcsauder
4ea3306ec2
Set parameters directly rather than script variables in VTOL airframe config files and alphabetize lists.
2018-09-04 10:23:27 +02:00
mcsauder
bf87270ded
Doxy documenting in send_event.cpp/h and px4_module.h.
2018-08-29 09:50:21 +02:00
mcsauder
de92e699bf
Doxy documentation work in px4_module_params.h and px4_module.h.
2018-08-24 23:07:01 +02:00
mcsauder
1a1a04c094
Directly set parameters in airframe config files rather than setting script variables and move the param set lines into logic blocks, and alphabetize and tidy up param set lists.
2018-08-22 10:20:07 +02:00
mcsauder
3a22ee48db
Correct trailing whitespaces.
2018-08-18 15:15:41 -04:00
mcsauder
722e891730
Add doxy styling to method comments and update comments, replace goto statements with stop() calls and return statements.
2018-08-05 09:54:46 +02:00
mcsauder
21aea5bf6c
Rename commander.cpp to Commander.cpp and update CMakeLists.txt.
2018-08-03 22:06:05 -04:00
Mark Sauder
002b8b6a9c
Mavlink: add SCALED_IMU2 and SCALED_IMU3 ( #9556 )
...
- correct a gyro variable type, and add magnetometer values to ScaledIMU messages.
2018-08-03 09:33:17 -04:00
mcsauder
0928112a80
Move px4io firmware update logic block to rc.io.
2018-08-02 12:19:23 +02:00