244 Commits

Author SHA1 Message Date
Peter Duerr
5be23060e7 Fix resource leaks identified by cppcheck
* Where possible rearrange error checks to avoid branching
* Otherwise add missing `fclose`, `close`, `px4_close` calls before return
2017-08-07 22:05:17 +02:00
Beat Küng
5a2723ab9c test_mixer.cpp: remove bogus comments 2017-07-21 19:59:45 +02:00
David Sidrane
4349f49610 PX4 System:Expunge the nuttx adc structure from the system
This PR is preliminary ground work for FMUv5.

   PX4 does not use the NuttX adc driver. But used the same format
   for the data returned by the nuttx ADC driver.

   There was a fixme:in src/platforms/px4_adc.h "this needs to be
   a px4_adc_msg_s type" With this PR the need for
   src/platforms/px4_adc.h goes away as the driver drv_adc.h now
   describes the px4_adc_msg_t.
2017-07-17 22:28:29 +02:00
José Roberto de Souza
ac7127ff0f systemcmds: dataman: Check for errors in tasks 2017-07-13 15:21:26 +02:00
José Roberto de Souza
10f54e718e modules: dataman: Optimize memory usage
Use the size of each item type instead of the biggest one.

In AeroFC that runs is constrained mode it was using 7860 bytes
and now it uses 6930 bytes almost 1KB less.
2017-07-13 15:21:26 +02:00
Julien Lecoeur
fc860140f1 Fix internal compiler error with GCC 7
Here is the error message:
PX4/Firmware/src/systemcmds/tests/test_matrix.cpp:641:1: internal compiler error: in trunc_int_for_mode, at explow.c:55
 }
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
2017-06-26 15:50:44 +02:00
Daniel Agar
4937449890 move parameter unittest into systemcmds 2017-06-12 12:18:53 -04:00
Daniel Agar
0d0cbd8243 clang-tidy ignore cert-flp30-c only in tests 2017-06-02 19:35:18 -04:00
Daniel Agar
5d626bd940 clang-tidy remove redundant init 2017-06-02 19:35:18 -04:00
Daniel Agar
4b8bedef48 avoid double promotions 2017-04-01 20:19:28 +02:00
Pavel Kirienko
2b2c307eac Performance audit (intentionally duplicates #6829) (#6847)
* UAVCAN ESC output: removing ESC output channels from published message that are always zero. This allows the UAVCAN stack to always transfer only the minimum number of output values, avoiding redundant zeroes and the associated increase in bus load and CPU time

* Added a separate mixer file for CAN quadrotor

* Sampling profiler improvements

* PMSP: Output more endpoints

* Matrix update

* libc usage workaround

* Removed UAVCAN perfcounters

* Matrix submodule update
2017-03-18 04:16:20 -10:00
David Sidrane
c20b85e6ad Revert "UAVCAN performance audit (#6829)" (#6846)
This reverts commit 21e04c9f7afd56adf21d02b76c89ae06fe1fc5a7.
2017-03-18 04:04:43 -10:00
Pavel Kirienko
21e04c9f7a UAVCAN performance audit (#6829)
* UAVCAN ESC output: removing ESC output channels from published message that are always zero. This allows the UAVCAN stack to always transfer only the minimum number of output values, avoiding redundant zeroes and the associated increase in bus load and CPU time

* Added a separate mixer file for CAN quadrotor

* Sampling profiler improvements

* PMSP: Output more endpoints

* Matrix update

* libc usage workaround

* Removed UAVCAN perfcounters
2017-03-18 03:47:09 -10:00
Beat Küng
b0439836f6 refactor drv_led.h: rename to drv_board_led.h
This makes it clear that it's used to control the board LED's, not external
LED's.
2017-03-12 00:08:35 +01:00
Daniel Agar
9bc5da6d2d update matrix and fix test_matrix (#6524) 2017-02-16 00:31:06 -05:00
Daniel Agar
1bbca3bf1d test_dataman add to SITL with minor updates 2017-02-15 22:29:24 -05:00
Stephan Brown
54cc212d46 test_autodeclination: Add world endpoints to test. 2017-02-04 08:52:04 +01:00
Stephan Brown
614853b023 test_autodeclination: Update mag declination test value. 2017-02-04 08:52:04 +01:00
Daniel Agar
6f05fec335 clang-tidy performance-unnecessary-copy-initialization 2017-02-01 22:15:50 -05:00
Daniel Agar
37a2e331c4 clang-tidy test_bson memcmp check return 2017-02-01 22:15:50 -05:00
Daniel Agar
6631e72d6f clang-tidy modernize-redundant-void-arg 2017-02-01 22:15:50 -05:00
Daniel Agar
e927f3e040 clang-tidy modernize-use-nullptr 2017-02-01 22:15:50 -05:00
David Sidrane
93bc8f6467 Combined ifdess and made positive logic
We still allow CONFIG_ARCH_BOARD_SITL in the code base, but
  use positive logic and less #ifdefs
2017-01-21 11:45:36 +01:00
David Sidrane
5d263776f2 Placed dependancy on BOARD_USES_PX4IO not path (PX4IO_DEVICE_PATH)
Code was conditionaly included based on #define PX4IO_DEVICE_PATH
    in drivers/drv_gpio.h depanedent on board #ifdef CONFIG_ARCH_BOARDxxxx
    Now that dependancy comes from board_common.h as BOARD_USES_PX4IO defined
    when a board config provides PX4IO_SERIAL_DEVICE.
2017-01-21 11:45:36 +01:00
Beat Küng
e7db0ed098 test_mixer & mixer: use memmove instead of memcpy
Both, src & dst use the same array, thus potentially overlapping.
Behavior of memcpy in that case is undefined.
2017-01-18 18:23:42 +01:00
Lorenz Meier
b6e18a1479 Mixer test: More instrumentation to catch repro cases in CI 2017-01-14 20:42:54 +01:00
Lorenz Meier
26625b3a5d Servo test: Fix resource leak 2017-01-14 07:47:03 -08:00
Lorenz Meier
a905babe95 PPM LoopbackTest: Fix resource leak 2017-01-14 07:47:03 -08:00
Lorenz Meier
b9e32d7a34 mixer test: Fix string handling
Some strings were not enforcing NUL termination.
2017-01-14 07:47:03 -08:00
Lorenz Meier
6927fcb5c0 Mixer test: Fix string termination corner case 2017-01-14 07:47:03 -08:00
Daniel Agar
056cd30629 Servo test: fix style 2017-01-12 03:02:05 -05:00
Lorenz Meier
61d7f22aba Servo test: Ensure we only close an open FD 2017-01-12 02:31:15 +01:00
Andreas Antener
35740b0b59 Mixer test: fix paths for nuttx 2017-01-03 20:32:33 -05:00
Lorenz Meier
3229c4183a Mixer test: Condition strncpy properly 2017-01-03 20:32:33 -05:00
Lorenz Meier
9e95d88574 Use system define for path length buffer 2017-01-03 20:32:33 -05:00
Lorenz Meier
c6b6d04a19 UART tests: Move shell and fix config restore command 2017-01-03 20:32:33 -05:00
Lorenz Meier
0d5089e3bf Mixer test: Improve portability 2017-01-03 20:32:33 -05:00
Lorenz Meier
5247f17576 Mixer test: use real defines from IO firmware
We use the real defines now and test them against every mixer on the system. This means we should catch transfer errors now before even hitting master.
2017-01-03 20:32:33 -05:00
Lorenz Meier
d0dbddea1b Extend mixer test case with complex mixer 2017-01-03 20:32:33 -05:00
Lorenz Meier
0810bcfe8e Polish mixer test, remove any too verbose output 2017-01-03 20:32:33 -05:00
Lorenz Meier
c27728a7aa Test VTOL test mixers 2017-01-03 20:32:33 -05:00
Lorenz Meier
fb8243d5e1 Mixer test: Fix test, failing right now but showing the real issues 2017-01-03 20:32:33 -05:00
Beat Küng
000d965a5e fix test_uart_loopback: 0 is a valid file descriptor 2017-01-03 14:44:45 +01:00
Lorenz Meier
9f3fe2a802 Fix unit tests leaking resources
This was harmless but none the less is not good style and needs fixing.
2017-01-03 14:44:45 +01:00
Daniel Agar
28971caaf3 partially restore mavlink_tests 2017-01-02 10:14:41 +01:00
Daniel Agar
74231e6656 split tests for SITL ctest 2017-01-02 10:14:41 +01:00
David Sidrane
b7521e1b38 Adding Test for sending break on u[s]arts 2016-12-21 08:34:22 +01:00
David Sidrane
c9f10107c0 Nuttx Upgrade:Adds sem_setprotocol 2016-12-21 08:34:21 +01:00
Lorenz Meier
92c35f26be Tests: Correct use of unsubscribe 2016-12-19 20:39:03 +01:00
Mark Whitehorn
86252e19e6 clean up other build targets 2016-12-10 12:56:39 +01:00