fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-04-14 10:07:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

test_mixer & mixer: use memmove instead of memcpy

Browse Source 
Both, src & dst use the same array, thus potentially overlapping.
Behavior of memcpy in that case is undefined.
This commit is contained in:
Beat Küng 2017-01-18 10:51:45 +01:00 committed by Lorenz Meier
parent 33a307873a
commit e7db0ed098
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/modules/px4iofirmware/mixer.cpp
View File

@ -532,7 +532,7 @@ mixer_handle_text(const void *buffer, size_t length)
/* copy any leftover text to the base of the buffer for re-use */
if (resid > 0) {
memcpy(&mixer_text[0], &mixer_text[mixer_text_length - resid], resid);
memmove(&mixer_text[0], &mixer_text[mixer_text_length - resid], resid);
/* enforce null termination */
mixer_text[resid] = '\0';
}

2
src/systemcmds/tests/test_mixer.cpp
View File

@ -334,7 +334,7 @@ bool MixerTest::load_mixer(const char *filename, const char *buf, unsigned loade
/* copy any leftover text to the base of the buffer for re-use */
if (resid > 0) {
memcpy(&mixer_text[0], &mixer_text[mixer_text_length - resid], resid);
memmove(&mixer_text[0], &mixer_text[mixer_text_length - resid], resid);
/* enforce null termination */
mixer_text[resid] = '\0';
}