Commit Graph

878 Commits

Author SHA1 Message Date
Mark Charlebois 1ca05aaa64 orb_advert_t changed to void * and checks changed to nullptr
The existing orb_advert_t use thoughout the code sometimes tries
to treat it as a file descriptor and there are checks for < 0
and ::close calls on orb_advert_t types which is an invalid use
of an object pointer, which is what orb_advert_t really is.

Initially I had changed the -1 initializations to 0 but it was
suggested that this should be nullptr. That was a good recommendation
but the definition of orb_advert_t had to change to void * because
you cannot initialize a uintptr_t as nullptr.

Signed-off-by: Mark Charlebois <charlebm@gmail.com>
2015-05-27 14:42:49 -07:00
Mark Charlebois a734fc96d1 extensive orb_advert_t fixes
The calls to orb_advertise were being mishandled throughout the code.
There were ::close() calls on memory pointers, there were checks
against < 0 when it is a pointer to a object and values larger than
0x7ffffffff are valid. Some places orb_advert_t variables were
being initialized as 0 other places as -1.

The orb_advert_t type was changed to uintptr_t so the pointer value
would not be wrapped as a negative number. This was causing a failure
on ARM.

Tests for < 0 were changed to == 0 since a null pointer is the valid
representation for error, or uninitialized.

Signed-off-by: Mark Charlebois <charlebm@gmail.com>
2015-05-27 14:41:33 -07:00
Lorenz Meier b399469477 Merge pull request #2240 from TSC21/mavlink_multiadvertise
mavlink: added multi advertise for distance_sensor in mavlink receiver
2015-05-26 23:32:50 -07:00
Lorenz Meier a14b020d63 Merge pull request #2203 from NaterGator/mavlink_usbfix
Fix MAVLink USB UART detection
2015-05-26 23:22:27 -07:00
TSC21 0d1bc2cd0b mavlink: added multi advertise for distance_sensor in mavlink receiver 2015-05-26 23:35:45 +01:00
Ban Siesta 40e9c83ed6 mavlink: no need to shout about disabling hardware flow control 2015-05-25 18:28:27 +01:00
Lorenz Meier c5f14ef785 Merge pull request #2224 from bansiesta/lidarlite_merge
Lidarlite merge and bringup
2015-05-24 23:18:52 +02:00
Don Gagne 4206b030bf Fix opendir failure handling 2015-05-24 10:40:52 -07:00
Ban Siesta 2fb999674b Merge remote-tracking branch 'px4/pr/2200' into lidarlite_merge 2015-05-24 16:30:02 +01:00
TSC21 72e9390985 distance_sensor: minor changes 2015-05-24 16:03:01 +01:00
Ban Siesta cf39e8c721 mavlink: adapted to change in distance_sensor msg 2015-05-24 15:58:44 +01:00
TSC21 36dfda4aea distance_sensor: mavlink_receiver: changed to SI units 2015-05-23 17:58:20 +01:00
TSC21 43668cc8c8 distance_sensor: adopt message in both range drivers and on ekf_att_pos_estimator 2015-05-23 17:49:52 +01:00
TSC21 6049365123 Merge branch 'master' 2015-05-23 11:24:15 +01:00
Lorenz Meier 8fd00f4d6d Merged release_v1.0.0 into master 2015-05-23 11:07:10 +02:00
Lorenz Meier ccac324f5b mavlink: Fix GIT string transmission 2015-05-23 11:04:19 +02:00
Lorenz Meier 6d7e063148 Added GIT version which recompiles on each build 2015-05-23 09:59:46 +02:00
Roman Bapst 0eeaa83b3d send autopilot version message on startup and on request 2015-05-23 09:59:46 +02:00
TSC21 1c12d8fc7c distance_sensor: added MAV_DISTANCE_SENSOR_INFRARED to topic stream 2015-05-21 12:41:41 +01:00
TSC21 db48df15c8 Merge branch 'master' 2015-05-21 12:26:55 +01:00
Nate Weibley b55361b472 Actually track USB uarts, eliminiate unnecessary passing / pointer to _is_usb_uart 2015-05-20 16:06:02 -04:00
Lorenz Meier 64ea4071a7 mavlink: Enable a few helpful streams on companion link 2015-05-20 21:02:58 +02:00
Lorenz Meier 9ea62e7402 mavlink: Enable a few helpful streams on companion link 2015-05-20 21:01:38 +02:00
Lorenz Meier fbdfc698cc Merge branch 'release_v1.0.0' 2015-05-20 20:24:39 +02:00
TSC21 80c7719b42 distance_sensor: typo correction on msg.type 2015-05-20 12:51:20 +01:00
Lorenz Meier 4dbaf71612 Remove unused actuator_controls_effective topic 2015-05-20 13:49:18 +02:00
TSC21 796b105382 distance_sensor: updated distance_sensor stream sub 2015-05-20 00:54:36 +01:00
TSC21 30218b0de7 distance_sensor: added mavlink_receiver handler for msg 2015-05-20 00:15:27 +01:00
Lorenz Meier d906fb8f31 Merged master into linux 2015-05-19 21:00:02 +02:00
Lorenz Meier d9d25363b4 mavlink FTP: Remove workaround after QGC side fix 2015-05-19 07:08:19 +02:00
Lorenz Meier e5fad077df Merge master into linux 2015-05-18 23:28:57 +02:00
Lorenz Meier 83fdb9931a commander / mavlink: Add battery status to output BATTERY_STATUS MAVLink message 2015-05-17 17:44:51 +02:00
Erik Jähne fcb1bb2bb6 FIX HIL GPS conversion 2015-05-17 14:50:17 +02:00
Lorenz Meier 3032afb803 mavlink FTP: Fix build system error for unit test 2015-05-17 10:48:37 +02:00
Mark Charlebois 36f5d47ed9 Merge remote-tracking branch 'upstream/master' into linux
Signed-off-by: Mark Charlebois <charlebm@gmail.com>

Conflicts:
	src/modules/commander/gyro_calibration.cpp
	src/modules/mavlink/mavlink_ftp.cpp
2015-05-16 15:04:38 -07:00
Lorenz Meier 2432418751 FTP: Better error reporting, ignore hidden directories 2015-05-16 11:37:41 +02:00
Lorenz Meier 97b8e7a20e mavlink FTP: Speed up transfers by longer bursts 2015-05-15 21:14:40 +02:00
Lorenz Meier dabcf63c50 mavlink FTP: Drop rate to realistic value 2015-05-15 11:16:48 +02:00
Lorenz Meier f154f6e5e7 MAVLink transmission: Allow faster overall transmissions. 2015-05-15 11:16:11 +02:00
Lorenz Meier 4fb91f47cd Fix mavlink FTP list stack overflow. Fixes #2180, not flight-critical 2015-05-15 11:15:04 +02:00
Lorenz Meier fa8dc57236 mavlink app: Only send params if the system has booted. 2015-05-15 08:31:45 +02:00
Nate Weibley b4e7b041ca Fix potential null pointer deref if Mavlink start fails before task_main loop
LL_APPEND is called just before the loop spins up but various error conditions can cause the task to exit before then.
When that happens Mavlink::start_helper calls delete on the instance which tries to prune it from the global list.
If this is the first Mavlink instance to attempt starting the list head is null and we hardfault in the Mavlink dtor.

Only call LL_DELETE after checking the list head for a null pointer.
2015-05-13 11:33:11 -04:00
Lorenz Meier 66b87ac761 Fix state-level HIL. Reported by @s3erjaeh 2015-05-13 16:04:33 +02:00
Mark Charlebois 2002d4e774 POSIX: disable UART in mavlink
Most of the current POSIX builds will not use the UART and it
is just a unnecessary dependency to satisfy when running in a
test environment.

Signed-off-by: Mark Charlebois <charlebm@gmail.com>
2015-05-07 10:07:18 -07:00
Thomas Gubler cc62033190 improve mavlink set_attitude_target handling
port #1920 to mavlink_receiver
fixes #1921
2015-05-07 16:44:54 +02:00
Mark Charlebois db52227409 Merge remote-tracking branch 'upstream/master' into linux
Signed-off-by: Mark Charlebois <charlebm@gmail.com>

Conflicts:
	src/modules/commander/accelerometer_calibration.cpp
2015-05-06 15:51:39 -07:00
Lorenz Meier 0d1d92484b MAVLink app: Parameter docs and new test parameter 2015-05-06 19:39:17 +02:00
Mark Charlebois 12a25e4b63 Merge remote-tracking branch 'upstream/master' into linux
Signed-off-by: Mark Charlebois <charlebm@gmail.com>

Conflicts:
	makefiles/firmware.mk
	src/modules/commander/module.mk
	src/modules/mavlink/mavlink_ftp.h
	src/modules/mavlink/mavlink_tests/module.mk
2015-05-04 16:36:59 -07:00
Don Gagne 46da294ffb New bust mode ftp file download 2015-05-03 19:26:54 -07:00
Mark Charlebois b408983d4c mavlink: added back MODULE_COMMAND
The MODULE_COMMAND was inadvertently removed during merge of master

Signed-off-by: Mark Charlebois <charlebm@gmail.com>
2015-04-28 17:27:14 -07:00