Commit Graph
8 Commits
Author SHA1 Message Date
Peter Duerr 453937a89a Fix va_arg calls (always call va_end)
From the manpage: "Each invocation of va_start() must be matched by a
corresponding invocation of va_end() in the same function."
2017-08-07 22:05:54 +02:00
Peter Duerr b845edba64 Yet another erroneous call to px4_close instead of close
* As indicated by @bkueng
2017-08-07 22:05:17 +02:00
Peter Duerr 6e808ad0a6 Fix additional erroneous px4_close call
* As indicated by @bkueng
2017-08-07 22:05:17 +02:00
Peter Duerr 73ef772537 Fix erroneous use of px4_close
* Close handle opened with `open` with `close` as indicated by @bkueng
2017-08-07 22:05:17 +02:00
Peter Duerr 40dff737c5 Fix uninitialized values identified by cppcheck
* Replace `malloc` by `calloc` for c-string initialization
* Add initializer braces for structs
2017-08-07 22:05:17 +02:00
Peter Duerr 7cf2a49948 Cosmetic fix (silencing cppcheck)
* For some reason cppcheck complains with `fp != nullptr` but accepts truthiness
  of handle by itself.
* Note that the expressions are equivalent according to the C++ standard ("A
  prvalue of arithmetic, unscoped enumeration, pointer, or pointer to member
  type can be converted to a prvalue of type bool. A zero value, null pointer
  value, or null member pointer value is converted to false; any other value is
  converted to true. A prvalue of type std::nullptr_t can be converted to a
  prvalue of type bool; the resulting value is false.")
2017-08-07 22:05:17 +02:00
Peter Duerr cc1b766824 Fix memory leaks identified by cppcheck
* Add `free` / `delete`
* Add comment explaining the (presumed) motivation for the use of new instead of
  allocating on the stack
2017-08-07 22:05:17 +02:00
Peter Duerr 5be23060e7 Fix resource leaks identified by cppcheck
* Where possible rearrange error checks to avoid branching
* Otherwise add missing `fclose`, `close`, `px4_close` calls before return
2017-08-07 22:05:17 +02:00