WIP: px4log

This commit is contained in:
Daniel Agar
2023-03-16 21:20:58 -04:00
parent 0ae296bfe2
commit b4555db0e7
245 changed files with 573 additions and 1185 deletions
-17
View File
@@ -20,23 +20,6 @@ document px4
. Use 'help <macro>' for more specific help.
end
define dmesg
if g_console_buffer
printf "PX4 dmesg:\n"
# TODO: respect head and tail
printf "%s\n", g_console_buffer._buffer
else
printf "PX4 dmesg unavailable\n"
end
end
document dmesg
. dmesg
. Prints dmesg (if available).
end
define _perf_print
set $hdr = (struct perf_ctr_header *)$arg0
#printf "%p\n", $hdr
@@ -39,7 +39,6 @@ if(NOT PX4_BOARD MATCHES "io-v2")
board_dma_alloc.c
board_fat_dma_alloc.c
cdc_acm_check.cpp
console_buffer.cpp
cpuload.cpp
gpio.c
print_load.cpp
@@ -1,239 +0,0 @@
/****************************************************************************
*
* Copyright (c) 2019 PX4 Development Team. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* 3. Neither the name PX4 nor the names of its contributors may be
* used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*
****************************************************************************/
#include <px4_platform_common/px4_config.h>
#include <px4_platform_common/console_buffer.h>
#include <px4_platform_common/defines.h>
#include <px4_platform_common/sem.h>
#include <pthread.h>
#include <string.h>
#include <fcntl.h>
#ifdef BOARD_ENABLE_CONSOLE_BUFFER
#ifndef BOARD_CONSOLE_BUFFER_SIZE
# define BOARD_CONSOLE_BUFFER_SIZE (1024*4) // default buffer size
#endif
static ssize_t console_buffer_write(struct file *filep, const char *buffer, size_t buflen);
class ConsoleBuffer
{
public:
void write(const char *buffer, size_t len);
void print(bool follow);
int size();
int read(char *buffer, int buffer_length, int *offset);
private:
void lock() { do {} while (px4_sem_wait(&_lock) != 0); }
void unlock() { px4_sem_post(&_lock); }
char _buffer[BOARD_CONSOLE_BUFFER_SIZE];
int _head{0};
int _tail{0};
px4_sem_t _lock = SEM_INITIALIZER(1);
};
void ConsoleBuffer::print(bool follow)
{
// print to stdout, but with a buffer in between to avoid nested locking and potential dead-locks
// (which could happen in combination with the MAVLink shell: dmesg writing to the pipe waiting
// mavlink to read, while mavlink calls printf, waiting for the console lock)
const int buffer_length = 512;
char buffer[buffer_length];
int offset = -1;
do {
// print the full buffer or what's newly added
int total_size_read = 0;
do {
int read_size = read(buffer, buffer_length, &offset);
if (read_size <= 0) {
break;
}
::write(1, buffer, read_size);
if (read_size < buffer_length) {
break;
}
total_size_read += read_size;
} while (total_size_read < BOARD_CONSOLE_BUFFER_SIZE);
if (follow) {
usleep(10000);
}
} while (follow);
}
void ConsoleBuffer::write(const char *buffer, size_t len)
{
lock(); // same rule as for printf: this cannot be used from IRQ handlers
for (size_t i = 0; i < len; ++i) {
_buffer[_tail] = buffer[i];
_tail = (_tail + 1) % BOARD_CONSOLE_BUFFER_SIZE;
if (_tail == _head) {
_head = (_head + 1) % BOARD_CONSOLE_BUFFER_SIZE;
}
}
unlock();
}
int ConsoleBuffer::size()
{
lock();
int size;
if (_head <= _tail) {
size = _tail - _head;
} else {
size = BOARD_CONSOLE_BUFFER_SIZE - (_head - _tail);
}
unlock();
return size;
}
int ConsoleBuffer::read(char *buffer, int buffer_length, int *offset)
{
lock();
if (*offset == -1) {
*offset = _head;
}
int size = 0;
if (*offset < _tail) {
size = _tail - *offset;
if (size > buffer_length) {
size = buffer_length;
}
memcpy(buffer, _buffer + *offset, size);
} else if (_tail < *offset) {
size = BOARD_CONSOLE_BUFFER_SIZE - *offset;
if (size > buffer_length) {
size = buffer_length;
}
memcpy(buffer, _buffer + *offset, size);
buffer += size;
buffer_length -= size;
int size_secondary = _tail;
if (size_secondary > buffer_length) {
size_secondary = buffer_length;
}
if (size_secondary > 0) {
memcpy(buffer, _buffer, size_secondary);
size += size_secondary;
}
}
unlock();
*offset = (*offset + size) % BOARD_CONSOLE_BUFFER_SIZE;
return size;
}
static ConsoleBuffer g_console_buffer;
void px4_console_buffer_print(bool follow)
{
g_console_buffer.print(follow);
}
ssize_t console_buffer_write(struct file *filep, const char *buffer, size_t len)
{
g_console_buffer.write(buffer, len);
// stderr still points to our original console and is available from everywhere, so we output to that.
// We could use up_putc() as well, but it is considerably less efficient.
// The drawback here is that a module writing to stderr bypasses the console buffer.
write(2, buffer, len);
fsync(2);
return len;
}
static const struct file_operations g_console_buffer_fops = {
NULL, /* open */
NULL, /* close */
NULL, /* read */
console_buffer_write, /* write */
NULL, /* seek */
NULL /* ioctl */
#ifndef CONFIG_DISABLE_POLL
, NULL /* poll */
#endif
#ifndef CONFIG_DISABLE_PSEUDOFS_OPERATIONS
, NULL /* unlink */
#endif
};
int px4_console_buffer_init()
{
return register_driver(CONSOLE_BUFFER_DEVICE, &g_console_buffer_fops, 0666, NULL);
}
int px4_console_buffer_size()
{
return g_console_buffer.size();
}
int px4_console_buffer_read(char *buffer, int buffer_length, int *offset)
{
return g_console_buffer.read(buffer, buffer_length, offset);
}
#endif /* BOARD_ENABLE_CONSOLE_BUFFER */
@@ -1,65 +0,0 @@
/****************************************************************************
*
* Copyright (c) 2021 Technology Innovation Institute. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* 3. Neither the name PX4 nor the names of its contributors may be
* used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*
****************************************************************************/
#include <px4_platform_common/px4_config.h>
#include <px4_platform_common/console_buffer.h>
#include <px4_platform_common/defines.h>
#include <px4_platform_common/sem.h>
#include <pthread.h>
#include <string.h>
#include <fcntl.h>
#ifdef BOARD_ENABLE_CONSOLE_BUFFER
#ifndef BOARD_CONSOLE_BUFFER_SIZE
# define BOARD_CONSOLE_BUFFER_SIZE (1024*4) // default buffer size
#endif
// TODO: User side implementation of px4_console_buffer
int px4_console_buffer_init()
{
return 0;
}
int px4_console_buffer_size()
{
return 0;
}
int px4_console_buffer_read(char *buffer, int buffer_length, int *offset)
{
return 0;
}
#endif /* BOARD_ENABLE_CONSOLE_BUFFER */
+1 -17
View File
@@ -35,7 +35,6 @@
#include <px4_platform_common/log.h>
#include <px4_platform_common/px4_config.h>
#include <px4_platform_common/px4_manifest.h>
#include <px4_platform_common/console_buffer.h>
#include <px4_platform_common/defines.h>
#include <drivers/drv_hrt.h>
#include <lib/parameters/param.h>
@@ -102,21 +101,6 @@ int px4_platform_init()
kernel_ioctl_initialize();
#endif
int ret = px4_console_buffer_init();
if (ret < 0) {
return ret;
}
// replace stdout with our buffered console
int fd_buf = open(CONSOLE_BUFFER_DEVICE, O_WRONLY);
if (fd_buf >= 0) {
dup2(fd_buf, 1);
// keep stderr(2) untouched: the buffered console will use it to output to the original console
close(fd_buf);
}
#if defined(PX4_CRYPTO)
PX4Crypto::px4_crypto_init();
#endif
@@ -165,7 +149,7 @@ int px4_platform_init()
#if defined(CONFIG_FS_PROCFS)
int ret_mount_procfs = mount(nullptr, "/proc", "procfs", 0, nullptr);
if (ret < 0) {
if (ret_mount_procfs < 0) {
syslog(LOG_ERR, "ERROR: Failed to mount procfs at /proc: %d\n", ret_mount_procfs);
}
@@ -5,7 +5,6 @@ add_library(px4_layer
board_dma_alloc.c
board_fat_dma_alloc.c
tasks.cpp
console_buffer_usr.cpp
cdc_acm_check.cpp
${PX4_SOURCE_DIR}/platforms/posix/src/px4/common/print_load.cpp
${PX4_SOURCE_DIR}/platforms/posix/src/px4/common/cpuload.cpp
@@ -273,7 +273,7 @@ __EXPORT void board_spi_reset(int ms, int bus_mask)
// wait for the sensor rail to reach GND
usleep(ms * 1000);
syslog(LOG_DEBUG, "reset done, %d ms\n", ms);
PX4_DEBUG("reset done, %d ms\n", ms);
/* re-enable power */
@@ -34,6 +34,7 @@
#include <board_config.h>
#include <systemlib/px4_macros.h>
#include <px4_platform_common/spi.h>
#include <px4_platform_common/log.h>
#include <stdint.h>
#include <stdbool.h>
@@ -471,7 +472,7 @@ __EXPORT void board_spi_reset(int ms, int bus_mask)
// wait for the sensor rail to reach GND
usleep(ms * 1000);
syslog(LOG_DEBUG, "reset done, %d ms\n", ms);
PX4_DEBUG("reset done, %d ms\n", ms);
/* re-enable power */