PX4-Autopilot/src/modules/manual_control/ManualControlSelectorTest.cpp

/****************************************************************************
 *
 *   Copyright (c) 2021 PX4 Development Team. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in
 *    the documentation and/or other materials provided with the
 *    distribution.
 * 3. Neither the name PX4 nor the names of its contributors may be
 *    used to endorse or promote products derived from this software
 *    without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
 * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
 * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
 * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
 * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
 * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
 * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 *
 ****************************************************************************/

#include "ManualControlSelector.hpp"
#include <gtest/gtest.h>
#include <drivers/drv_hrt.h>

using namespace time_literals;

static constexpr uint64_t SOME_TIME = 12345678;
static constexpr uint8_t SOURCE_RC = manual_control_setpoint_s::SOURCE_RC;
static constexpr uint8_t SOURCE_MAVLINK_0 = manual_control_setpoint_s::SOURCE_MAVLINK_0;
static constexpr uint8_t SOURCE_MAVLINK_1 = manual_control_setpoint_s::SOURCE_MAVLINK_1;
static constexpr uint8_t SOURCE_MAVLINK_2 = manual_control_setpoint_s::SOURCE_MAVLINK_2;
static constexpr uint8_t SOURCE_MAVLINK_3 = manual_control_setpoint_s::SOURCE_MAVLINK_3;
static constexpr uint8_t SOURCE_MAVLINK_4 = manual_control_setpoint_s::SOURCE_MAVLINK_4;

TEST(ManualControlSelector, RcInputInvalidValid)
{
	ManualControlSelector selector;
	selector.setRcInMode(0);
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	// Now provide input with the correct source flagged invalid
	manual_control_setpoint_s input {};
	input.data_source = SOURCE_RC;
	input.valid = false;
	input.timestamp_sample = timestamp;

	for (int i = 0; i < 2; i++) {
		selector.updateWithNewInputSample(timestamp, input, 1);
		EXPECT_FALSE(selector.setpoint().valid);
		EXPECT_EQ(selector.setpoint().timestamp_sample, 0);
		EXPECT_EQ(selector.instance(), -1);
		EXPECT_EQ(selector.setpoint().data_source, 0);
		timestamp += 100_ms;
		input.timestamp_sample = timestamp;
	}

	input.valid = true;
	selector.updateWithNewInputSample(timestamp, input, 1);
	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().timestamp_sample, timestamp);
	EXPECT_EQ(selector.instance(), 1);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
}

TEST(ManualControlSelector, RcInputContinuous)
{
	ManualControlSelector selector;
	selector.setRcInMode(0);
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	// Now provide input with the correct source.
	manual_control_setpoint_s input {};
	input.data_source = SOURCE_RC;
	input.valid = true;
	input.timestamp_sample = timestamp;

	for (int i = 0; i < 5; i++) {
		selector.updateWithNewInputSample(timestamp, input, 1);
		EXPECT_TRUE(selector.setpoint().valid);
		EXPECT_EQ(selector.setpoint().timestamp_sample, timestamp);
		EXPECT_EQ(selector.instance(), 1);
		EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
		timestamp += 100_ms;
		input.timestamp_sample = timestamp;
	}
}

TEST(ManualControlSelector, RcInputOnly)
{
	ManualControlSelector selector;
	selector.setRcInMode(0); // Configure RC input only
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	manual_control_setpoint_s input {};
	input.data_source = SOURCE_MAVLINK_0;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_FALSE(selector.setpoint().valid);

	timestamp += 100_ms;

	// Now provide input with the correct source.
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 1);
}

TEST(ManualControlSelector, MavlinkInputOnly)
{
	ManualControlSelector selector;
	selector.setRcInMode(1); // Configure MAVLink input only
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	manual_control_setpoint_s input {};
	input.data_source = SOURCE_RC;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_FALSE(selector.setpoint().valid);

	timestamp += 100_ms;

	// Now provide input with the correct source.
	input.data_source = SOURCE_MAVLINK_3;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_3);
	EXPECT_EQ(selector.instance(), 1);

	timestamp += 100_ms;

	// But only the first MAVLink source wins, others are too late.
	input.data_source = SOURCE_MAVLINK_4;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_3);
	EXPECT_EQ(selector.instance(), 1);
}

TEST(ManualControlSelector, RcMavlinkInputFallback)
{
	ManualControlSelector selector;
	selector.setRcInMode(2); // Configure fallback
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	// Valid RC input gets used
	manual_control_setpoint_s input {};
	input.data_source = SOURCE_RC;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 100_ms;

	// Now provide input from MAVLink as well which should get ignored
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 500_ms;

	// Now we update MAVLink and let RC time out, so it should switch to RC
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	// If we get RC back immediately, it stays with MAVLink (until RC is lost again)
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);
}

TEST(ManualControlSelector, RcMavlinkInputKeepFirst)
{
	ManualControlSelector selector;
	selector.setRcInMode(3); // Configure keep first input
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	manual_control_setpoint_s input {};
	input.data_source = SOURCE_RC;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 100_ms;

	// Now provide input from MAVLink as well which should get ignored.
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 500_ms;

	// Now we'll let RC time out, but it should NOT switch to MAVLINK because RC was first
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_FALSE(selector.setpoint().valid);
	EXPECT_NE(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), -1);

	timestamp += 100_ms;

	// Provide input from RC again and it should get accepted because it was the first.
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);
}

TEST(ManualControlSelector, DisabledInput)
{
	ManualControlSelector selector;
	selector.setRcInMode(4); // Configure disabled stick input
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	manual_control_setpoint_s input {};
	// Reject MAVLink stick input
	input.data_source = SOURCE_MAVLINK_0;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_FALSE(selector.setpoint().valid);
	EXPECT_EQ(selector.instance(), -1);

	timestamp += 100_ms;

	// Reject RC stick input
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_FALSE(selector.setpoint().valid);
	EXPECT_EQ(selector.instance(), -1);
}

TEST(ManualControlSelector, RcTimeout)
{
	ManualControlSelector selector;
	selector.setRcInMode(0);
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	manual_control_setpoint_s input {};
	input.data_source = SOURCE_RC;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 600_ms;

	// Update, to make sure it notices the timeout
	selector.updateValidityOfChosenInput(timestamp);

	EXPECT_FALSE(selector.setpoint().valid);
	EXPECT_EQ(selector.instance(), -1);
}

TEST(ManualControlSelector, RcOutdated)
{
	ManualControlSelector selector;
	selector.setRcInMode(0);
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	manual_control_setpoint_s input {};
	input.data_source = SOURCE_RC;
	input.valid = true;
	input.timestamp_sample = timestamp - 600_ms; // First sample is already outdated
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_FALSE(selector.setpoint().valid);
	EXPECT_EQ(selector.instance(), -1);

	// If we update again it should still not get accepted
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_FALSE(selector.setpoint().valid);
	EXPECT_EQ(selector.instance(), -1);
}

TEST(ManualControlSelector, PriorityRcThenMavlinkAscending)
{
	ManualControlSelector selector;
	selector.setRcInMode(5); // Configure RC, then Joystick ascending
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	// Valid RC input gets used
	manual_control_setpoint_s input{};
	input.data_source = SOURCE_RC;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 100_ms;

	// Now provide input from MAVLink 0 as well which should get ignored
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 500_ms;

	// Now we update MAVLink 0 and let RC time out, so it should switch to MAVLink 0
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	// If we get RC back immediately, it should take over with priority
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 100_ms;

	// Now provide input from MAVLink 1, which should get ignored
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 500_ms;

	// Now we update MAVLink 1 and let RC time out, so it should switch to MAVLink 1
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	timestamp += 100_ms;

	// Now provide input from MAVLink 0, which has higher priority and should take over
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	// If we get MAVLink 1 back immediately, it should be ignored since MAVLink 0 has higher priority
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	timestamp += 500_ms;

	// Now we update MAVLink 1 and let MAVLink 0 time out, so it should switch to MAVLink 1
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);
}

TEST(ManualControlSelector, PriorityMavlinkAscendingThenRc)
{
	ManualControlSelector selector;
	selector.setRcInMode(6); // Configure Joystick ascending, then RC
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	// Valid MAVLink 0 input gets used
	manual_control_setpoint_s input{};
	input.data_source = SOURCE_MAVLINK_0;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	timestamp += 100_ms;

	// Now provide input from MAVLink 1 as well which should get ignored
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	timestamp += 500_ms;

	// Now we update MAVLink 1 and let MAVLink 0 time out, so it should switch to MAVLink 1
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	// If we get MAVLink 0 back immediately, it should take over with priority
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	timestamp += 100_ms;

	// Now provide input from RC, which should get ignored
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	timestamp += 500_ms;

	// Now we update RC and let MAVLink 0 time out, so it should switch to RC
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 100_ms;

	// Now provide input from MAVLink 1, which has higher priority and should take over
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	// If we get RC back immediately, it should be ignored since MAVLink 1 has higher priority
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	timestamp += 500_ms;

	// Now we update RC and let MAVLink 1 time out, so it should switch to RC
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);
}

TEST(ManualControlSelector, PriorityRcThenMavlinkDescending)
{
	ManualControlSelector selector;
	selector.setRcInMode(7); // Configure RC, then Joystick descending
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	// Valid RC input gets used
	manual_control_setpoint_s input{};
	input.data_source = SOURCE_RC;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 100_ms;

	// Now provide input from MAVLink 1 as well which should get ignored
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 500_ms;

	// Now we update MAVLink 0 and let RC time out, so it should switch to MAVLink 0
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	// If we get RC back immediately, it should take over with priority
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 100_ms;

	// Now provide input from MAVLink 0, which should get ignored
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 500_ms;

	// Now we update MAVLink 0 and let RC time out, so it should switch to MAVLink 0
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	timestamp += 100_ms;

	// Now provide input from MAVLink 1, which has higher priority and should take over
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	// If we get MAVLink 0 back immediately, it should be ignored since MAVLink 1 has higher priority
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	timestamp += 500_ms;

	// Now we update MAVLink 0 and let MAVLink 1 time out, so it should switch to MAVLink 0
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);
}

TEST(ManualControlSelector, PriorityMavlinkDescendingThenRc)
{
	ManualControlSelector selector;
	selector.setRcInMode(8); // Configure Joystick descending, then RC
	selector.setTimeout(500_ms);

	uint64_t timestamp = SOME_TIME;

	// Valid MAVLink 1 input gets used
	manual_control_setpoint_s input{};
	input.data_source = SOURCE_MAVLINK_1;
	input.valid = true;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	timestamp += 100_ms;

	// Now provide input from MAVLink 0 as well which should get ignored
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	timestamp += 500_ms;

	// Now we update MAVLink 0 and let MAVLink 1 time out, so it should switch to MAVLink 0
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	// If we get MAVLink 1 back immediately, it should take over with priority
	input.data_source = SOURCE_MAVLINK_1;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 2);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	timestamp += 100_ms;

	// Now provide input from RC, which should get ignored
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_1);
	EXPECT_EQ(selector.instance(), 2);

	timestamp += 500_ms;

	// Now we update RC and let MAVLink 1 time out, so it should switch to RC
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);

	timestamp += 100_ms;

	// Now provide input from MAVLink 0, which has higher priority and should take over
	input.data_source = SOURCE_MAVLINK_0;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 1);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	// If we get RC back immediately, it should be ignored since MAVLink 0 has higher priority
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_MAVLINK_0);
	EXPECT_EQ(selector.instance(), 1);

	timestamp += 500_ms;

	// Now we update RC and let MAVLink 0 time out, so it should switch to RC
	input.data_source = SOURCE_RC;
	input.timestamp_sample = timestamp;
	selector.updateWithNewInputSample(timestamp, input, 0);

	EXPECT_TRUE(selector.setpoint().valid);
	EXPECT_EQ(selector.setpoint().data_source, SOURCE_RC);
	EXPECT_EQ(selector.instance(), 0);
}