navigator remove redundant param updates

src/modules/navigator/datalinkloss.cpp

@@ -70,8 +70,6 @@ DataLinkLoss::DataLinkLoss(Navigator *navigator, const char *name) :
 	_param_skipcommshold(this, "CHSK"),
 	_dll_state(DLL_STATE_NONE)
 {
-	/* load initial params */
-	updateParams();
 	/* initial reset */
 	on_inactive();
 }

src/modules/navigator/enginefailure.cpp

@@ -58,8 +58,6 @@ EngineFailure::EngineFailure(Navigator *navigator, const char *name) :
 	MissionBlock(navigator, name),
 	_ef_state(EF_STATE_NONE)
 {
-	/* load initial params */
-	updateParams();
 	/* initial reset */
 	on_inactive();
 }

src/modules/navigator/follow_target.cpp

@@ -80,7 +80,6 @@ FollowTarget::FollowTarget(Navigator *navigator, const char *name) :
 	_yaw_auto_max(0.0F),
 	_yaw_angle(0.0F)
 {
-	updateParams();
 	_current_target_motion = {};
 	_previous_target_motion =  {};
 	_current_vel.zero();

src/modules/navigator/geofence.cpp

@@ -63,8 +63,6 @@ Geofence::Geofence(Navigator *navigator) :
 	_param_max_hor_distance(this, "GF_MAX_HOR_DIST", false),
 	_param_max_ver_distance(this, "GF_MAX_VER_DIST", false)
 {
-	updateParams();
-
 	// we assume there's no concurrent fence update on startup
 	_updateFence();
 }

src/modules/navigator/gpsfailure.cpp

@@ -62,9 +62,6 @@ GpsFailure::GpsFailure(Navigator *navigator, const char *name) :
 	_gpsf_state(GPSF_STATE_NONE),
 	_timestamp_activation(0)
 {
-	/* load initial params */
-	updateParams();
-
 	/* initial reset */
 	on_inactive();
 }

src/modules/navigator/land.cpp

@@ -56,8 +56,6 @@
 Land::Land(Navigator *navigator, const char *name) :
 	MissionBlock(navigator, name)
 {
-	/* load initial params */
-	updateParams();
 }
 
 Land::~Land()

src/modules/navigator/loiter.cpp

@@ -61,8 +61,6 @@ Loiter::Loiter(Navigator *navigator, const char *name) :
 	_param_yawmode(this, "MIS_YAWMODE", false),
 	_loiter_pos_set(false)
 {
-	// load initial params
-	updateParams();
 }
 
 Loiter::~Loiter()

src/modules/navigator/mission.cpp

@@ -69,7 +69,6 @@ Mission::Mission(Navigator *navigator, const char *name) :
 	_param_fw_climbout_diff(this, "FW_CLMBOUT_DIFF", false),
 	_missionFeasibilityChecker(navigator)
 {
-	updateParams();
 }
 
 void

src/modules/navigator/navigator_main.cpp

@@ -118,8 +118,6 @@ Navigator::Navigator() :
 	_navigation_mode_array[7] = &_takeoff;
 	_navigation_mode_array[8] = &_land;
 	_navigation_mode_array[9] = &_follow_target;
-
-	updateParams();
 }
 
 Navigator::~Navigator()
@@ -214,10 +212,6 @@ Navigator::params_update()
 	parameter_update_s param_update;
 	orb_copy(ORB_ID(parameter_update), _param_update_sub, &param_update);
 	updateParams();
-
-	if (_navigation_mode) {
-		_navigation_mode->updateParams();
-	}
 }
 
 void

src/modules/navigator/navigator_mode.cpp

@@ -47,8 +47,6 @@ NavigatorMode::NavigatorMode(Navigator *navigator, const char *name) :
 	_navigator(navigator),
 	_active(false)
 {
-	/* load initial params */
-	updateParams();
 	/* set initial mission items */
 	on_inactivation();
 	on_inactive();

src/modules/navigator/rcloss.cpp

@@ -60,8 +60,6 @@ RCLoss::RCLoss(Navigator *navigator, const char *name) :
 	_param_loitertime(this, "LT"),
 	_rcl_state(RCL_STATE_NONE)
 {
-	/* load initial params */
-	updateParams();
 	/* initial reset */
 	on_inactive();
 }

src/modules/navigator/takeoff.cpp

@@ -57,8 +57,6 @@ Takeoff::Takeoff(Navigator *navigator, const char *name) :
 	MissionBlock(navigator, name),
 	_param_min_alt(this, "MIS_TAKEOFF_ALT", false)
 {
-	// load initial params
-	updateParams();
 }
 
 Takeoff::~Takeoff()