diff --git a/src/modules/navigator/datalinkloss.cpp b/src/modules/navigator/datalinkloss.cpp index cfea39158d..6312581026 100644 --- a/src/modules/navigator/datalinkloss.cpp +++ b/src/modules/navigator/datalinkloss.cpp @@ -70,8 +70,6 @@ DataLinkLoss::DataLinkLoss(Navigator *navigator, const char *name) : _param_skipcommshold(this, "CHSK"), _dll_state(DLL_STATE_NONE) { - /* load initial params */ - updateParams(); /* initial reset */ on_inactive(); } diff --git a/src/modules/navigator/enginefailure.cpp b/src/modules/navigator/enginefailure.cpp index a191df00e5..e8cdfa2a58 100644 --- a/src/modules/navigator/enginefailure.cpp +++ b/src/modules/navigator/enginefailure.cpp @@ -58,8 +58,6 @@ EngineFailure::EngineFailure(Navigator *navigator, const char *name) : MissionBlock(navigator, name), _ef_state(EF_STATE_NONE) { - /* load initial params */ - updateParams(); /* initial reset */ on_inactive(); } diff --git a/src/modules/navigator/follow_target.cpp b/src/modules/navigator/follow_target.cpp index 87677f4a95..b756717473 100644 --- a/src/modules/navigator/follow_target.cpp +++ b/src/modules/navigator/follow_target.cpp @@ -80,7 +80,6 @@ FollowTarget::FollowTarget(Navigator *navigator, const char *name) : _yaw_auto_max(0.0F), _yaw_angle(0.0F) { - updateParams(); _current_target_motion = {}; _previous_target_motion = {}; _current_vel.zero(); diff --git a/src/modules/navigator/geofence.cpp b/src/modules/navigator/geofence.cpp index b4adfdc334..cb9b155ad0 100644 --- a/src/modules/navigator/geofence.cpp +++ b/src/modules/navigator/geofence.cpp @@ -63,8 +63,6 @@ Geofence::Geofence(Navigator *navigator) : _param_max_hor_distance(this, "GF_MAX_HOR_DIST", false), _param_max_ver_distance(this, "GF_MAX_VER_DIST", false) { - updateParams(); - // we assume there's no concurrent fence update on startup _updateFence(); } diff --git a/src/modules/navigator/gpsfailure.cpp b/src/modules/navigator/gpsfailure.cpp index a1f7c8cc50..9849fde111 100644 --- a/src/modules/navigator/gpsfailure.cpp +++ b/src/modules/navigator/gpsfailure.cpp @@ -62,9 +62,6 @@ GpsFailure::GpsFailure(Navigator *navigator, const char *name) : _gpsf_state(GPSF_STATE_NONE), _timestamp_activation(0) { - /* load initial params */ - updateParams(); - /* initial reset */ on_inactive(); } diff --git a/src/modules/navigator/land.cpp b/src/modules/navigator/land.cpp index 4fa0e8ad54..ba1f50096a 100644 --- a/src/modules/navigator/land.cpp +++ b/src/modules/navigator/land.cpp @@ -56,8 +56,6 @@ Land::Land(Navigator *navigator, const char *name) : MissionBlock(navigator, name) { - /* load initial params */ - updateParams(); } Land::~Land() diff --git a/src/modules/navigator/loiter.cpp b/src/modules/navigator/loiter.cpp index f0d356e86a..c08affd272 100644 --- a/src/modules/navigator/loiter.cpp +++ b/src/modules/navigator/loiter.cpp @@ -61,8 +61,6 @@ Loiter::Loiter(Navigator *navigator, const char *name) : _param_yawmode(this, "MIS_YAWMODE", false), _loiter_pos_set(false) { - // load initial params - updateParams(); } Loiter::~Loiter() diff --git a/src/modules/navigator/mission.cpp b/src/modules/navigator/mission.cpp index d9edf45a29..9bec297659 100644 --- a/src/modules/navigator/mission.cpp +++ b/src/modules/navigator/mission.cpp @@ -69,7 +69,6 @@ Mission::Mission(Navigator *navigator, const char *name) : _param_fw_climbout_diff(this, "FW_CLMBOUT_DIFF", false), _missionFeasibilityChecker(navigator) { - updateParams(); } void diff --git a/src/modules/navigator/navigator_main.cpp b/src/modules/navigator/navigator_main.cpp index 801f8d7b66..107c184a4d 100644 --- a/src/modules/navigator/navigator_main.cpp +++ b/src/modules/navigator/navigator_main.cpp @@ -118,8 +118,6 @@ Navigator::Navigator() : _navigation_mode_array[7] = &_takeoff; _navigation_mode_array[8] = &_land; _navigation_mode_array[9] = &_follow_target; - - updateParams(); } Navigator::~Navigator() @@ -214,10 +212,6 @@ Navigator::params_update() parameter_update_s param_update; orb_copy(ORB_ID(parameter_update), _param_update_sub, ¶m_update); updateParams(); - - if (_navigation_mode) { - _navigation_mode->updateParams(); - } } void diff --git a/src/modules/navigator/navigator_mode.cpp b/src/modules/navigator/navigator_mode.cpp index 51debc68fe..9b32a58498 100644 --- a/src/modules/navigator/navigator_mode.cpp +++ b/src/modules/navigator/navigator_mode.cpp @@ -47,8 +47,6 @@ NavigatorMode::NavigatorMode(Navigator *navigator, const char *name) : _navigator(navigator), _active(false) { - /* load initial params */ - updateParams(); /* set initial mission items */ on_inactivation(); on_inactive(); diff --git a/src/modules/navigator/rcloss.cpp b/src/modules/navigator/rcloss.cpp index 92f679b9a1..388f2a6246 100644 --- a/src/modules/navigator/rcloss.cpp +++ b/src/modules/navigator/rcloss.cpp @@ -60,8 +60,6 @@ RCLoss::RCLoss(Navigator *navigator, const char *name) : _param_loitertime(this, "LT"), _rcl_state(RCL_STATE_NONE) { - /* load initial params */ - updateParams(); /* initial reset */ on_inactive(); } diff --git a/src/modules/navigator/takeoff.cpp b/src/modules/navigator/takeoff.cpp index f186671646..edd7787ea0 100644 --- a/src/modules/navigator/takeoff.cpp +++ b/src/modules/navigator/takeoff.cpp @@ -57,8 +57,6 @@ Takeoff::Takeoff(Navigator *navigator, const char *name) : MissionBlock(navigator, name), _param_min_alt(this, "MIS_TAKEOFF_ALT", false) { - // load initial params - updateParams(); } Takeoff::~Takeoff()