Move __STDC_FORMAT_MACROS to build system

__STDC_FORMAT_MACROS changes the behavior of inttypes.h to allow
defining format macros for printf-like functions. It needs to be defined
before any include is done, otherwise due to include chains and header
guards it may not take effect.

Instead of having to define it everywhere it is used, move the define to the
build system. Also update ecl and DriverFramework submodules to deal with the
changed definitions.

Tools/generate_listener.py

@@ -115,7 +115,6 @@ print("""
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 
 #ifndef PRIu64

cmake/common/px4_base.cmake

@@ -787,6 +787,7 @@ function(px4_add_common_flags)
 	string(REPLACE "-" "_" board_config ${board_upper})
 	set(added_definitions
 		-DCONFIG_ARCH_BOARD_${board_config}
+		-D__STDC_FORMAT_MACROS
 		)
 
 	if (NOT (APPLE AND (${CMAKE_C_COMPILER_ID} MATCHES ".*Clang.*")))

src/drivers/drv_hrt.h

@@ -41,7 +41,6 @@
 
 #include <sys/types.h>
 #include <stdbool.h>
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 
 #include <px4_time.h>

src/drivers/px4flow/i2c_frame.h

@@ -41,7 +41,6 @@
 #ifndef I2C_FRAME_H_
 #define I2C_FRAME_H_
 
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 
 typedef  struct i2c_frame {

src/lib/controllib/block/Block.hpp

@@ -39,7 +39,6 @@
 
 #pragma once
 
-#define __STDC_FORMAT_MACROS
 #include <stdint.h>
 #include <inttypes.h>
 

src/modules/px4iofirmware/protocol.h

@@ -33,7 +33,6 @@
 
 #pragma once
 
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 
 /**

src/modules/systemlib/err.c

@@ -40,7 +40,6 @@
 
 #include <px4_config.h>
 
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 
 #include <stdlib.h>

src/modules/systemlib/uthash/uthash.h

@@ -61,7 +61,6 @@ do {
 typedef unsigned int uint32_t;
 typedef unsigned char uint8_t;
 #else
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>   /* uint32_t */
 #endif
 

src/platforms/posix/drivers/barosim/baro.cpp

@@ -36,7 +36,6 @@
  * Driver for the simulated barometric pressure sensor
  */
 
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 #include <px4_config.h>
 #include <px4_defines.h>

src/platforms/posix/drivers/gpssim/gpssim.cpp

@@ -37,7 +37,6 @@
  */
 
 #include <sys/types.h>
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 #include <stdio.h>
 #include <stdbool.h>

src/platforms/posix/drivers/gyrosim/gyrosim.cpp

@@ -41,7 +41,6 @@
  * @author Mark Charlebois
  */
 
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 
 #include <px4_config.h>

src/platforms/posix/px4_layer/drv_hrt.c

@@ -45,7 +45,6 @@
 #include <semaphore.h>
 #include <time.h>
 #include <string.h>
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 #include <errno.h>
 #include "hrt_work.h"

src/platforms/px4_log.h

@@ -118,7 +118,6 @@ static inline void do_nothing(int level, ...)
 
 #else
 
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 #include <stdint.h>
 #include <sys/cdefs.h>

src/platforms/px4_nodehandle.h

@@ -48,7 +48,6 @@
 /* includes when building for ros */
 #include "ros/ros.h"
 #include <list>
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 #include <type_traits>
 #else

src/systemcmds/tests/test_bson.c

@@ -37,7 +37,6 @@
  * Tests for the bson en/decoder
  */
 
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 
 #include <px4_defines.h>

src/systemcmds/tests/test_int.c

@@ -36,7 +36,6 @@
  * Included Files
  ****************************************************************************/
 
-#define __STDC_FORMAT_MACROS
 #include <inttypes.h>
 
 #include <px4_config.h>