mirror of
https://gitee.com/mirrors_PX4/PX4-Autopilot.git
synced 2026-04-14 10:07:39 +08:00
When the last WorkItem is deleted, it is removed from a work queue and the queue is being stopped. But, the queue itself might get deleted in the middle, in a higher priority thread than where the WorkItem deletion was performed from If the WorkQueue::Detach accesses the member variables after this, there is memory corruption This happens in particular when launching i2c or spi devices in I2CSPIDriverBase::module_start: - The "initializer" is deleted when the instance is not found and the iterator while loop continues. - The workqueue is deleted in the middle of "initializer" deletion when the WorkQueueRunner returns. This prevents deletion of the WorkQueue before the Detach has been finished, in the specific case that the ::Detach triggers the deletion Signed-off-by: Jukka Laitinen <jukkax@ssrc.tii.ae>
235 lines
5.2 KiB
C++
235 lines
5.2 KiB
C++
/****************************************************************************
|
|
*
|
|
* Copyright (c) 2019 PX4 Development Team. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* 3. Neither the name PX4 nor the names of its contributors may be
|
|
* used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
|
|
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
|
|
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
|
|
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
|
|
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
|
|
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
****************************************************************************/
|
|
|
|
#include <px4_platform_common/px4_work_queue/WorkQueue.hpp>
|
|
#include <px4_platform_common/px4_work_queue/WorkItem.hpp>
|
|
|
|
#include <string.h>
|
|
|
|
#include <px4_platform_common/tasks.h>
|
|
#include <px4_platform_common/time.h>
|
|
#include <drivers/drv_hrt.h>
|
|
|
|
namespace px4
|
|
{
|
|
|
|
WorkQueue::WorkQueue(const wq_config_t &config) :
|
|
_config(config)
|
|
{
|
|
// set the threads name
|
|
#ifdef __PX4_DARWIN
|
|
pthread_setname_np(_config.name);
|
|
#else
|
|
pthread_setname_np(pthread_self(), _config.name);
|
|
#endif
|
|
|
|
#ifndef __PX4_NUTTX
|
|
px4_sem_init(&_qlock, 0, 1);
|
|
#endif /* __PX4_NUTTX */
|
|
|
|
px4_sem_init(&_process_lock, 0, 0);
|
|
px4_sem_setprotocol(&_process_lock, SEM_PRIO_NONE);
|
|
|
|
px4_sem_init(&_exit_lock, 0, 1);
|
|
px4_sem_setprotocol(&_exit_lock, SEM_PRIO_NONE);
|
|
}
|
|
|
|
WorkQueue::~WorkQueue()
|
|
{
|
|
|
|
work_lock();
|
|
|
|
// Synchronize with ::Detach
|
|
px4_sem_wait(&_exit_lock);
|
|
px4_sem_destroy(&_exit_lock);
|
|
|
|
px4_sem_destroy(&_process_lock);
|
|
work_unlock();
|
|
|
|
#ifndef __PX4_NUTTX
|
|
px4_sem_destroy(&_qlock);
|
|
#endif /* __PX4_NUTTX */
|
|
}
|
|
|
|
bool WorkQueue::Attach(WorkItem *item)
|
|
{
|
|
work_lock();
|
|
|
|
if (!should_exit()) {
|
|
_work_items.add(item);
|
|
work_unlock();
|
|
return true;
|
|
}
|
|
|
|
work_unlock();
|
|
|
|
return false;
|
|
}
|
|
|
|
void WorkQueue::Detach(WorkItem *item)
|
|
{
|
|
bool exiting = false;
|
|
|
|
work_lock();
|
|
|
|
_work_items.remove(item);
|
|
|
|
if (_work_items.size() == 0) {
|
|
// shutdown, no active WorkItems
|
|
PX4_DEBUG("stopping: %s, last active WorkItem closing", _config.name);
|
|
|
|
// Deletion of this work queue might happen right after request_stop or
|
|
// SignalWorkerThread. Use a separate lock to prevent premature deletion
|
|
px4_sem_wait(&_exit_lock);
|
|
exiting = true;
|
|
request_stop();
|
|
SignalWorkerThread();
|
|
}
|
|
|
|
work_unlock();
|
|
|
|
// In case someone is deleting this wq already, signal
|
|
// that it is now allowed
|
|
if (exiting) {
|
|
px4_sem_post(&_exit_lock);
|
|
}
|
|
}
|
|
|
|
void WorkQueue::Add(WorkItem *item)
|
|
{
|
|
work_lock();
|
|
|
|
#if defined(ENABLE_LOCKSTEP_SCHEDULER)
|
|
|
|
if (_lockstep_component == -1) {
|
|
_lockstep_component = px4_lockstep_register_component();
|
|
}
|
|
|
|
#endif // ENABLE_LOCKSTEP_SCHEDULER
|
|
|
|
_q.push(item);
|
|
work_unlock();
|
|
|
|
SignalWorkerThread();
|
|
}
|
|
|
|
void WorkQueue::SignalWorkerThread()
|
|
{
|
|
int sem_val;
|
|
|
|
if (px4_sem_getvalue(&_process_lock, &sem_val) == 0 && sem_val <= 0) {
|
|
px4_sem_post(&_process_lock);
|
|
}
|
|
}
|
|
|
|
void WorkQueue::Remove(WorkItem *item)
|
|
{
|
|
work_lock();
|
|
_q.remove(item);
|
|
work_unlock();
|
|
}
|
|
|
|
void WorkQueue::Clear()
|
|
{
|
|
work_lock();
|
|
|
|
while (!_q.empty()) {
|
|
_q.pop();
|
|
}
|
|
|
|
work_unlock();
|
|
}
|
|
|
|
void WorkQueue::Run()
|
|
{
|
|
while (!should_exit()) {
|
|
// loop as the wait may be interrupted by a signal
|
|
do {} while (px4_sem_wait(&_process_lock) != 0);
|
|
|
|
work_lock();
|
|
|
|
// process queued work
|
|
while (!_q.empty()) {
|
|
WorkItem *work = _q.pop();
|
|
|
|
work_unlock(); // unlock work queue to run (item may requeue itself)
|
|
work->RunPreamble();
|
|
work->Run();
|
|
// Note: after Run() we cannot access work anymore, as it might have been deleted
|
|
work_lock(); // re-lock
|
|
}
|
|
|
|
#if defined(ENABLE_LOCKSTEP_SCHEDULER)
|
|
|
|
if (_q.empty()) {
|
|
px4_lockstep_unregister_component(_lockstep_component);
|
|
_lockstep_component = -1;
|
|
}
|
|
|
|
#endif // ENABLE_LOCKSTEP_SCHEDULER
|
|
|
|
work_unlock();
|
|
}
|
|
|
|
PX4_DEBUG("%s: exiting", _config.name);
|
|
}
|
|
|
|
void WorkQueue::print_status(bool last)
|
|
{
|
|
const size_t num_items = _work_items.size();
|
|
PX4_INFO_RAW("%-16s\n", get_name());
|
|
unsigned i = 0;
|
|
|
|
for (WorkItem *item : _work_items) {
|
|
i++;
|
|
|
|
if (last) {
|
|
PX4_INFO_RAW(" ");
|
|
|
|
} else {
|
|
PX4_INFO_RAW("| ");
|
|
}
|
|
|
|
if (i < num_items) {
|
|
PX4_INFO_RAW("|__%2d) ", i);
|
|
|
|
} else {
|
|
PX4_INFO_RAW("\\__%2d) ", i);
|
|
}
|
|
|
|
item->print_run_status();
|
|
}
|
|
}
|
|
|
|
} // namespace px4
|