mirror of
https://gitee.com/mirrors_PX4/PX4-Autopilot.git
synced 2026-04-14 10:07:39 +08:00
Adds a stand-alone workflow that posts or updates sticky PR comments on behalf of any analysis workflow, including those triggered by fork PRs. The poster runs on `workflow_run` in the base repo context, which is the standard GitHub-sanctioned way to get a write token on events that originate from untrusted forks without ever checking out fork code. All validation, GitHub API interaction, and upsert logic lives in Tools/ci/pr-comment-poster.py (Python 3 stdlib only, two subcommands: `validate` and `post`). The workflow file itself is a thin orchestrator: sparse-checkout the script, download the pr-comment artifact via github-script, unzip, then invoke the script twice. No inline jq, no inline bash validation, no shell-interpolated marker strings. The sparse-checkout ensures only Tools/ci/pr-comment-poster.py lands in the workspace, never the rest of the repo. Artifact contract: a producer uploads an artifact named exactly `pr-comment` containing `manifest.json` (with `pr_number`, `marker`, and optional `mode`) and `body.md`. The script validates the manifest (positive integer pr_number, printable-ASCII marker bounded 1..200 chars, UTF-8 body under 60000 bytes, mode in an allowlist), finds any existing comment containing the marker via the comments REST API, and either edits it in place or creates a new one. The workflow file header documents six security invariants that any future change MUST preserve, most importantly: NEVER check out PR code, NEVER execute anything from the artifact, and treat all artifact contents as opaque data. Why a generic poster and not `pull_request_target`: `pull_request_target` is the tool people reach for first and the one that most often turns into a supply-chain vulnerability, because it hands a write token to a workflow that is then tempted to check out the PR head. `workflow_run` gives the same write token without any check-out temptation, because the only input is a pre-produced artifact treated as opaque data. Producer migrations =================== flash_analysis.yml: - Drop the fork gate on the `post_pr_comment` job. - Drop the obsolete TODO pointing at issue #24408 (the fork-comment workflow does not error anymore; it just no-ops). - Keep the existing "comment only if threshold crossed or previous comment exists" behaviour verbatim. peter-evans/find-comment@v3 stays as a read-only probe (forks can read issue comments just fine); its body-includes is updated to search for the new marker `<!-- pr-comment-poster:flash-analysis -->` instead of the old "FLASH Analysis" heading substring. - Replace the peter-evans/create-or-update-comment@v4 step with two new steps that write pr-comment/manifest.json and pr-comment/body.md and then upload them as artifact pr-comment. The body markdown is byte-for-byte identical to the previous heredoc, with the marker prepended as the first line so subsequent runs can find it. - The threshold-or-existing-comment gate is preserved on both new steps. When the gate does not fire no artifact is uploaded and the poster no-ops. docs-orchestrator.yml (link-check job): - Drop the fork gate on the sticky-comment step. - Replace marocchino/sticky-pull-request-comment@v2 with two new steps that copy logs/filtered-link-check-results.md into pr-comment/body.md, write a pr-comment/manifest.json with the marker `<!-- pr-comment-poster:docs-link-check -->`, and upload the directory as artifact pr-comment. - The prepare step checks `test -s` on the results file and emits a prepared step output; the upload step is gated on that output. In practice the existing link-check step always writes a placeholder ("No broken links found in changed files.") into the file when empty, so the guard is defensive but not load-bearing today. - Tighten the link-check job's permissions from `pull-requests: write` down to `contents: read`; writing PR comments now happens in the poster workflow. The poster's workflows allowlist is seeded with the two active producers: "FLASH usage analysis" and "Docs - Orchestrator". clang-tidy (workflow name "Static Analysis") is not in the list because platisd/clang-tidy-pr-comments posts line-level review comments, a different REST API from issue comments that the poster script does not handle. Extending the poster to cover review comments is a follow-up. Signed-off-by: Ramon Roche <mrpollo@gmail.com>
436 lines
14 KiB
YAML
436 lines
14 KiB
YAML
# Docs - Orchestrator
|
|
#
|
|
# Trigger paths:
|
|
# push (main, release/**) → metadata-regen → build-site → deploy-aws
|
|
# pull_request → detect-changes → pr-metadata-regen → link-check → build-site (if docs/source changed)
|
|
# workflow_dispatch → metadata-regen → build-site → deploy-aws
|
|
#
|
|
# Container jobs (pr-metadata-regen, metadata-regen) run in px4-dev image and
|
|
# require safe.directory + fetch-depth: 0 for git operations.
|
|
|
|
name: Docs - Orchestrator
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- "main"
|
|
- "release/**"
|
|
paths:
|
|
- "docs/**"
|
|
- "src/**"
|
|
- "msg/**"
|
|
- "ROMFS/**"
|
|
- "Tools/module_config/**"
|
|
- ".github/workflows/docs-orchestrator.yml"
|
|
pull_request:
|
|
paths:
|
|
- "docs/**"
|
|
- ".github/workflows/docs-orchestrator.yml"
|
|
workflow_dispatch:
|
|
|
|
concurrency:
|
|
group: docs-orchestrator-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
# =============================================================================
|
|
# Detect Changes (PR only)
|
|
# =============================================================================
|
|
detect-changes:
|
|
name: "T1: Detect Changes"
|
|
if: github.event_name == 'pull_request'
|
|
permissions:
|
|
contents: read
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
source_changed: ${{ steps.changes.outputs.source }}
|
|
docs_changed: ${{ steps.changes.outputs.docs }}
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: dorny/paths-filter@v3
|
|
id: changes
|
|
with:
|
|
filters: |
|
|
source:
|
|
- 'src/**'
|
|
- 'msg/**'
|
|
- 'ROMFS/**'
|
|
- 'Tools/module_config/**'
|
|
docs:
|
|
- 'docs/**'
|
|
|
|
# =============================================================================
|
|
# PR Metadata Regen (conditional - only when PR touches source files)
|
|
# =============================================================================
|
|
pr-metadata-regen:
|
|
name: "T2: PR Metadata"
|
|
needs: [detect-changes]
|
|
if: github.event_name == 'pull_request' && needs.detect-changes.outputs.source_changed == 'true'
|
|
permissions:
|
|
contents: read
|
|
runs-on: [runs-on,runner=4cpu-linux-x64,image=ubuntu24-full-x64,"run-id=${{ github.run_id }}",spot=false,extras=s3-cache]
|
|
container:
|
|
image: ghcr.io/px4/px4-dev:v1.17.0-rc2
|
|
steps:
|
|
- uses: runs-on/action@v1
|
|
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
submodules: recursive
|
|
|
|
- name: Git ownership workaround
|
|
run: git config --system --add safe.directory '*'
|
|
|
|
- name: Cache Restore - ccache
|
|
id: cache-ccache
|
|
uses: actions/cache/restore@v4
|
|
with:
|
|
path: ~/.ccache
|
|
key: ccache-docs-metadata-${{ github.sha }}
|
|
restore-keys: |
|
|
ccache-docs-metadata-
|
|
|
|
- name: Setup ccache
|
|
run: |
|
|
mkdir -p ~/.ccache
|
|
echo "max_size = 1G" > ~/.ccache/ccache.conf
|
|
|
|
- name: Build px4_sitl_default
|
|
run: |
|
|
make px4_sitl_default
|
|
env:
|
|
CCACHE_DIR: ~/.ccache
|
|
|
|
- name: Cache Save - ccache
|
|
uses: actions/cache/save@v4
|
|
if: always()
|
|
with:
|
|
path: ~/.ccache
|
|
key: ccache-docs-metadata-${{ github.sha }}
|
|
|
|
- name: Generate and sync metadata
|
|
run: Tools/ci/metadata_sync.sh --generate --sync parameters airframes modules msg_docs failsafe_web
|
|
env:
|
|
CCACHE_DIR: ~/.ccache
|
|
|
|
- name: Upload metadata artifact
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: pr-metadata
|
|
path: docs/
|
|
retention-days: 1
|
|
|
|
# =============================================================================
|
|
# Push Metadata Regen (main/release branches)
|
|
# =============================================================================
|
|
metadata-regen:
|
|
name: "T2: Metadata Sync"
|
|
if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
|
|
permissions:
|
|
contents: write
|
|
runs-on: [runs-on,runner=4cpu-linux-x64,image=ubuntu24-full-x64,"run-id=${{ github.run_id }}",spot=false,extras=s3-cache]
|
|
container:
|
|
image: ghcr.io/px4/px4-dev:v1.17.0-rc2
|
|
steps:
|
|
- uses: runs-on/action@v1
|
|
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
submodules: recursive
|
|
token: ${{ secrets.PX4BUILTBOT_PERSONAL_ACCESS_TOKEN }}
|
|
|
|
- name: Git ownership workaround
|
|
run: git config --system --add safe.directory '*'
|
|
|
|
- name: Cache Restore - ccache
|
|
id: cache-ccache
|
|
uses: actions/cache/restore@v4
|
|
with:
|
|
path: ~/.ccache
|
|
key: ccache-docs-metadata-${{ github.sha }}
|
|
restore-keys: |
|
|
ccache-docs-metadata-
|
|
|
|
- name: Setup ccache
|
|
run: |
|
|
mkdir -p ~/.ccache
|
|
echo "max_size = 1G" > ~/.ccache/ccache.conf
|
|
|
|
- name: Build px4_sitl_default
|
|
run: |
|
|
make px4_sitl_default
|
|
env:
|
|
CCACHE_DIR: ~/.ccache
|
|
|
|
- name: Cache Save - ccache
|
|
uses: actions/cache/save@v4
|
|
if: always()
|
|
with:
|
|
path: ~/.ccache
|
|
key: ccache-docs-metadata-${{ github.sha }}
|
|
|
|
- name: Generate and sync metadata
|
|
run: Tools/ci/metadata_sync.sh --generate --sync parameters airframes modules msg_docs failsafe_web
|
|
env:
|
|
CCACHE_DIR: ~/.ccache
|
|
|
|
- name: Install Node.js and Yarn
|
|
run: |
|
|
curl -fsSL https://deb.nodesource.com/setup_20.x | bash -
|
|
apt-get install -y nodejs
|
|
corepack enable
|
|
|
|
- name: Format markdown with Prettier
|
|
run: |
|
|
cd docs
|
|
yarn install --frozen-lockfile
|
|
yarn prettier --write "en/**/*.md"
|
|
|
|
- name: Commit and push changes
|
|
run: |
|
|
git config --global user.name "${{ secrets.PX4BUILDBOT_USER }}"
|
|
git config --global user.email "${{ secrets.PX4BUILDBOT_EMAIL }}"
|
|
git add docs/
|
|
if git diff --staged --quiet; then
|
|
echo "No changes to commit"
|
|
else
|
|
git commit -m "docs: auto-sync metadata [skip ci]
|
|
|
|
Co-Authored-By: PX4 BuildBot <${{ secrets.PX4BUILDBOT_EMAIL }}>"
|
|
git push
|
|
fi
|
|
|
|
# =============================================================================
|
|
# Link Check
|
|
# =============================================================================
|
|
link-check:
|
|
name: "T2: Link Check"
|
|
needs: [detect-changes, pr-metadata-regen]
|
|
if: always() && (github.event_name == 'pull_request')
|
|
permissions:
|
|
contents: read
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
fetch-depth: 0
|
|
|
|
- name: Download metadata artifact
|
|
if: needs.pr-metadata-regen.result == 'success'
|
|
uses: actions/download-artifact@v4
|
|
with:
|
|
name: pr-metadata
|
|
path: docs/
|
|
|
|
- name: Get changed doc files
|
|
id: changed-files
|
|
uses: tj-actions/changed-files@v46.0.5
|
|
with:
|
|
json: true
|
|
write_output_files: true
|
|
output_dir: ./logs
|
|
base_sha: ${{ github.event.pull_request.base.sha }}
|
|
sha: ${{ github.event.pull_request.head.sha }}
|
|
files: |
|
|
docs/en/**/*.md
|
|
|
|
- name: Save changed files list
|
|
run: |
|
|
mv ./logs/all_changed_files.json ./logs/prFiles.json
|
|
echo "Changed files:"
|
|
cat ./logs/prFiles.json
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 20
|
|
|
|
- name: Run filtered link checker (changed files)
|
|
run: |
|
|
npm -g install markdown_link_checker_sc@0.0.138
|
|
if [ "$(jq length ./logs/prFiles.json)" -gt 0 ]; then
|
|
markdown_link_checker_sc \
|
|
-r "$GITHUB_WORKSPACE" \
|
|
-d docs \
|
|
-e en \
|
|
-f ./logs/prFiles.json \
|
|
-i assets \
|
|
-u docs.px4.io/main/ \
|
|
> ./logs/filtered-link-check-results.md || true
|
|
fi
|
|
if [ ! -s ./logs/filtered-link-check-results.md ]; then
|
|
echo "No broken links found in changed files." > ./logs/filtered-link-check-results.md
|
|
fi
|
|
cat ./logs/filtered-link-check-results.md
|
|
|
|
- name: Run full link checker
|
|
run: |
|
|
markdown_link_checker_sc \
|
|
-r "$GITHUB_WORKSPACE" \
|
|
-d docs \
|
|
-e en \
|
|
-i assets \
|
|
-u docs.px4.io/main/ \
|
|
> ./logs/link-check-results.md || true
|
|
cat ./logs/link-check-results.md
|
|
|
|
- name: Prepare pr-comment artifact
|
|
id: prepare-pr-comment
|
|
run: |
|
|
if [ ! -s ./logs/filtered-link-check-results.md ]; then
|
|
echo "No link-check results file; skipping pr-comment artifact."
|
|
echo "prepared=false" >> "$GITHUB_OUTPUT"
|
|
exit 0
|
|
fi
|
|
mkdir -p pr-comment
|
|
cp ./logs/filtered-link-check-results.md pr-comment/body.md
|
|
cat > pr-comment/manifest.json <<EOF
|
|
{
|
|
"pr_number": ${{ github.event.pull_request.number }},
|
|
"marker": "<!-- pr-comment-poster:docs-link-check -->",
|
|
"mode": "upsert"
|
|
}
|
|
EOF
|
|
echo "prepared=true" >> "$GITHUB_OUTPUT"
|
|
|
|
- name: Upload pr-comment artifact
|
|
if: steps.prepare-pr-comment.outputs.prepared == 'true'
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: pr-comment
|
|
path: pr-comment/
|
|
retention-days: 1
|
|
|
|
- name: Upload link check results
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: link-check-results
|
|
path: logs/
|
|
retention-days: 7
|
|
|
|
# =============================================================================
|
|
# Build Site
|
|
# =============================================================================
|
|
build-site:
|
|
name: "T3: Build Site"
|
|
needs: [detect-changes, pr-metadata-regen, metadata-regen, link-check]
|
|
if: >-
|
|
always() &&
|
|
(needs.metadata-regen.result == 'success' || needs.metadata-regen.result == 'skipped') &&
|
|
(needs.link-check.result == 'success' || needs.link-check.result == 'skipped') &&
|
|
(github.event_name != 'pull_request' || needs.detect-changes.outputs.docs_changed == 'true' || needs.detect-changes.outputs.source_changed == 'true')
|
|
permissions:
|
|
contents: read
|
|
runs-on: [runs-on,runner=4cpu-linux-x64,image=ubuntu24-full-x64,"run-id=${{ github.run_id }}",spot=false,extras=s3-cache]
|
|
outputs:
|
|
branchname: ${{ steps.set-branch.outputs.branchname }}
|
|
releaseversion: ${{ steps.set-version.outputs.releaseversion }}
|
|
steps:
|
|
- uses: runs-on/action@v1
|
|
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
|
|
|
|
- name: Download metadata artifact (PR)
|
|
if: github.event_name == 'pull_request' && needs.pr-metadata-regen.result == 'success'
|
|
uses: actions/download-artifact@v4
|
|
with:
|
|
name: pr-metadata
|
|
path: docs/
|
|
|
|
- id: set-branch
|
|
run: echo "branchname=${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" >> $GITHUB_OUTPUT
|
|
|
|
- id: set-version
|
|
run: |
|
|
branch="${{ steps.set-branch.outputs.branchname }}"
|
|
if [[ "$branch" == "main" ]]; then
|
|
version="main"
|
|
elif [[ "$branch" =~ ^release/ ]]; then
|
|
version="v${branch#release/}"
|
|
elif [[ "${{ github.event_name }}" == "pull_request" ]]; then
|
|
version="main"
|
|
else
|
|
echo "::error::Unsupported branch for docs deploy: $branch (expected main or release/*)"
|
|
exit 1
|
|
fi
|
|
echo "releaseversion=$version" >> $GITHUB_OUTPUT
|
|
|
|
- name: Setup Node
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 20
|
|
cache: npm
|
|
cache-dependency-path: ./docs/yarn.lock
|
|
|
|
- name: Install dependencies
|
|
run: yarn install --frozen-lockfile --cwd ./docs
|
|
|
|
- name: Build with VitePress
|
|
working-directory: ./docs
|
|
env:
|
|
BRANCH_NAME: ${{ steps.set-version.outputs.releaseversion }}
|
|
run: |
|
|
npm run docs:build_ubuntu
|
|
touch .vitepress/dist/.nojekyll
|
|
npm run docs:sitemap
|
|
|
|
- name: Upload artifact
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: px4_docs_build
|
|
path: docs/.vitepress/dist/
|
|
retention-days: 1
|
|
|
|
# =============================================================================
|
|
# Deploy to AWS (push + workflow_dispatch)
|
|
# =============================================================================
|
|
deploy-aws:
|
|
name: "T4: Deploy"
|
|
needs: [metadata-regen, build-site]
|
|
if: >-
|
|
always() &&
|
|
needs.metadata-regen.result == 'success' &&
|
|
needs.build-site.result == 'success' &&
|
|
(github.event_name == 'push' || github.event_name == 'workflow_dispatch')
|
|
permissions:
|
|
id-token: write
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Download Artifact
|
|
uses: actions/download-artifact@v4
|
|
with:
|
|
name: px4_docs_build
|
|
path: ~/_book
|
|
|
|
- name: Configure AWS from OIDC
|
|
uses: aws-actions/configure-aws-credentials@v4
|
|
with:
|
|
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
|
|
aws-region: us-west-2
|
|
|
|
- name: Sanity check AWS credentials
|
|
run: aws sts get-caller-identity
|
|
|
|
- name: Upload HTML with short cache
|
|
run: |
|
|
aws s3 sync ~/_book/ s3://px4-docs/${{ needs.build-site.outputs.releaseversion }}/ \
|
|
--delete \
|
|
--exclude "*" --include "*.html" \
|
|
--cache-control "public, max-age=60"
|
|
|
|
- name: Upload assets with long cache
|
|
run: |
|
|
aws s3 sync ~/_book/ s3://px4-docs/${{ needs.build-site.outputs.releaseversion }}/ \
|
|
--delete \
|
|
--exclude "*.html" \
|
|
--cache-control "public, max-age=86400, immutable"
|