From f42a626527834cc9533ee80756a96fb34b5a0bf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beat=20K=C3=BCng?= Date: Mon, 24 Apr 2017 16:09:04 +0200 Subject: [PATCH] vmount: fix null-pointer access if invalid output mode was selected In case of an invalid output mode, thread_data.output_obj was null. --- src/drivers/vmount/vmount.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/drivers/vmount/vmount.cpp b/src/drivers/vmount/vmount.cpp index 6b29870ae6..574476ae86 100644 --- a/src/drivers/vmount/vmount.cpp +++ b/src/drivers/vmount/vmount.cpp @@ -272,6 +272,7 @@ static int vmount_thread_main(int argc, char *argv[]) default: PX4_ERR("invalid output mode %i", params.mnt_mode_out); + thread_should_exit = true; break; } @@ -279,6 +280,9 @@ static int vmount_thread_main(int argc, char *argv[]) thread_data.input_objs_len = 0; PX4_ERR("memory allocation failed"); thread_should_exit = true; + } + + if (thread_should_exit) { break; }