From a645a388bcb8c598f59d11c4b4a68265f64cb022 Mon Sep 17 00:00:00 2001 From: px4dev Date: Sat, 9 Feb 2013 00:53:51 -0800 Subject: [PATCH 1/3] Fix a sign error --- apps/px4io/registers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/px4io/registers.c b/apps/px4io/registers.c index c60491f93c..3824c64b06 100644 --- a/apps/px4io/registers.c +++ b/apps/px4io/registers.c @@ -370,7 +370,7 @@ registers_set_one(uint8_t page, uint8_t offset, uint16_t value) /* assert min..center..max ordering */ if (conf[PX4IO_P_RC_CONFIG_MIN] < 500) break; - if (conf[PX4IO_P_RC_CONFIG_MAX] < 2500) + if (conf[PX4IO_P_RC_CONFIG_MAX] > 2500) break; if (conf[PX4IO_P_RC_CONFIG_CENTER] < conf[PX4IO_P_RC_CONFIG_MIN]) break; From 3c8da27d72e81da923106dcc667a5e644de90b86 Mon Sep 17 00:00:00 2001 From: px4dev Date: Sat, 9 Feb 2013 00:57:23 -0800 Subject: [PATCH 2/3] Fix a misleading comment. --- apps/px4io/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/px4io/i2c.c b/apps/px4io/i2c.c index 2b8c502c7c..93dfd21dd1 100644 --- a/apps/px4io/i2c.c +++ b/apps/px4io/i2c.c @@ -174,7 +174,7 @@ i2c_interrupt(int irq, FAR void *context) i2c_rx_complete(); break; default: - /* spurious stop, ignore */ + /* not currently transferring - must be a new txn */ break; } direction = DIR_NONE; From aa16a63a10bb43d8614f01915cdf33996fe0d0e4 Mon Sep 17 00:00:00 2001 From: px4dev Date: Mon, 11 Feb 2013 20:40:06 -0800 Subject: [PATCH 3/3] Fix assignment of relay GPIOs. --- apps/drivers/boards/px4io/px4io_internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/drivers/boards/px4io/px4io_internal.h b/apps/drivers/boards/px4io/px4io_internal.h index f77d237a77..44bb98513b 100644 --- a/apps/drivers/boards/px4io/px4io_internal.h +++ b/apps/drivers/boards/px4io/px4io_internal.h @@ -74,8 +74,8 @@ #define GPIO_ACC_OC_DETECT (GPIO_INPUT|GPIO_CNF_INPULLUP|GPIO_MODE_INPUT|GPIO_PORTB|GPIO_PIN12) #define GPIO_SERVO_OC_DETECT (GPIO_INPUT|GPIO_CNF_INPULLUP|GPIO_MODE_INPUT|GPIO_PORTB|GPIO_PIN13) -#define GPIO_RELAY1_EN (GPIO_OUTPUT|GPIO_CNF_OUTPP|GPIO_MODE_50MHz|GPIO_OUTPUT_CLEAR|GPIO_PORTA|GPIO_PIN13) -#define GPIO_RELAY2_EN (GPIO_OUTPUT|GPIO_CNF_OUTPP|GPIO_MODE_50MHz|GPIO_OUTPUT_CLEAR|GPIO_PORTA|GPIO_PIN12) +#define GPIO_RELAY1_EN (GPIO_OUTPUT|GPIO_CNF_OUTPP|GPIO_MODE_50MHz|GPIO_OUTPUT_CLEAR|GPIO_PORTA|GPIO_PIN12) +#define GPIO_RELAY2_EN (GPIO_OUTPUT|GPIO_CNF_OUTPP|GPIO_MODE_50MHz|GPIO_OUTPUT_CLEAR|GPIO_PORTA|GPIO_PIN11) /* Analog inputs ********************************************************************/