From eebacc4f7b1ccdfc02bc8d4aeae68ecfcecd57e1 Mon Sep 17 00:00:00 2001 From: Phil-Engljaehringer Date: Thu, 30 Oct 2025 16:28:42 +0100 Subject: [PATCH] removed last useless comments --- .../src/px4/common/gpio/mcp23017/mcp23017.cpp | 8 +++--- src/drivers/gpio/mcp23017/mcp23017.cpp | 26 +++++++++---------- src/drivers/gpio/mcp23017/mcp23017_main.cpp | 1 + 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/platforms/nuttx/src/px4/common/gpio/mcp23017/mcp23017.cpp b/platforms/nuttx/src/px4/common/gpio/mcp23017/mcp23017.cpp index 52d2f80587..8573b5c75b 100644 --- a/platforms/nuttx/src/px4/common/gpio/mcp23017/mcp23017.cpp +++ b/platforms/nuttx/src/px4/common/gpio/mcp23017/mcp23017.cpp @@ -133,11 +133,13 @@ static mcp23017_gpio_dev_s _gpio[NUM_GPIOS]; // ---------------------------------------------------------------------------- int mcp23017_register_gpios(uint8_t i2c_bus, uint8_t i2c_addr, int first_minor, uint16_t dir_mask) { - for(int i=0; i> 8); - _olatB = (uint8_t) (state >> 8); - _gppuB = (uint8_t) (pull_up >> 8); + _iodirB = (uint8_t)(direction >> 8); + _olatB = (uint8_t)(state >> 8); + _gppuB = (uint8_t)(pull_up >> 8); // Write the initial state to the device ret = write_reg(Register::OLATA, _olatA); @@ -87,7 +87,7 @@ int MCP23017::init(uint16_t direction, uint16_t state, uint16_t pull_up, uint16_ ret |= write_reg(Register::INTCONA, 0xFF); ret |= write_reg(Register::INTCONB, 0xFF); - if(!split_int){ + if (!split_int) { ret |= write_reg(Register::IOCONA, 0x40); } @@ -122,11 +122,11 @@ int MCP23017::read(uint16_t *mask) int MCP23017::write(uint16_t mask_set, uint16_t mask_clear) { // no need to read, we can use the buffered register value - uint8_t mask_setA = (uint8_t) (mask_set & 0x00FF); - uint8_t mask_clearA = (uint8_t) (mask_clear & 0x00FF); + uint8_t mask_setA = (uint8_t)(mask_set & 0x00FF); + uint8_t mask_clearA = (uint8_t)(mask_clear & 0x00FF); - uint8_t mask_setB = (uint8_t) (mask_set >> 8); - uint8_t mask_clearB = (uint8_t) (mask_clear >> 8); + uint8_t mask_setB = (uint8_t)(mask_set >> 8); + uint8_t mask_clearB = (uint8_t)(mask_clear >> 8); _olatA = (_olatA & ~mask_clearA) | mask_setA; _olatB = (_olatB & ~mask_clearB) | mask_setB; @@ -139,8 +139,8 @@ int MCP23017::write(uint16_t mask_set, uint16_t mask_clear) int MCP23017::configure(uint16_t mask, PinType type) { - uint8_t maskA = (uint8_t) (mask & 0x00FF); - uint8_t maskB = (uint8_t) (mask >> 8); + uint8_t maskA = (uint8_t)(mask & 0x00FF); + uint8_t maskB = (uint8_t)(mask >> 8); // no need to read, we can use the buffered register values switch (type) { diff --git a/src/drivers/gpio/mcp23017/mcp23017_main.cpp b/src/drivers/gpio/mcp23017/mcp23017_main.cpp index 03ebb38f6a..68552cc662 100644 --- a/src/drivers/gpio/mcp23017/mcp23017_main.cpp +++ b/src/drivers/gpio/mcp23017/mcp23017_main.cpp @@ -193,6 +193,7 @@ extern "C" int mcp23017_main(int argc, char *argv[]) case 'U': config_data.interval = atoi(cli.optArg()); break; + case 'R': config_data.int_en = (int)strtol(cli.optArg(), nullptr, 0); break;