From ea5fcebddb5b370078389e430eb94a28438f08d1 Mon Sep 17 00:00:00 2001 From: Jacob Dahl Date: Tue, 17 Mar 2026 21:55:33 -0800 Subject: [PATCH] refactor(lib/led): convert params.c to module.yaml Convert 1 parameter file(s) from legacy C format to YAML module configuration. --- src/lib/led/CMakeLists.txt | 1 + src/lib/led/led_params.c | 42 ------------------------------------- src/lib/led/led_params.yaml | 11 ++++++++++ 3 files changed, 12 insertions(+), 42 deletions(-) delete mode 100644 src/lib/led/led_params.c create mode 100644 src/lib/led/led_params.yaml diff --git a/src/lib/led/CMakeLists.txt b/src/lib/led/CMakeLists.txt index 82e33bc292..4ec9d49a48 100644 --- a/src/lib/led/CMakeLists.txt +++ b/src/lib/led/CMakeLists.txt @@ -32,6 +32,7 @@ ############################################################################ px4_add_library(led led.cpp) +set_property(GLOBAL APPEND PROPERTY PX4_MODULE_CONFIG_FILES ${CMAKE_CURRENT_SOURCE_DIR}/led_params.yaml) target_compile_options(led PRIVATE -Wno-implicit-fallthrough # TODO: fix and remove ) diff --git a/src/lib/led/led_params.c b/src/lib/led/led_params.c deleted file mode 100644 index 1120fb9ca7..0000000000 --- a/src/lib/led/led_params.c +++ /dev/null @@ -1,42 +0,0 @@ -/**************************************************************************** - * - * Copyright (c) 2015-2021 PX4 Development Team. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in - * the documentation and/or other materials provided with the - * distribution. - * 3. Neither the name PX4 nor the names of its contributors may be - * used to endorse or promote products derived from this software - * without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS - * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE - * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, - * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS - * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED - * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN - * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE - * POSSIBILITY OF SUCH DAMAGE. - * - ****************************************************************************/ - -/** - * RGB Led brightness limit - * - * Set to 0 to disable, 1 for maximum brightness - * - * @unit % - * @group System - */ -PARAM_DEFINE_FLOAT(SYS_RGB_MAXBRT, 1.f); diff --git a/src/lib/led/led_params.yaml b/src/lib/led/led_params.yaml new file mode 100644 index 0000000000..4dc102bdb8 --- /dev/null +++ b/src/lib/led/led_params.yaml @@ -0,0 +1,11 @@ +module_name: led +parameters: +- group: System + definitions: + SYS_RGB_MAXBRT: + description: + short: RGB Led brightness limit + long: Set to 0 to disable, 1 for maximum brightness + type: float + default: 1.0 + unit: '%'