From d5942bd631c2b1cd524670af30a4ef7feef1c2ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Beat=20K=C3=BCng?= <beat-kueng@gmx.net>
Date: Thu, 19 Jun 2025 13:19:54 +0200
Subject: [PATCH] septentrio: fix clang-tidy warnings

---
 src/drivers/gnss/septentrio/rtcm.cpp       |  5 +---
 src/drivers/gnss/septentrio/septentrio.cpp | 29 ++++++----------------
 2 files changed, 8 insertions(+), 26 deletions(-)

diff --git a/src/drivers/gnss/septentrio/rtcm.cpp b/src/drivers/gnss/septentrio/rtcm.cpp
index 007b2a168e..a39437af8c 100644
--- a/src/drivers/gnss/septentrio/rtcm.cpp
+++ b/src/drivers/gnss/septentrio/rtcm.cpp
@@ -123,10 +123,7 @@ Decoder::State Decoder::add_byte(uint8_t byte)
 
 void Decoder::reset()
 {
-	if (_message) {
-		delete[] _message;
-	}
-
+	delete[] _message;
 	_message = new uint8_t[INITIAL_BUFFER_LENGTH];
 	_current_index = 0;
 	_message_length = 0;
diff --git a/src/drivers/gnss/septentrio/septentrio.cpp b/src/drivers/gnss/septentrio/septentrio.cpp
index aaeadaced2..5fca971fb5 100644
--- a/src/drivers/gnss/septentrio/septentrio.cpp
+++ b/src/drivers/gnss/septentrio/septentrio.cpp
@@ -221,21 +221,10 @@ SeptentrioDriver::~SeptentrioDriver()
 		}
 	}
 
-	if (_message_data_from_receiver) {
-		delete _message_data_from_receiver;
-	}
-
-	if (_message_data_to_receiver) {
-		delete _message_data_to_receiver;
-	}
-
-	if (_message_satellite_info) {
-		delete _message_satellite_info;
-	}
-
-	if (_rtcm_decoder) {
-		delete _rtcm_decoder;
-	}
+	delete _message_data_from_receiver;
+	delete _message_data_to_receiver;
+	delete _message_satellite_info;
+	delete _rtcm_decoder;
 }
 
 int SeptentrioDriver::print_status()
@@ -1622,12 +1611,12 @@ void SeptentrioDriver::dump_gps_data(const uint8_t *data, size_t len, DataDirect
 
 bool SeptentrioDriver::should_dump_incoming() const
 {
-	return _message_data_from_receiver != 0;
+	return _message_data_from_receiver != nullptr;
 }
 
 bool SeptentrioDriver::should_dump_outgoing() const
 {
-	return _message_data_to_receiver != 0;
+	return _message_data_to_receiver != nullptr;
 }
 
 void SeptentrioDriver::start_update_monitoring_interval()
@@ -1702,11 +1691,7 @@ void SeptentrioDriver::set_clock(timespec rtc_gps_time)
 
 bool SeptentrioDriver::is_healthy() const
 {
-	if (_state == State::ReceivingData && receiver_configuration_healthy()) {
-		return true;
-	}
-
-	return false;
+	return _state == State::ReceivingData && receiver_configuration_healthy();
 }
 
 void SeptentrioDriver::reset_gps_state_message()