From d22bbde7c5bc838c7cee6dcf97847a5ad196ae78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beat=20K=C3=BCng?= Date: Mon, 29 Jun 2020 10:20:07 +0200 Subject: [PATCH] logger: fix hardfault for invalid SDLOG_PROFILE setting If some bits are set but no topic was added, _subscriptions was null but later accessed. During normal use this only happens when switching between different firmware versions with different SDLOG_PROFILE definition (with custom config). --- src/modules/logger/logged_topics.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/logger/logged_topics.cpp b/src/modules/logger/logged_topics.cpp index 1cb908b2ba..a760c7beab 100644 --- a/src/modules/logger/logged_topics.cpp +++ b/src/modules/logger/logged_topics.cpp @@ -373,7 +373,7 @@ bool LoggedTopics::initialize_logged_topics(SDLogProfileMask profile) initialize_configured_topics(profile); } - return true; + return _subscriptions.count > 0; } void LoggedTopics::initialize_configured_topics(SDLogProfileMask profile)