From d1e0cbe325f9a24154e5f754b4c5f5e78ef9282d Mon Sep 17 00:00:00 2001 From: MaEtUgR Date: Thu, 10 Mar 2016 13:30:35 +0100 Subject: [PATCH] fixing all "argc < 1" to avoid segmentation fault when calling the module with no parameters argc is never smaller than one because the first element of the array is the program name! --- src/modules/attitude_estimator_q/attitude_estimator_q_main.cpp | 2 +- src/modules/ekf2/ekf2_main.cpp | 2 +- .../local_position_estimator/local_position_estimator_main.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/attitude_estimator_q/attitude_estimator_q_main.cpp b/src/modules/attitude_estimator_q/attitude_estimator_q_main.cpp index 398d14b85f..8bcea6b8d6 100644 --- a/src/modules/attitude_estimator_q/attitude_estimator_q_main.cpp +++ b/src/modules/attitude_estimator_q/attitude_estimator_q_main.cpp @@ -842,7 +842,7 @@ void AttitudeEstimatorQ::update_mag_declination(float new_declination) int attitude_estimator_q_main(int argc, char *argv[]) { - if (argc < 1) { + if (argc < 2) { warnx("usage: attitude_estimator_q {start|stop|status}"); return 1; } diff --git a/src/modules/ekf2/ekf2_main.cpp b/src/modules/ekf2/ekf2_main.cpp index e64d9e7e9e..e9dd533644 100644 --- a/src/modules/ekf2/ekf2_main.cpp +++ b/src/modules/ekf2/ekf2_main.cpp @@ -751,7 +751,7 @@ int Ekf2::start() int ekf2_main(int argc, char *argv[]) { - if (argc < 1) { + if (argc < 2) { PX4_WARN("usage: ekf2 {start|stop|status}"); return 1; } diff --git a/src/modules/local_position_estimator/local_position_estimator_main.cpp b/src/modules/local_position_estimator/local_position_estimator_main.cpp index 03f7807d9a..87e4f0497e 100644 --- a/src/modules/local_position_estimator/local_position_estimator_main.cpp +++ b/src/modules/local_position_estimator/local_position_estimator_main.cpp @@ -95,7 +95,7 @@ usage(const char *reason) int local_position_estimator_main(int argc, char *argv[]) { - if (argc < 1) { + if (argc < 2) { usage("missing command"); }