fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-05-13 13:37:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

uORB: Remove transfer of memory allocation ownership to CDev

Browse Source 
- Allocate and free the node name in uORBDeviceNode.
- Add protected build support by de-allocating the name with kmm_free, when
  running in kernel side. strdup allocates from the kernel heap in NuttX kernel
  space.
- Remove the CDev::unregister_driver_and_memory(), it is no longer used

Signed-off-by: Jukka Laitinen <jukkax@ssrc.tii.ae>
This commit is contained in:
Jukka Laitinen
2021-12-08 14:50:07 +02:00
committed by Daniel Agar
parent 25c10eb124
commit ce6147f570
4 changed files with 19 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platforms/common/uORB/uORBDeviceMaster.cpp
+2 -10
View File
@@ -99,19 +99,11 @@ int uORB::DeviceMaster::advertise(const struct orb_metadata *meta, bool is_adver
*instance = group_tries;
}
/* driver wants a permanent copy of the path, so make one here */
const char *devpath = strdup(nodepath);
if (devpath == nullptr) {
return -ENOMEM;
}
/* construct the new node, passing the ownership of path to it */
uORB::DeviceNode *node = new uORB::DeviceNode(meta, group_tries, devpath);
uORB::DeviceNode *node = new uORB::DeviceNode(meta, group_tries, nodepath);
/* if we didn't get a device, that's bad, free the path too */
/* if we didn't get a device, that's bad */
if (node == nullptr) {
free((void *)devpath);
return -ENOMEM;
}