fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-10-27 15:43:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Matrix.setCol off by one bug fixed

Browse Source 
The Column Vector you are copying from, only has one Column and it is indexed by 0 not 1.
I also completed the unit test stub that would have found this bug.
This commit is contained in:
MaEtUgR
2016-05-05 13:18:51 +02:00
parent 65679fbcbb
commit b2eb4d13d8
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
matrix/Matrix.hpp
+1 -1
View File
@@ -341,7 +341,7 @@ public:
{ {
Matrix<Type, M, N> &self = *this; Matrix<Type, M, N> &self = *this;
for (size_t i = 0; i < M; i++) { for (size_t i = 0; i < M; i++) {
self(i, j) = col(i, 1); self(i, j) = col(i, 0);
} }
} }
test/matrixAssignment.cpp
+8 -2
View File
@@ -78,8 +78,14 @@ int main()
TEST(fabs(m5(0,0) - s) < 1e-5); TEST(fabs(m5(0,0) - s) < 1e-5);
Matrix<float, 2, 2> m6; Matrix<float, 2, 2> m6;
m6.setRow(0, Vector2f(1, 1)); m6.setRow(0, Vector2f(1, 2));
m6.setCol(0, Vector2f(1, 1)); float m7_array[] = {1,2,0,0};
Matrix<float, 2, 2> m7(m7_array);
TEST(isEqual(m6, m7));
m6.setCol(0, Vector2f(3, 4));
float m8_array[] = {3,2,4,0};
Matrix<float, 2, 2> m8(m8_array);
TEST(isEqual(m6, m8));
return 0; return 0;
} }