fix orbit for mc: handle VEHICLE_CMD_DO_ORBIT command and avoid race condition

Fixes a regression from 8bae4e5c0e, where
the orbit flight task wasn't an extra task (flight_tasks_to_add) anymore
and therefore the command handling wasn't generated.

There was a race condition that could cause several outcomes. The most severe
was that flight_mode_manager gets the command, switches to orbit and then
in the next iteration switches back because commander did not change
nav_state yet. When commander then switches, flight_mode_manager would still
be in the old mode.
This is prevented by storing the command (allowing it to arrive before or
after mode switch), and then apply it after the switch happens.
This commit is contained in:
Beat Küng
2022-11-14 17:31:35 +01:00
committed by Matthias Grob
parent c1f9824396
commit b0e1cc72f7
8 changed files with 60 additions and 64 deletions
@@ -91,9 +91,10 @@ public:
/**
* To be called to adopt parameters from an arrived vehicle command
* @param command received command message containing the parameters
* @return true if accepted, false if declined
* @param success set to true if it was successfully applied, false on error
* @return true if handled
*/
virtual bool applyCommandParameters(const vehicle_command_s &command) { return false; }
virtual bool applyCommandParameters(const vehicle_command_s &command, bool &success) { return false; }
/**
* Call before activate() or update()