Meaningful error codes instead of plain -1

This commit is contained in:
Pavel Kirienko
2014-03-28 19:21:08 +04:00
parent 4886e2194f
commit ae63ad5db5
34 changed files with 112 additions and 73 deletions
+1 -1
View File
@@ -67,7 +67,7 @@ TEST(Node, Basic)
* Init the first node
*/
ASSERT_FALSE(node1.isStarted());
ASSERT_EQ(-1, node1.spin(uavcan::MonotonicDuration::fromMSec(20))); // Not initialized - will fail
ASSERT_EQ(-uavcan::ErrNotInited, node1.spin(uavcan::MonotonicDuration::fromMSec(20)));
ASSERT_LE(0, node1.start(result));
ASSERT_TRUE(node1.isStarted());
+1 -1
View File
@@ -63,7 +63,7 @@ TEST(ServiceClient, Basic)
// Server
uavcan::ServiceServer<root_ns_a::StringService> server(nodes.a);
ASSERT_EQ(1, server.start(stringServiceServerCallback));
ASSERT_EQ(0, server.start(stringServiceServerCallback));
{
// Caller
+5 -5
View File
@@ -82,7 +82,7 @@ TEST(Subscriber, Basic)
sizeof(uavcan::Subscriber<uavcan::mavlink::Message, Listener::ExtendedBinder>) << std::endl;
// Null binder - will fail
ASSERT_EQ(-1, sub_extended.start(Listener::ExtendedBinder(NULL, NULL)));
ASSERT_EQ(-uavcan::ErrInvalidParam, sub_extended.start(Listener::ExtendedBinder(NULL, NULL)));
Listener listener;
@@ -125,10 +125,10 @@ TEST(Subscriber, Basic)
*/
ASSERT_EQ(0, node.getDispatcher().getNumMessageListeners());
ASSERT_EQ(1, sub_extended.start(listener.bindExtended()));
ASSERT_EQ(1, sub_extended2.start(listener.bindExtended()));
ASSERT_EQ(1, sub_simple.start(listener.bindSimple()));
ASSERT_EQ(1, sub_simple2.start(listener.bindSimple()));
ASSERT_EQ(0, sub_extended.start(listener.bindExtended()));
ASSERT_EQ(0, sub_extended2.start(listener.bindExtended()));
ASSERT_EQ(0, sub_simple.start(listener.bindSimple()));
ASSERT_EQ(0, sub_simple2.start(listener.bindSimple()));
ASSERT_EQ(4, node.getDispatcher().getNumMessageListeners());