Sensors: Clean up boot output (#8005)

Various sensors had too verbose or confusing boot output that would make the boot log hard to read. This patch ensures all output is consistently indicating if there is a real error or an optional sensor just not present. It also removed redundant error messages and adds an indication on which bus the sensor was probed.

src/drivers/ms4525_airspeed/ms4525_airspeed.cpp

@@ -382,11 +382,11 @@ namespace meas_airspeed
 
 MEASAirspeed	*g_dev = nullptr;
 
-void	start(int i2c_bus);
-void	stop();
-void	test();
-void	reset();
-void	info();
+int	start(int i2c_bus);
+int	stop();
+int	test();
+int	reset();
+int	info();
 
 /**
  * Start the driver.
@@ -394,13 +394,14 @@ void	info();
  * This function call only returns once the driver is up and running
  * or failed to detect the sensor.
  */
-void
+int
 start(int i2c_bus)
 {
 	int fd;
 
 	if (g_dev != nullptr) {
 		PX4_ERR("already started");
+		return PX4_ERROR;
 	}
 
 	/* create the driver, try the MS4525DO first */
@@ -413,7 +414,6 @@ start(int i2c_bus)
 
 	/* both versions failed if the init for the MS5525DSO fails, give up */
 	if (OK != g_dev->Airspeed::init()) {
-		PX4_ERR("init fail");
 		goto fail;
 	}
 
@@ -428,7 +428,7 @@ start(int i2c_bus)
 		goto fail;
 	}
 
-	return;
+	return PX4_OK;
 
 fail:
 
@@ -437,13 +437,14 @@ fail:
 		g_dev = nullptr;
 	}
 
-	PX4_WARN("no MS4525 airspeed sensor connected");
+	PX4_WARN("no MS4525 airspeed sensor connected on bus %d", i2c_bus);
+	return PX4_ERROR;
 }
 
 /**
  * Stop the driver
  */
-void
+int
 stop()
 {
 	if (g_dev != nullptr) {
@@ -452,7 +453,10 @@ stop()
 
 	} else {
 		PX4_ERR("driver not running");
+		return PX4_ERROR;
 	}
+
+	return PX4_OK;
 }
 
 /**
@@ -460,7 +464,7 @@ stop()
  * make sure we can collect data from the sensor in polled
  * and automatic modes.
  */
-void
+int
 test()
 {
 	struct differential_pressure_s report;
@@ -471,6 +475,7 @@ test()
 
 	if (fd < 0) {
 		PX4_ERR("%s open failed (try 'meas_airspeed start' if the driver is not running", PATH_MS4525);
+		return PX4_ERROR;
 	}
 
 	/* do a simple demand read */
@@ -478,6 +483,7 @@ test()
 
 	if (sz != sizeof(report)) {
 		PX4_ERR("immediate read failed");
+		return PX4_ERROR;
 	}
 
 	PX4_INFO("single read");
@@ -486,6 +492,7 @@ test()
 	/* start the sensor polling at 2Hz */
 	if (OK != px4_ioctl(fd, SENSORIOCSPOLLRATE, 2)) {
 		PX4_ERR("failed to set 2Hz poll rate");
+		return PX4_ERROR;
 	}
 
 	/* read the sensor 5x and report each value */
@@ -506,6 +513,7 @@ test()
 
 		if (sz != sizeof(report)) {
 			PX4_ERR("periodic read failed");
+			return PX4_ERROR;
 		}
 
 		PX4_INFO("periodic read %u", i);
@@ -516,42 +524,53 @@ test()
 	/* reset the sensor polling to its default rate */
 	if (OK != px4_ioctl(fd, SENSORIOCSPOLLRATE, SENSOR_POLLRATE_DEFAULT)) {
 		PX4_ERR("failed to set default rate");
+		return PX4_ERROR;
 	}
+
+	return PX4_OK;
 }
 
 /**
  * Reset the driver.
  */
-void
+int
 reset()
 {
 	int fd = px4_open(PATH_MS4525, O_RDONLY);
 
 	if (fd < 0) {
 		PX4_ERR("failed ");
+		return PX4_ERROR;
 	}
 
 	if (px4_ioctl(fd, SENSORIOCRESET, 0) < 0) {
 		PX4_ERR("driver reset failed");
+		return PX4_ERROR;
 	}
 
 	if (px4_ioctl(fd, SENSORIOCSPOLLRATE, SENSOR_POLLRATE_DEFAULT) < 0) {
 		PX4_ERR("driver poll restart failed");
+		return PX4_ERROR;
 	}
+
+	return PX4_OK;
 }
 
 /**
  * Print a little info about the driver.
  */
-void
+int
 info()
 {
 	if (g_dev == nullptr) {
 		PX4_ERR("driver not running");
+		return PX4_ERROR;
 	}
 
 	PX4_INFO("state @ %p", g_dev);
 	g_dev->print_info();
+
+	return PX4_OK;
 }
 
 } // namespace
@@ -586,38 +605,38 @@ ms4525_airspeed_main(int argc, char *argv[])
 	 * Start/load the driver.
 	 */
 	if (!strcmp(argv[1], "start")) {
-		meas_airspeed::start(i2c_bus);
+		return meas_airspeed::start(i2c_bus);
 	}
 
 	/*
 	 * Stop the driver
 	 */
 	if (!strcmp(argv[1], "stop")) {
-		meas_airspeed::stop();
+		return meas_airspeed::stop();
 	}
 
 	/*
 	 * Test the driver/device.
 	 */
 	if (!strcmp(argv[1], "test")) {
-		meas_airspeed::test();
+		return meas_airspeed::test();
 	}
 
 	/*
 	 * Reset the driver.
 	 */
 	if (!strcmp(argv[1], "reset")) {
-		meas_airspeed::reset();
+		return meas_airspeed::reset();
 	}
 
 	/*
 	 * Print driver information.
 	 */
 	if (!strcmp(argv[1], "info") || !strcmp(argv[1], "status")) {
-		meas_airspeed::info();
+		return meas_airspeed::info();
 	}
 
 	meas_airspeed_usage();
 
-	return 0;
+	return PX4_OK;
 }