missionResult: remove unnecessary constants and rename instance_count to mission_update_counter

This commit is contained in:
Konrad
2023-11-24 08:11:41 +01:00
committed by Beat Küng
parent 7afa011741
commit a92e7a8796
5 changed files with 8 additions and 11 deletions
+3 -3
View File
@@ -1935,19 +1935,19 @@ void Commander::checkForMissionUpdate()
if (_mission_result_sub.updated()) {
const mission_result_s &mission_result = _mission_result_sub.get();
const auto prev_mission_instance_count = mission_result.instance_count;
const auto prev_mission_mission_update_counter = mission_result.mission_update_counter;
_mission_result_sub.update();
// if mission_result is valid for the current mission
const bool mission_result_ok = (mission_result.timestamp > _boot_timestamp)
&& (mission_result.instance_count > 0);
&& (mission_result.mission_update_counter > 0);
bool auto_mission_available = mission_result_ok && mission_result.valid;
if (mission_result_ok) {
/* Only evaluate mission state if home is set */
if (!_failsafe_flags.home_position_invalid &&
(prev_mission_instance_count != mission_result.instance_count)) {
(prev_mission_mission_update_counter != mission_result.mission_update_counter)) {
if (!auto_mission_available) {
/* the mission is invalid */
@@ -56,6 +56,6 @@ void MissionChecks::checkAndReport(const Context &context, Report &reporter)
}
// This is a mode requirement, no need to report
reporter.failsafeFlags().auto_mission_missing = mission_result.instance_count <= 0;
reporter.failsafeFlags().auto_mission_missing = mission_result.mission_update_counter <= 0;
}
}