From a5bc052d3119e18fe40cbe3cc653302a66661ce5 Mon Sep 17 00:00:00 2001 From: Pavel Kirienko Date: Sat, 21 Mar 2015 00:25:35 +0300 Subject: [PATCH] Notes on GDTR case sensitivity --- libuavcan/include/uavcan/node/global_data_type_registry.hpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libuavcan/include/uavcan/node/global_data_type_registry.hpp b/libuavcan/include/uavcan/node/global_data_type_registry.hpp index 7e27d92886..e2139f948c 100644 --- a/libuavcan/include/uavcan/node/global_data_type_registry.hpp +++ b/libuavcan/include/uavcan/node/global_data_type_registry.hpp @@ -37,6 +37,9 @@ typedef BitSet DataTypeIDMask; * * Attempt to use a data type that was not registered with this singleton (e.g. publish, subscribe, * perform a service call etc.) will fail with an error code @ref ErrUnknownDataType. + * + * Note that this class treats data type names in case-sensitive manner, although the UAVCAN + * specification allows them to be case-insensitive. TODO: make it non-case sensitive. */ class UAVCAN_EXPORT GlobalDataTypeRegistry : Noncopyable { @@ -128,6 +131,7 @@ public: * Finds data type descriptor by full data type name, e.g. "uavcan.protocol.NodeStatus". * Messages are searched first, then services. * Returns null pointer if the data type with this name is not registered. + * Note that search is case sensitive. * @param name Full data type name * @return Descriptor for this data type or null pointer if not found */ @@ -136,6 +140,7 @@ public: /** * Finds data type descriptor by full data type name, e.g. "uavcan.protocol.NodeStatus", and data type kind. * Returns null pointer if the data type with this name is not registered. + * Note that search is case sensitive. * @param kind Data Type Kind - message or service * @param name Full data type name * @return Descriptor for this data type or null pointer if not found