From a4f39c0f890ff0dbe68a84179dcf7d238e00eb91 Mon Sep 17 00:00:00 2001
From: Matthias Grob <maetugr@gmail.com>
Date: Sun, 16 Dec 2018 17:59:44 +0000
Subject: [PATCH] quaternion: reuse existing dot product

---
 matrix/Quaternion.hpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/matrix/Quaternion.hpp b/matrix/Quaternion.hpp
index 180bbd57cc..18fc2d68c5 100644
--- a/matrix/Quaternion.hpp
+++ b/matrix/Quaternion.hpp
@@ -194,7 +194,7 @@ public:
     {
         Quaternion &q = *this;
         Vector3<Type> cr = src.cross(dst);
-        float dt = src.dot(dst);
+        const float dt = src.dot(dst);
         /* If the two vectors are parallel, cross product is zero
          * If they point opposite, the dot product is negative */
         if (cr.norm() < eps && dt < 0) {
@@ -216,7 +216,7 @@ public:
             cr = src.cross(cr);
         } else {
             /* Half-Way Quaternion Solution */
-            q(0) = src.dot(dst) + sqrt(src.norm_squared() * dst.norm_squared());
+            q(0) = dt + sqrt(src.norm_squared() * dst.norm_squared());
         }
         q(1) = cr(0);
         q(2) = cr(1);