diff --git a/src/drivers/pwm_out/PWMOut.cpp b/src/drivers/pwm_out/PWMOut.cpp index e0c19fc2ad..c3d82c1370 100644 --- a/src/drivers/pwm_out/PWMOut.cpp +++ b/src/drivers/pwm_out/PWMOut.cpp @@ -187,7 +187,7 @@ void PWMOut::Run() } // check at end of cycle (updateSubscriptions() can potentially change to a different WorkQueue thread) - _mixing_output.updateSubscriptions(true, true); + _mixing_output.updateSubscriptions(true); perf_end(_cycle_perf); } diff --git a/src/drivers/px4io/px4io.cpp b/src/drivers/px4io/px4io.cpp index 2036f2c2d0..05d58e4b37 100644 --- a/src/drivers/px4io/px4io.cpp +++ b/src/drivers/px4io/px4io.cpp @@ -633,11 +633,11 @@ void PX4IO::Run() } } - _mixing_output.updateSubscriptions(true, true); - // minimal backup scheduling ScheduleDelayed(20_ms); + // check at end of cycle (updateSubscriptions() can potentially change to a different WorkQueue thread) + _mixing_output.updateSubscriptions(true); perf_end(_cycle_perf); } diff --git a/src/drivers/tap_esc/TAP_ESC.cpp b/src/drivers/tap_esc/TAP_ESC.cpp index 6118364266..2d6983d2a2 100644 --- a/src/drivers/tap_esc/TAP_ESC.cpp +++ b/src/drivers/tap_esc/TAP_ESC.cpp @@ -404,7 +404,7 @@ void TAP_ESC::Run() } // check at end of cycle (updateSubscriptions() can potentially change to a different WorkQueue thread) - _mixing_output.updateSubscriptions(true, true); + _mixing_output.updateSubscriptions(true); perf_end(_cycle_perf); } diff --git a/src/lib/mixer_module/mixer_module.cpp b/src/lib/mixer_module/mixer_module.cpp index 49d37d50f4..7a348ed738 100644 --- a/src/lib/mixer_module/mixer_module.cpp +++ b/src/lib/mixer_module/mixer_module.cpp @@ -212,7 +212,7 @@ void MixingOutput::cleanupFunctions() } } -bool MixingOutput::updateSubscriptions(bool allow_wq_switch, bool limit_callbacks_to_primary) +bool MixingOutput::updateSubscriptions(bool allow_wq_switch) { if (!_need_function_update || _armed.armed) { return false; diff --git a/src/lib/mixer_module/mixer_module.hpp b/src/lib/mixer_module/mixer_module.hpp index 05dd4bd490..f155e43a90 100644 --- a/src/lib/mixer_module/mixer_module.hpp +++ b/src/lib/mixer_module/mixer_module.hpp @@ -151,10 +151,9 @@ public: * Check for subscription updates. * Call this at the very end of Run() if allow_wq_switch * @param allow_wq_switch if true - * @param limit_callbacks_to_primary set to only register callbacks for primary actuator controls (if used) * @return true if subscriptions got changed */ - bool updateSubscriptions(bool allow_wq_switch = false, bool limit_callbacks_to_primary = false); + bool updateSubscriptions(bool allow_wq_switch = false); /** * unregister uORB subscription callbacks