From a1cf7619170c2383d73b5492e57dc9e26c1bb3d4 Mon Sep 17 00:00:00 2001 From: Pavel Kirienko Date: Wed, 10 Jun 2015 13:17:40 +0300 Subject: [PATCH] Coverity 1304857 1304856 1304855 --- .../protocol/dynamic_node_id_server/distributed/raft_core.hpp | 2 +- libuavcan_drivers/linux/apps/test_multithreading.cpp | 1 + libuavcan_drivers/linux/apps/test_node.cpp | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libuavcan/include/uavcan/protocol/dynamic_node_id_server/distributed/raft_core.hpp b/libuavcan/include/uavcan/protocol/dynamic_node_id_server/distributed/raft_core.hpp index 4a7ed7d331..33506a889f 100644 --- a/libuavcan/include/uavcan/protocol/dynamic_node_id_server/distributed/raft_core.hpp +++ b/libuavcan/include/uavcan/protocol/dynamic_node_id_server/distributed/raft_core.hpp @@ -167,7 +167,7 @@ private: static const int32_t randomization_range_msec = AppendEntries::Request::DEFAULT_MAX_ELECTION_TIMEOUT_MS - AppendEntries::Request::DEFAULT_MIN_ELECTION_TIMEOUT_MS; - + // coverity[dont_call] const int32_t random_msec = (std::rand() % randomization_range_msec) + 1; randomized_activity_timeout_ = diff --git a/libuavcan_drivers/linux/apps/test_multithreading.cpp b/libuavcan_drivers/linux/apps/test_multithreading.cpp index f1bcf79c63..3ef60bd1a4 100644 --- a/libuavcan_drivers/linux/apps/test_multithreading.cpp +++ b/libuavcan_drivers/linux/apps/test_multithreading.cpp @@ -438,6 +438,7 @@ static void runMainNode(const uavcan_linux::NodePtr& node) auto timer = node->makeTimer(uavcan::MonotonicDuration::fromMSec(10000), [&node](const uavcan::TimerEvent&) { node->logInfo("timer", "Your time is running out."); + // coverity[dont_call] node->setVendorSpecificStatusCode(static_cast(std::rand())); }); diff --git a/libuavcan_drivers/linux/apps/test_node.cpp b/libuavcan_drivers/linux/apps/test_node.cpp index 6dcfe292ee..0226e6ee51 100644 --- a/libuavcan_drivers/linux/apps/test_node.cpp +++ b/libuavcan_drivers/linux/apps/test_node.cpp @@ -84,6 +84,7 @@ static void runForever(const uavcan_linux::NodePtr& node) auto do_nothing_once_a_minute = [&node](const uavcan::TimerEvent&) { node->logInfo("timer", "Another minute passed..."); + // coverity[dont_call] node->setVendorSpecificStatusCode(static_cast(std::rand())); // Setting to an arbitrary value }; auto timer = node->makeTimer(uavcan::MonotonicDuration::fromMSec(60000), do_nothing_once_a_minute);