PX4 ROS2 msg conformity and explicit topics

- .msg files are PascalCase
 - topics are still either per msg or explicitly listed in TOPICS
 - compatible structs are still generated (eg struct msg_s), but ROS2 style px4::msg::Msg is also available

Tools/astyle/files_to_check_code_style.sh

@@ -8,7 +8,6 @@ if [ $# -gt 0 ]; then
 fi
 
 exec find boards msg src platforms test \
-    -path msg/templates/urtps -prune -o \
     -path platforms/nuttx/NuttX -prune -o \
     -path platforms/qurt/dspal -prune -o \
     -path src/drivers/uavcan/libuavcan -prune -o \
@@ -21,8 +20,6 @@ exec find boards msg src platforms test \
     -path src/modules/ekf2/EKF -prune -o \
     -path src/modules/gyro_fft/CMSIS_5 -prune -o \
     -path src/modules/mavlink/mavlink -prune -o \
-    -path src/modules/micrortps_bridge/micro-CDR -prune -o \
-    -path src/modules/micrortps_bridge/microRTPS_client -prune -o \
     -path test/mavsdk_tests/catch2 -prune -o \
     -path src/lib/crypto/monocypher -prune -o \
     -path src/lib/crypto/libtomcrypt -prune -o \

Tools/build_micrortps_agent.sh

@@ -1,15 +0,0 @@
-#!/usr/bin/env bash
-set -e
-
-SCRIPT_DIR=$0
-if [[ ${SCRIPT_DIR:0:1} != '/' ]]; then
-  SCRIPT_DIR=$(dirname $(realpath -s "$PWD/$0"))
-fi
-
-PX4_DIR=$(cd "$(dirname $(dirname $SCRIPT_DIR))" && pwd)
-
-if [ -d $PX4_DIR/build/*_rtps ]; then
-  cd $PX4_DIR/build/*_rtps/src/modules/micrortps_bridge/micrortps_agent/
-  cmake -Bbuild
-  cmake --build build -j$(nproc --all)
-fi

Tools/kconfig/cmake_kconfig_lut.txt

@@ -93,7 +93,6 @@ pca9685_pwm_out,CONFIG_DRIVERS_PCA9685_PWM_OUT=y
 power_monitor/ina226,CONFIG_DRIVERS_POWER_MONITOR_INA226=y
 power_monitor/voxlpm,CONFIG_DRIVERS_POWER_MONITOR_VOXLPM=y
 pps_capture,CONFIG_DRIVERS_PPS_CAPTURE=y
-protocol_splitter,CONFIG_DRIVERS_PROTOCOL_SPLITTER=y
 pwm_input,CONFIG_DRIVERS_PWM_INPUT=y
 pwm_out_sim,CONFIG_DRIVERS_PWM_OUT_SIM=y
 pwm_out,CONFIG_DRIVERS_PWM_OUT=y
@@ -138,7 +137,6 @@ mc_att_control,CONFIG_MODULES_MC_ATT_CONTROL=y
 mc_hover_thrust_estimator,CONFIG_MODULES_MC_HOVER_THRUST_ESTIMATOR=y
 mc_pos_control,CONFIG_MODULES_MC_POS_CONTROL=y
 mc_rate_control,CONFIG_MODULES_MC_RATE_CONTROL=y
-micrortps_bridge,CONFIG_MODULES_MICRORTPS_BRIDGE=y
 navigator,CONFIG_MODULES_NAVIGATOR=y
 px4iofirmware,CONFIG_MODULES_PX4IOFIRMWARE=y
 rc_update,CONFIG_MODULES_RC_UPDATE=y

Tools/px4_developer.mk.example

@@ -1,5 +0,0 @@
-$(info px4_developer.mk inclded)
-ifeq ($(UAVCAN_BL_OVERRIDE),y)
-$(info **************************  UAVCAN BOOT LOADERS built for In place application Debugging ***************************************)
-export EXTRAFLAGS +=-DDEBUG_APPLICATION_INPLACE
-endif

Tools/setup/arch.sh

@@ -9,8 +9,6 @@
 ## - jMAVSim simulator (omit with arg: --no-sim-tools)
 ## - Gazebo simulator (not by default, use --gazebo)
 ##
-## Not Installs:
-## - FastRTPS and FastCDR
 
 INSTALL_NUTTX="true"
 INSTALL_SIM="true"
@@ -122,7 +120,7 @@ if [[ $INSTALL_SIM == "true" ]]; then
 	echo
 	echo "Installing PX4 simulation dependencies"
 
-	# java (jmavsim or fastrtps)
+	# java (jmavsim)
 	sudo pacman -S --noconfirm --needed \
 		ant \
 		jdk-openjdk \

Tools/setup/ubuntu.sh

@@ -10,8 +10,6 @@ set -e
 ## - NuttX toolchain (omit with arg: --no-nuttx)
 ## - jMAVSim and Gazebo9 simulator (omit with arg: --no-sim-tools)
 ##
-## Not Installs:
-## - FastRTPS and FastCDR
 
 INSTALL_NUTTX="true"
 INSTALL_SIM="true"
@@ -208,7 +206,7 @@ if [[ $INSTALL_SIM == "true" ]]; then
 		java_version=14
 		gazebo_version=11
 	fi
-	# Java (jmavsim or fastrtps)
+	# Java (jmavsim)
 	sudo DEBIAN_FRONTEND=noninteractive apt-get -y --quiet --no-install-recommends install \
 		ant \
 		openjdk-$java_version-jre \

Tools/update_px4_ros2_bridge.sh

@@ -1,135 +0,0 @@
-#!/usr/bin/env bash
-set -e
-
-agent_template_files_updated=0
-code_generator_files_updated=0
-
-# parse help argument
-if [[ $1 == "-h" ]] || [[ $1 == "--help" ]]; then
-  echo -e "Usage: update_px4_ros2_bridge.bash [options...] \t This script allows to update px4_ros_com and px4_msgs in a specified directory." >&2
-  echo
-  echo -e "\t--ws_dir \t\t Location of the ament/colcon workspace. Default: $HOME/colcon_ws."
-  echo -e "\t--px4_ros_com \t\t Updates px4_ros_com microRTPS agent code generation and templates."
-  echo -e "\t--px4_msgs \t\t Updates px4_msgs messages definition files."
-  echo -e "\t--all \t\t Updates both px4_ros_com and px4_msgs."
-  echo
-  exit 0
-fi
-
-# parse the arguments
-while [ $# -gt 0 ]; do
-  if [[ $1 == *"--"* ]]; then
-    v="${1/--/}"
-    if [ ! -z $2 ]; then
-      declare $v="$2"
-    else
-      declare $v=1
-    fi
-  fi
-  shift
-done
-
-# get script directory
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-
-# get PX4-Autopilot directory
-PX4_DIR=$(cd "$(dirname "$SCRIPT_DIR")" && pwd)
-
-function compare_and_update () {
-  cmp -s "$1" "$2"
-  if [ $? -eq 1 ]; then
-    cp "$1" "$2"
-    return 0
-  fi
-
-  return 1;
-}
-
-# update microRTPS agent code generators / helpers
-function update_agent_code {
-  declare -a templates=( \
-    "microRTPS_agent.cpp.em" \
-    "microRTPS_timesync.cpp.em" \
-    "microRTPS_timesync.h.em" \
-    "microRTPS_transport.cpp" \
-    "microRTPS_transport.h" \
-    "Publisher.cpp.em" \
-    "Publisher.h.em" \
-    "Subscriber.cpp.em" \
-    "Subscriber.h.em" \
-    "RtpsTopics.cpp.em" \
-    "RtpsTopics.h.em" \
-    )
-
-  for file in ${templates[@]}; do
-    compare_and_update "$PX4_DIR/msg/templates/urtps/$file" "$ws_dir/src/px4_ros_com/templates/$file" \
-      && echo -e "--\t\t- '$ws_dir/src/px4_ros_com/templates/$file' updated" && ((agent_template_files_updated+=1))
-  done
-  if [ $agent_template_files_updated -eq 0 ]; then
-    echo -e "--\t\t- No template files updated"
-  elif [ $agent_template_files_updated -eq 1 ]; then
-    echo -e "--\t\t  - 1 template file updated"
-  else
-    echo -e "--\t\t  - $agent_template_files_updated template files updated"
-  fi
-}
-
-# update microRTPS agent code templates
-function update_agent_templates {
-  declare -a code_generators=( \
-    "uorb_rtps_classifier.py" \
-    "generate_microRTPS_bridge.py" \
-    "px_generate_uorb_topic_files.py" \
-    )
-  for file in ${code_generators[@]}; do
-    compare_and_update "$PX4_DIR/msg/tools/$file $ws_dir/src/px4_ros_com/scripts/$file" \
-      && echo -e "--\t\t- '$ws_dir/src/px4_ros_com/scripts/$file' updated" && ((code_generator_files_updated+=1))
-  done
-  if [ $code_generator_files_updated -eq 0 ]; then
-    echo -e "--\t\t- No code generators / helpers files updated"
-  elif [ $code_generator_files_updated -eq 1 ]; then
-    echo -e "--\t\t  - 1 code generator / helper file updated"
-  else
-    echo -e "--\t\t  - $code_generator_files_updated code generator / helper files updated"
-  fi
-}
-
-# update px4_ros_com files
-function update_px4_ros_com {
-  python3 $PX4_DIR/msg/tools/uorb_to_ros_urtps_topics.py -i $PX4_DIR/msg/tools/urtps_bridge_topics.yaml -o $ws_dir/src/px4_ros_com/templates/urtps_bridge_topics.yaml
-  echo -e "---------------          \033[1mmicroRTPS agent code generation and templates update\033[0m          ----------------"
-  echo "-------------------------------------------------------------------------------------------------------"
-  update_agent_code
-  update_agent_templates
-  return 0
-}
-
-# function to update px4_msgs
-function update_px4_msgs {
-  find "$ws_dir/src/px4_msgs/msg/" -maxdepth 1 -type f -delete
-  python3 $PX4_DIR/msg/tools/uorb_to_ros_msgs.py $PX4_DIR/msg/ $ws_dir/src/px4_msgs/msg/
-}
-
-# decisor
-echo "-------------------------------------------------------------------------------------------------------"
-if [ -d "${ws_dir}" ]; then
-  ws_dir=$(cd "$ws_dir" && pwd)
-  if [ ! -z ${all} ]; then
-    update_px4_ros_com
-    echo "-------------------------------------------------------------------------------------------------------"
-    update_px4_msgs
-  elif [ ! -z ${px4_ros_com} ]; then
-    update_px4_ros_com
-    echo "-------------------------------------------------------------------------------------------------------"
-  elif [ ! -z ${px4_msgs} ]; then
-    update_px4_msgs
-  fi
-  echo -e "--------------------------------          \033[0;32mUpdate successful!\033[0m          ---------------------------------"
-  echo "-------------------------------------------------------------------------------------------------------"
-  exit 0
-else
-  echo -e "-- \033[0;31mWorkspace directory doesn't exist...\033[0m"
-  echo -e "----------------------------------          \033[0;31mUpdate failed!\033[0m          -----------------------------------"
-  echo "-------------------------------------------------------------------------------------------------------"
-  exit $ERRCODE
-fi