fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-11-03 00:51:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix all sign-compare warnings

Browse Source
This commit is contained in:
Daniel Agar
2018-07-01 09:36:55 +00:00
committed by Lorenz Meier
parent cf74166801
commit 9ce83f2208
54 changed files with 106 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/systemcmds/motor_ramp/CMakeLists.txt
-1
View File
@@ -35,7 +35,6 @@ px4_add_module(
MAIN motor_ramp
STACK_MAIN 1200
COMPILE_FLAGS
-Wno-sign-compare # TODO: fix all sign-compare
-Wno-write-strings
SRCS
motor_ramp.cpp
src/systemcmds/motor_ramp/motor_ramp.cpp
+7 -7
View File
@@ -91,11 +91,11 @@ extern "C" __EXPORT int motor_ramp_main(int argc, char *argv[]);
*/
int motor_ramp_thread_main(int argc, char *argv[]);
bool min_pwm_valid(unsigned pwm_value);
bool min_pwm_valid(int pwm_value);
bool max_pwm_valid(unsigned pwm_value);
bool max_pwm_valid(int pwm_value);
int set_min_pwm(int fd, unsigned long max_channels, unsigned pwm_value);
int set_min_pwm(int fd, unsigned long max_channels, int pwm_value);
int set_out(int fd, unsigned long max_channels, float output);
@@ -212,17 +212,17 @@ int motor_ramp_main(int argc, char *argv[])
return 0;
}
bool min_pwm_valid(unsigned pwm_value)
bool min_pwm_valid(int pwm_value)
{
return pwm_value >= 900 && pwm_value <= 1500;
}
bool max_pwm_valid(unsigned pwm_value)
bool max_pwm_valid(int pwm_value)
{
return pwm_value <= 2100 && pwm_value > _min_pwm;
}
int set_min_pwm(int fd, unsigned long max_channels, unsigned pwm_value)
int set_min_pwm(int fd, unsigned long max_channels, int pwm_value)
{
int ret;
@@ -231,7 +231,7 @@ int set_min_pwm(int fd, unsigned long max_channels, unsigned pwm_value)
pwm_values.channel_count = max_channels;
for (int i = 0; i < max_channels; i++) {
for (unsigned i = 0; i < max_channels; i++) {
pwm_values.values[i] = pwm_value;
}