actuator outputs: always add reverse range param

and remove the possibility to set min > max to reverse.

Initially the idea was to add the checkbox on the UI side, to avoid adding
another param, but I don't think I'll go through the extra effort on the
QGC side.

Tools/module_config/generate_actuators_metadata.py

@@ -142,7 +142,6 @@ def get_actuator_output(yaml_config, output_functions, timer_config_file, verbos
         }
     if 'show_subgroups_if' in actuator_output_yaml:
         actuator_output['show-subgroups-if'] = actuator_output_yaml['show_subgroups_if']
-    add_reverse_range_param = actuator_output_yaml.get('add_reverse_range_param', False)
 
     # config parameters
     def get_config_params(param_list):
@@ -257,14 +256,13 @@ def get_actuator_output(yaml_config, output_functions, timer_config_file, verbos
                 per_channel_params.append(param)
 
 
-        if add_reverse_range_param:
-            param = {
-                    'label': 'Rev Range\n(for Servos)',
-                    'name': param_prefix+'_REV',
-                    'index-offset': -1,
-                    'show-as': 'bitset',
-                }
-            per_channel_params.append(param)
+        param = {
+                'label': 'Rev Range\n(for Servos)',
+                'name': param_prefix+'_REV',
+                'index-offset': -1,
+                'show-as': 'bitset',
+            }
+        per_channel_params.append(param)
 
         # TODO: support non-standard per-channel parameters
 

Tools/module_config/generate_params.py

@@ -178,7 +178,6 @@ def get_actuator_output_params(yaml_config, output_functions,
     all_params = {}
     group_idx = 0
 
-    add_reverse_range_param = yaml_config['actuator_output'].get('add_reverse_range_param', False)
     all_param_prefixes = {}
 
     def add_local_param(param_name, param_def):
@@ -299,13 +298,9 @@ Note that non-motor outputs might already be active in prearm state if COM_PREAR
 '''
         minimum_description = \
 '''Minimum output value (when not disarmed).
-
-The output range can be reversed by setting Min > Max.
 '''
         maximum_description = \
 '''Maxmimum output value (when not disarmed).
-
-The output range can be reversed by setting Min > Max.
 '''
         failsafe_description = \
 '''This is the output value that is set when in failsafe mode.
@@ -346,29 +341,29 @@ When set to -1 (default), the value depends on the function (see {:}).
                     }
                 add_local_param(param_prefix+'_'+param_suffix+'${i}', param)
 
-    if add_reverse_range_param:
-        for param_prefix in all_param_prefixes:
-            groups = all_param_prefixes[param_prefix]
-            # collect the bits
-            channel_bits = {}
-            for instance_start, instance_start_label, num_instances, label in groups:
-                for instance in range(instance_start, instance_start+num_instances):
-                    instance_label = instance - instance_start + instance_start_label
-                    channel_bits[instance-1] = label + ' ' + str(instance_label)
+    # add reverse range param
+    for param_prefix in all_param_prefixes:
+        groups = all_param_prefixes[param_prefix]
+        # collect the bits
+        channel_bits = {}
+        for instance_start, instance_start_label, num_instances, label in groups:
+            for instance in range(instance_start, instance_start+num_instances):
+                instance_label = instance - instance_start + instance_start_label
+                channel_bits[instance-1] = label + ' ' + str(instance_label)
 
-            param = {
-                'description': {
-                    'short': 'Reverse Output Range for '+module_name,
-                    'long':
+        param = {
+            'description': {
+                'short': 'Reverse Output Range for '+module_name,
+                'long':
 '''Allows to reverse the output range for each channel.
 Note: this is only useful for servos.
 '''.format(channel_label),
-                    },
-                'type': 'bitmask',
-                'default': 0,
-                'bit': channel_bits
-                }
-            add_local_param(param_prefix+'_REV', param)
+                },
+            'type': 'bitmask',
+            'default': 0,
+            'bit': channel_bits
+            }
+        add_local_param(param_prefix+'_REV', param)
 
     if verbose: print('adding actuator params: {:}'.format(all_params))
     return all_params