Misc clean; mark assertions as non-returning; allow toolchain prefix to be overriden from make command line

git-svn-id: http://svn.code.sf.net/p/nuttx/code/trunk@5591 42af7a65-404d-4744-a932-0658087f49c3

nuttx/drivers/serial/serial.c

@@ -1041,8 +1041,11 @@ void uart_datasent(FAR uart_dev_t *dev)
 #ifdef CONFIG_SERIAL_REMOVABLE
 void uart_connected(FAR uart_dev_t *dev, bool connected)
 {
+  irqstate_t flags;
+
   /* Is the device disconnected? */
 
+  flags = irqsave();
   dev->disconnected = !connected;
   if (!connected)
     {
@@ -1070,10 +1073,12 @@ void uart_connected(FAR uart_dev_t *dev, bool connected)
           (void)sem_post(&dev->recvsem);
         }
 
-      /* Notify all poll/select waiters that and hangup/error occurred */
+      /* Notify all poll/select waiters that and hangup occurred */
 
       uart_pollnotify(dev, (POLLERR|POLLHUP));
     }
+
+  irqrestore(flags);
 }
 #endif