From 8fd3d3268adb795ec075308792300a2ac4ec7c25 Mon Sep 17 00:00:00 2001 From: Ege Kural Date: Mon, 23 Feb 2026 20:54:36 -0500 Subject: [PATCH] CI: enable clang-tidy readability-duplicate-include (#26554) Signed-off-by: kuralme --- .clang-tidy | 1 - platforms/common/work_queue/hrt_queue.c | 1 - platforms/posix/src/px4/common/px4_posix_impl.cpp | 1 - platforms/posix/src/px4/common/tasks.cpp | 1 - src/modules/navigator/geofence.cpp | 2 -- src/modules/navigator/mission.cpp | 1 - src/modules/simulation/simulator_mavlink/SimulatorMavlink.cpp | 1 - 7 files changed, 8 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 9293603c71..10dc90d5fc 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -167,7 +167,6 @@ Checks: '*, -readability-avoid-return-with-void-value, -readability-avoid-unconditional-preprocessor-if, -readability-delete-null-pointer, - -readability-duplicate-include, -readability-redundant-casting, -readability-redundant-member-init, -readability-reference-to-constructed-temporary, diff --git a/platforms/common/work_queue/hrt_queue.c b/platforms/common/work_queue/hrt_queue.c index 9393a9e7c2..d602e5ea1b 100644 --- a/platforms/common/work_queue/hrt_queue.c +++ b/platforms/common/work_queue/hrt_queue.c @@ -48,7 +48,6 @@ #include #include #include -#include #include #include "hrt_work.h" diff --git a/platforms/posix/src/px4/common/px4_posix_impl.cpp b/platforms/posix/src/px4/common/px4_posix_impl.cpp index 31c1bb125c..a8d021db77 100644 --- a/platforms/posix/src/px4/common/px4_posix_impl.cpp +++ b/platforms/posix/src/px4/common/px4_posix_impl.cpp @@ -39,7 +39,6 @@ #include #include -#include #include #include #include diff --git a/platforms/posix/src/px4/common/tasks.cpp b/platforms/posix/src/px4/common/tasks.cpp index 1d1e70569b..b5df4d56f0 100644 --- a/platforms/posix/src/px4/common/tasks.cpp +++ b/platforms/posix/src/px4/common/tasks.cpp @@ -46,7 +46,6 @@ #include #include #include -#include #include #include #include diff --git a/src/modules/navigator/geofence.cpp b/src/modules/navigator/geofence.cpp index 09fa712b20..9d29586bcf 100644 --- a/src/modules/navigator/geofence.cpp +++ b/src/modules/navigator/geofence.cpp @@ -51,8 +51,6 @@ #include #include -#include "navigator.h" - static uint32_t crc32_for_fence_point(const mission_fence_point_s &fence_point, uint32_t prev_crc32) { union { diff --git a/src/modules/navigator/mission.cpp b/src/modules/navigator/mission.cpp index 68226b17a7..c6fcb143a1 100644 --- a/src/modules/navigator/mission.cpp +++ b/src/modules/navigator/mission.cpp @@ -57,7 +57,6 @@ #include #include #include -#include #include using namespace time_literals; diff --git a/src/modules/simulation/simulator_mavlink/SimulatorMavlink.cpp b/src/modules/simulation/simulator_mavlink/SimulatorMavlink.cpp index 342cfcd4e7..91ec04ac67 100644 --- a/src/modules/simulation/simulator_mavlink/SimulatorMavlink.cpp +++ b/src/modules/simulation/simulator_mavlink/SimulatorMavlink.cpp @@ -54,7 +54,6 @@ #include #include #include -#include #include