fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-11-02 14:51:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent stack overflow when flashing px4io

Browse Source 
Large local variable causing stack overflow when attempting to flash
IO!!!
This commit is contained in:
Jean Cyr
2014-07-10 00:41:09 -04:00
parent 8f2340acaf
commit 8c6745d53f
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/drivers/px4io/px4io_uploader.cpp
+15 -3
View File
@@ -39,6 +39,7 @@
#include <nuttx/config.h> #include <nuttx/config.h>
#include <sys/types.h> #include <sys/types.h>
#include <stdlib.h>
#include <stdint.h> #include <stdint.h>
#include <stdbool.h> #include <stdbool.h>
#include <assert.h> #include <assert.h>
@@ -413,11 +414,17 @@ static int read_with_retry(int fd, void *buf, size_t n)
int int
PX4IO_Uploader::program(size_t fw_size) PX4IO_Uploader::program(size_t fw_size)
{ {
uint8_t file_buf[PROG_MULTI_MAX]; uint8_t *file_buf;
ssize_t count; ssize_t count;
int ret; int ret;
size_t sent = 0; size_t sent = 0;
file_buf = (uint8_t *)malloc(PROG_MULTI_MAX);
if (!file_buf) {
log("Can't allocate program buffer");
return -ENOMEM;
}
log("programming %u bytes...", (unsigned)fw_size); log("programming %u bytes...", (unsigned)fw_size);
ret = lseek(_fw_fd, 0, SEEK_SET); ret = lseek(_fw_fd, 0, SEEK_SET);
@@ -438,8 +445,10 @@ PX4IO_Uploader::program(size_t fw_size)
(int)errno); (int)errno);
} }
if (count == 0) if (count == 0) {
free(file_buf);
return OK; return OK;
}
sent += count; sent += count;
@@ -455,9 +464,12 @@ PX4IO_Uploader::program(size_t fw_size)
ret = get_sync(1000); ret = get_sync(1000);
if (ret != OK) if (ret != OK) {
free(file_buf);
return ret; return ret;
}
} }
free(file_buf);
return OK; return OK;
} }