fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-10-31 05:21:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

px4_mtd: the address of 'instances' will never be NULL (#21039)

Browse Source 
Signed-off-by: AuroraRAS <chplee@gmail.com>
This commit is contained in:
小光
2023-02-02 08:06:00 +01:00
committed by GitHub
parent d9a4d1d5c4
commit 849fbabc47
1 changed files with 22 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platforms/nuttx/src/px4/common/px4_mtd.cpp
+22 -24
View File
@@ -308,7 +308,7 @@ int px4_mtd_config(const px4_mtd_manifest_t *mft_mtd)
instances[i] = new mtd_instance_s; instances[i] = new mtd_instance_s;
if (instances == nullptr) { if (instances[i] == nullptr) {
memoryout: memoryout:
PX4_ERR("failed to allocate memory!"); PX4_ERR("failed to allocate memory!");
return rv; return rv;
@@ -444,41 +444,39 @@ __EXPORT int px4_mtd_query(const char *sub, const char *val, const char **get)
{ {
int rv = -ENODEV; int rv = -ENODEV;
if (instances != nullptr) { static const char *keys[] = PX4_MFT_MTD_STR_TYPES;
static const px4_mtd_types_t types[] = PX4_MFT_MTD_TYPES;
int key = 0;
static const char *keys[] = PX4_MFT_MTD_STR_TYPES; for (unsigned int k = 0; k < arraySize(keys); k++) {
static const px4_mtd_types_t types[] = PX4_MFT_MTD_TYPES; if (!strcmp(keys[k], sub)) {
int key = 0; key = types[k];
break;
for (unsigned int k = 0; k < arraySize(keys); k++) {
if (!strcmp(keys[k], sub)) {
key = types[k];
break;
}
} }
}
rv = -EINVAL; rv = -EINVAL;
if (key != 0) { if (key != 0) {
rv = -ENOENT; rv = -ENOENT;
for (int i = 0; i < num_instances; i++) { for (int i = 0; i < num_instances; i++) {
for (unsigned n = 0; n < instances[i]->n_partitions_current; n++) { for (unsigned n = 0; n < instances[i]->n_partitions_current; n++) {
if (instances[i]->partition_types[n] == key) { if (instances[i]->partition_types[n] == key) {
if (get != nullptr && val == nullptr) { if (get != nullptr && val == nullptr) {
*get = instances[i]->partition_names[n]; *get = instances[i]->partition_names[n];
return 0; return 0;
} }
if (val != nullptr && strcmp(instances[i]->partition_names[n], val) == 0) { if (val != nullptr && strcmp(instances[i]->partition_names[n], val) == 0) {
return 0; return 0;
}
} }
} }
} }
} }
} }
return rv; return rv;
} }