enable Wshadow

src/drivers/camera_trigger/camera_trigger.cpp

@@ -116,7 +116,7 @@ private:
 	int 			_gpio_fd;
 
 	int 			_polarity;
-	int			_mode;
+	int				_mode;
 	float 			_activation_time;
 	float  			_interval;
 	float  			_distance;
@@ -229,9 +229,9 @@ CameraTrigger::CameraTrigger() :
 		i++;
 	}
 
-	struct camera_trigger_s	trigger = {};
+	struct camera_trigger_s	camera_trigger = {};
 
-	_trigger_pub = orb_advertise(ORB_ID(camera_trigger), &trigger);
+	_trigger_pub = orb_advertise(ORB_ID(camera_trigger), &camera_trigger);
 }
 
 CameraTrigger::~CameraTrigger()

src/drivers/pwm_out_sim/pwm_out_sim.cpp

@@ -383,8 +383,7 @@ PWMSim::task_main()
 	_armed_sub = orb_subscribe(ORB_ID(actuator_armed));
 
 	/* advertise the mixed control outputs */
-	actuator_outputs_s outputs;
-	memset(&outputs, 0, sizeof(outputs));
+	actuator_outputs_s outputs = {};
 
 	/* advertise the mixed control outputs, insist on the first group output */
 	_outputs_pub = orb_advertise(ORB_ID(actuator_outputs), &outputs);
@@ -483,7 +482,6 @@ PWMSim::task_main()
 			}
 
 			/* do mixing */
-			actuator_outputs_s outputs = {};
 			num_outputs = _mixers->mix(&outputs.output[0], num_outputs, NULL);
 			outputs.noutputs = num_outputs;
 			outputs.timestamp = hrt_absolute_time();

src/drivers/px4fmu/fmu.cpp

@@ -861,17 +861,17 @@ PX4FMU::fill_rc_in(uint16_t raw_rc_count,
 
 		/* set RSSI if analog RSSI input is present */
 		if (_analog_rc_rssi_stable) {
-			float rssi = ((_analog_rc_rssi_volt - 0.2f) / 3.0f) * 100.0f;
+			float rssi_analog = ((_analog_rc_rssi_volt - 0.2f) / 3.0f) * 100.0f;
 
-			if (rssi > 100.0f) {
-				rssi = 100.0f;
+			if (rssi_analog > 100.0f) {
+				rssi_analog = 100.0f;
 			}
 
-			if (rssi < 0.0f) {
-				rssi = 0.0f;
+			if (rssi_analog < 0.0f) {
+				rssi_analog = 0.0f;
 			}
 
-			_rc_in.rssi = rssi;
+			_rc_in.rssi = rssi_analog;
 
 		} else {
 			_rc_in.rssi = 255;

src/drivers/snapdragon_rc_pwm/CMakeLists.txt

@@ -35,6 +35,8 @@ px4_add_module(
 	MAIN snapdragon_rc_pwm
 	COMPILE_FLAGS
 		-Os
+		-Wno-attributes
+		-Wno-packed
 	SRCS
 		snapdragon_rc_pwm.cpp
 	DEPENDS