fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-05-17 16:17:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy param avoid malloc(0)

Browse Source
This commit is contained in:
Daniel Agar
2017-04-23 21:56:08 -04:00
parent 2e0ed3b47b
commit 768faa1ae3
2 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/systemlib/param/param.c
+16 -2
View File
@@ -727,7 +727,14 @@ param_set_internal(param_t param, const void *val, bool mark_saved, bool notify_
case PARAM_TYPE_STRUCT ... PARAM_TYPE_STRUCT_MAX:
if (s->val.p == NULL) {
s->val.p = malloc(param_size(param));
size_t psize = param_size(param);
if (psize > 0) {
s->val.p = malloc(psize);
} else {
s->val.p = NULL;
}
if (s->val.p == NULL) {
debug("failed to allocate parameter storage");
@@ -1168,7 +1175,14 @@ param_import_callback(bson_decoder_t decoder, void *private, bson_node_t node)
}
/* XXX check actual file data size? */
tmp = malloc(param_size(param));
size_t psize = param_size(param);
if (psize > 0) {
tmp = malloc(psize);
} else {
tmp = NULL;
}
if (tmp == NULL) {
debug("failed allocating for '%s'", node->name);