From 6f7ae9b5e57d47b0e7660cfd615a1fe320844de0 Mon Sep 17 00:00:00 2001 From: Jacob Dahl Date: Sun, 15 Mar 2026 12:04:36 -0800 Subject: [PATCH] refactor(navigator): pass mission_s by const reference --- src/modules/navigator/mission_base.cpp | 2 +- src/modules/navigator/mission_base.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/navigator/mission_base.cpp b/src/modules/navigator/mission_base.cpp index 8753f3751c..ba9872a34c 100644 --- a/src/modules/navigator/mission_base.cpp +++ b/src/modules/navigator/mission_base.cpp @@ -1440,7 +1440,7 @@ void MissionBase::checkClimbRequired(int32_t mission_item_index) } } -bool MissionBase::checkMissionDataChanged(mission_s new_mission) +bool MissionBase::checkMissionDataChanged(const mission_s &new_mission) { /* count and land_index are the same if the mission_id did not change. We do not care about changes in geofence or rally counters.*/ return ((new_mission.mission_dataman_id != _mission.mission_dataman_id) || diff --git a/src/modules/navigator/mission_base.h b/src/modules/navigator/mission_base.h index 3479c3752d..982474ba69 100644 --- a/src/modules/navigator/mission_base.h +++ b/src/modules/navigator/mission_base.h @@ -464,7 +464,7 @@ private: * @param[in] new_mission new mission received over uorb * @return true if the relevant mission data has changed, false otherwise */ - bool checkMissionDataChanged(mission_s new_mission); + bool checkMissionDataChanged(const mission_s &new_mission); /** * @brief update current mission altitude after the home position has changed.