mc_att_control: remove time constant parameter

Because the parameter does not make sense from a control theory
perspective. Either you have a gain with the unit 1/s or an inverse
gain or time constant with the unit s. But the time constant parameter
was neither bound to any exact unit nor did it apply instead of a gain.
Rather it adjusted multiple gains from rate and attitude control
according to an arbitrary scale. This can only by accident lead to
good tuning.
This commit is contained in:
Matthias Grob
2018-03-15 17:16:14 +01:00
parent ba5f2254cd
commit 6317d36ec9
3 changed files with 12 additions and 54 deletions
@@ -39,34 +39,6 @@
* @author Anton Babushkin <anton@px4.io>
*/
/**
* Roll time constant
*
* Reduce if the system is too twitchy, increase if the response is too slow and sluggish.
*
* @unit s
* @min 0.15
* @max 0.25
* @decimal 2
* @increment 0.01
* @group Multicopter Attitude Control
*/
PARAM_DEFINE_FLOAT(MC_ROLL_TC, 0.2f);
/**
* Pitch time constant
*
* Reduce if the system is too twitchy, increase if the response is too slow and sluggish.
*
* @unit s
* @min 0.15
* @max 0.25
* @decimal 2
* @increment 0.01
* @group Multicopter Attitude Control
*/
PARAM_DEFINE_FLOAT(MC_PITCH_TC, 0.2f);
/**
* Roll P gain
*