From 4c21163c78be3a585001189705adba6c337880ff Mon Sep 17 00:00:00 2001 From: Todd Colten Date: Sun, 17 Feb 2019 18:30:34 -0600 Subject: [PATCH] re-word landing required msg for understandability changed: "Mission rejected: land start required." to: "Mission rejected: landing pattern required." This new message is more clear to the average user. When using RTL_TYPE = 1, mission feasibility checker adds the requirement of a landing sequence beginning with a MAV_CMD_DO_LAND_START and ending with a MAV_CMD_NAV_LAND with at least 1 other waypoint prior to the land waypoint. The warning message "Mission rejected: land start required." is a common warning to trigger whenever the mission is blank or the mission is uploaded without a landing pattern. The wording in this message confusing to the average user as they usually do not know the inner workings of the "landing pattern" that their planning software helps them make (e.g. Qgroundcontrol). The only users who would know what a "Do_Land_Start" mission item is are advanced users already and this new message should work equally well for them as well as the non-advanced user. --- src/modules/navigator/mission_feasibility_checker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/navigator/mission_feasibility_checker.cpp b/src/modules/navigator/mission_feasibility_checker.cpp index 893eb0b6dc..2ecb7f74fe 100644 --- a/src/modules/navigator/mission_feasibility_checker.cpp +++ b/src/modules/navigator/mission_feasibility_checker.cpp @@ -458,7 +458,7 @@ MissionFeasibilityChecker::checkFixedWingLanding(const mission_s &mission, bool } if (land_start_req && !land_start_found) { - mavlink_log_critical(_navigator->get_mavlink_log_pub(), "Mission rejected: land start required."); + mavlink_log_critical(_navigator->get_mavlink_log_pub(), "Mission rejected: landing pattern required."); return false; }