fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-07-04 01:30:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fw_mode_manager: pass FigureEightPatternPoints by const reference

Browse Source 
The 48-byte struct (6 Vector2f) is only read inside initializePattern,
so passing by value creates an unnecessary copy.

Fixes performance-unnecessary-value-param clang-tidy diagnostic.

Signed-off-by: Ramon Roche <mrpollo@gmail.com>
This commit is contained in:
Ramon Roche
2026-02-09 15:10:43 -08:00
parent b60aa5dd2b
commit 497704f3b9
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/fw_mode_manager/figure_eight/FigureEight.cpp
+1 -1
View File
@@ -105,7 +105,7 @@ FigureEight::FigureEightPatternParameters FigureEight::sanitizeParameters(const
}
void FigureEight::initializePattern(const matrix::Vector2f &curr_pos_local, const matrix::Vector2f &ground_speed,
const FigureEightPatternParameters &parameters, FigureEightPatternPoints pattern_points)
const FigureEightPatternParameters &parameters, const FigureEightPatternPoints &pattern_points)
{
// Initialize the currently active segment, if it hasn't been active yet, or the pattern has been changed.
if ((_current_segment == FigureEightSegment::SEGMENT_UNDEFINED) || (_active_parameters != parameters)) {
src/modules/fw_mode_manager/figure_eight/FigureEight.hpp
+1 -1
View File
@@ -140,7 +140,7 @@ private:
* @param[in] pattern_points are the figure of eight pattern points.
*/
void initializePattern(const matrix::Vector2f &curr_pos_local, const matrix::Vector2f &ground_speed,
const FigureEightPatternParameters &parameters, FigureEightPatternPoints pattern_points);
const FigureEightPatternParameters &parameters, const FigureEightPatternPoints &pattern_points);
/**
* @brief Calculate figure eight pattern points