cmake use standard mechanisms for settings flags

src/lib/rc/rc_tests/RCTest.cpp

@@ -15,10 +15,10 @@
 #include <lib/rc/sumd.h>
 #include <lib/rc/crsf.h>
 
-#if !defined(CONFIG_ARCH_BOARD_SITL)
-#define TEST_DATA_PATH "/fs/microsd"
-#else
+#if defined(CONFIG_ARCH_BOARD_PX4_SITL)
 #define TEST_DATA_PATH "./test_data/"
+#else
+#define TEST_DATA_PATH "/fs/microsd"
 #endif
 
 extern "C" __EXPORT int rc_tests_main(int argc, char *argv[]);

src/lib/version/CMakeLists.txt

@@ -76,8 +76,6 @@ endif()
 
 add_library(version version.c)
 
-string(TOUPPER "${PX4_BOARD}" PX4_BOARD_NAME)
-
 target_compile_definitions(version
 	PUBLIC
 		PX4_BOARD_NAME="${PX4_BOARD_NAME}"