delete px4_includes.h header and update boards/ to use syslog

src/drivers/barometer/lps22hb/LPS22HB.hpp

@@ -44,6 +44,7 @@
 #include <drivers/drv_hrt.h>
 #include <drivers/device/ringbuffer.h>
 #include <drivers/drv_device.h>
+#include <systemlib/err.h>
 
 #include <uORB/uORB.h>
 

src/drivers/batt_smbus/batt_smbus.cpp

@@ -43,6 +43,8 @@
 
 #include "batt_smbus.h"
 
+#include <stdlib.h>
+
 extern "C" __EXPORT int batt_smbus_main(int argc, char *argv[]);
 
 struct work_s BATT_SMBUS::_work = {};

src/drivers/differential_pressure/ms5525/MS5525_main.cpp

@@ -35,6 +35,8 @@
 
 #include <px4_getopt.h>
 
+#include <stdlib.h>
+
 // Driver 'main' command.
 extern "C" __EXPORT int ms5525_airspeed_main(int argc, char *argv[]);
 

src/drivers/differential_pressure/sdp3x/SDP3X_main.cpp

@@ -32,8 +32,11 @@
  ****************************************************************************/
 
 #include "SDP3X.hpp"
+
 #include <px4_getopt.h>
 
+#include <stdlib.h>
+
 // Driver 'main' command.
 extern "C" __EXPORT int sdp3x_airspeed_main(int argc, char *argv[]);
 

src/drivers/distance_sensor/leddar_one/leddar_one.cpp

@@ -36,6 +36,7 @@
 #include <px4_getopt.h>
 #include <px4_defines.h>
 
+#include <stdlib.h>
 #include <string.h>
 #include <termios.h>
 

src/drivers/distance_sensor/ll40ls/LidarLitePWM.cpp

@@ -122,7 +122,7 @@ void LidarLitePWM::print_info()
 	perf_print_counter(_sample_perf);
 	perf_print_counter(_read_errors);
 	perf_print_counter(_sensor_zero_resets);
-	warnx("poll interval:  %u ticks", getMeasureTicks());
+	PX4_INFO("poll interval:  %u ticks", getMeasureTicks());
 
 	print_message(_range);
 }

src/drivers/distance_sensor/ulanding/ulanding.cpp

@@ -303,8 +303,6 @@ Radar::task_main_trampoline(int argc, char *argv[])
 int
 Radar::start()
 {
-	ASSERT(_task_handle == -1);
-
 	/* start the task */
 	_task_handle = px4_task_spawn_cmd("ulanding_radar",
 					  SCHED_DEFAULT,

src/drivers/imu/adis16477/ADIS16477.hpp

@@ -49,6 +49,7 @@
 #include <lib/conversion/rotation.h>
 #include <perf/perf_counter.h>
 #include <ecl/geo/geo.h>
+#include <systemlib/err.h>
 
 #define ADIS16477_GYRO_DEFAULT_RATE					250
 #define ADIS16477_GYRO_DEFAULT_DRIVER_FILTER_FREQ	30

src/drivers/imu/bmi055/BMI055.hpp

@@ -40,6 +40,7 @@
 #include <lib/perf/perf_counter.h>
 #include <px4_config.h>
 #include <systemlib/conversions.h>
+#include <systemlib/err.h>
 
 #define DIR_READ                0x80
 #define DIR_WRITE               0x00

src/drivers/imu/fxas21002c/fxas21002c.cpp

@@ -73,6 +73,7 @@
 #include <mathlib/math/filter/LowPassFilter2p.hpp>
 #include <lib/conversion/rotation.h>
 #include <platforms/px4_getopt.h>
+#include <systemlib/err.h>
 
 /* SPI protocol address bits */
 #define DIR_READ(a)                     ((a) | (1 << 7))

src/drivers/imu/fxos8701cq/fxos8701cq.cpp

@@ -77,6 +77,7 @@
 #include <mathlib/math/filter/LowPassFilter2p.hpp>
 #include <lib/conversion/rotation.h>
 #include <platforms/px4_getopt.h>
+#include <systemlib/err.h>
 
 /* SPI protocol address bits */
 #define DIR_READ(a)                     ((a) & 0x7f)

src/drivers/imu/mpu9250/mpu9250.h

@@ -48,6 +48,7 @@
 #include <drivers/drv_mag.h>
 #include <mathlib/math/filter/LowPassFilter2p.hpp>
 #include <lib/conversion/rotation.h>
+#include <systemlib/err.h>
 
 #include <uORB/uORB.h>
 #include <uORB/topics/debug_key_value.h>

src/drivers/linux_pwm_out/linux_pwm_out.cpp

@@ -31,13 +31,16 @@
  *
  ****************************************************************************/
 
+#include <errno.h>
 #include <stdint.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include <cmath>
 
 #include <px4_tasks.h>
 #include <px4_getopt.h>
 #include <px4_posix.h>
-#include <errno.h>
-#include <cmath>	// NAN
 
 #include <uORB/uORB.h>
 #include <uORB/topics/actuator_controls.h>
@@ -461,8 +464,6 @@ void task_main_trampoline(int argc, char *argv[])
 
 void start()
 {
-	ASSERT(_task_handle == -1);
-
 	_task_should_exit = false;
 
 	/* start the task */
@@ -474,7 +475,7 @@ void start()
 					  nullptr);
 
 	if (_task_handle < 0) {
-		warn("task start failed");
+		PX4_ERR("task start failed");
 		return;
 	}
 

src/drivers/linux_sbus/linux_sbus.cpp

@@ -33,7 +33,12 @@
  *
  ****************************************************************************/
 #include "linux_sbus.h"
+
+#include <stdlib.h>
+#include <string.h>
+
 using namespace linux_sbus;
+
 //---------------------------------------------------------------------------------------------------------//
 int RcInput::init()
 {

src/drivers/magnetometer/lis3mdl/lis3mdl.h

@@ -47,6 +47,7 @@
 #include <drivers/drv_mag.h>
 
 #include <lib/conversion/rotation.h>
+#include <systemlib/err.h>
 
 #include <perf/perf_counter.h>
 #include <px4_defines.h>

src/drivers/magnetometer/lsm303agr/LSM303AGR.hpp

@@ -43,6 +43,7 @@
 #include <lib/conversion/rotation.h>
 #include <perf/perf_counter.h>
 #include <px4_workqueue.h>
+#include <systemlib/err.h>
 
 // Register mapping
 static constexpr uint8_t WHO_AM_I_M = 0x4F;

src/drivers/magnetometer/rm3100/rm3100.h

@@ -50,6 +50,7 @@
 
 #include <perf/perf_counter.h>
 #include <px4_defines.h>
+#include <systemlib/err.h>
 
 #ifndef CONFIG_SCHED_WORKQUEUE
 # error This requires CONFIG_SCHED_WORKQUEUE.

src/drivers/snapdragon_pwm_out/snapdragon_pwm_out.cpp

@@ -38,7 +38,7 @@
 #include <px4_posix.h>
 #include <errno.h>
 #include <cmath>	// NAN
-
+#include <string.h>
 
 #include <uORB/uORB.h>
 #include <uORB/topics/actuator_controls.h>
@@ -505,8 +505,6 @@ void task_main_trampoline(int argc, char *argv[])
 
 void start()
 {
-	ASSERT(_task_handle == -1);
-
 	_task_should_exit = false;
 
 	/* start the task */
@@ -518,7 +516,7 @@ void start()
 					  nullptr);
 
 	if (_task_handle < 0) {
-		warn("task start failed");
+		PX4_ERR("task start failed");
 		return;
 	}
 

src/drivers/spektrum_rc/spektrum_rc.cpp

@@ -39,6 +39,8 @@
  * on the serial port. By default port J12 (next to J13, power module side) is used.
  */
 
+#include <string.h>
+
 #include <px4_tasks.h>
 #include <px4_posix.h>
 #include <px4_getopt.h>
@@ -212,8 +214,6 @@ int start(int argc, char *argv[])
 		return -1;
 	}
 
-	ASSERT(_task_handle == -1);
-
 	_task_should_exit = false;
 
 	_task_handle = px4_task_spawn_cmd("spektrum_rc_main",

src/drivers/uavcan/sensors/sensor_bridge.hpp

@@ -41,6 +41,7 @@
 #include <uavcan/uavcan.hpp>
 #include <drivers/device/device.h>
 #include <drivers/drv_orb_dev.h>
+#include <uORB/uORB.h>
 
 /**
  * A sensor bridge class must implement this interface.