From 2445fa8b4c46530d9a474b44733da3a3fe75f2c7 Mon Sep 17 00:00:00 2001 From: Julian Oes Date: Tue, 21 Dec 2021 13:15:34 +0100 Subject: [PATCH] commander: prevent uninitialized warning This prevents a memory sanitizer/valgrind warning: Conditional jump or move depends on uninitialised value(s) at 0x2DA536: __sanitizer_cov_trace_cmp4 (in build/px4_sitl_default-clang/bin/px4) by 0x6590D8: FailureDetector::update(vehicle_status_s const&, vehicle_control_mode_s const&) (src/modules/commander/failure_detector/FailureDetector.cpp:76) by 0x3817DF: Commander::run() (src/modules/commander/Commander.cpp:2605) by 0x38B10B: ModuleBase::run_trampoline(int, char**) (platforms/common/include/px4_platform_common/module.h:180) --- src/modules/commander/failure_detector/FailureDetector.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/commander/failure_detector/FailureDetector.hpp b/src/modules/commander/failure_detector/FailureDetector.hpp index 812ed726e2..bf9d164d30 100644 --- a/src/modules/commander/failure_detector/FailureDetector.hpp +++ b/src/modules/commander/failure_detector/FailureDetector.hpp @@ -71,7 +71,7 @@ union failure_detector_status_u { uint16_t battery : 1; uint16_t imbalanced_prop : 1; } flags; - uint16_t value; + uint16_t value {0}; }; using uORB::SubscriptionData;