From 2296c9acfae68d3665fdf77d5187fba4ef23b77f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beat=20K=C3=BCng?= Date: Wed, 16 Oct 2019 11:41:23 +0200 Subject: [PATCH] uavcan_virtual_can_driver: fix invalid use of px4_sem_getvalue sem_getvalue returns 0 on success, -1 on error, and never a value > 0. --- src/drivers/uavcan/uavcan_virtual_can_driver.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/uavcan/uavcan_virtual_can_driver.hpp b/src/drivers/uavcan/uavcan_virtual_can_driver.hpp index 566ecfc02d..171c164c1b 100644 --- a/src/drivers/uavcan/uavcan_virtual_can_driver.hpp +++ b/src/drivers/uavcan/uavcan_virtual_can_driver.hpp @@ -402,7 +402,7 @@ class VirtualCanDriver : public uavcan::ICanDriver, int count; int rv = px4_sem_getvalue(&sem, &count); - if (rv > 0 && count <= 0) { + if (rv == 0 && count <= 0) { px4_sem_post(&sem); } }