CI: enable clang-tidy cppcoreguidelines-virtual-class-destructor (#26559)

* CI: enable clang-tidy cppcoreguidelines-virtual-class-destructor

Signed-off-by: kuralme <kuralme@protonmail.com>

* format fix

Signed-off-by: kuralme <kuralme@protonmail.com>

---------

Signed-off-by: kuralme <kuralme@protonmail.com>

platforms/common/include/px4_platform_common/px4_work_queue/ScheduledWorkItem.hpp

@@ -46,6 +46,8 @@ public:
 
 	bool Scheduled() { return !hrt_called(&_call); }
 
+	virtual ~ScheduledWorkItem();
+
 	/**
 	 * Schedule next run with a delay in microseconds.
 	 *
@@ -76,7 +78,6 @@ public:
 protected:
 
 	ScheduledWorkItem(const char *name, const wq_config_t &config) : WorkItem(name, config) {}
-	virtual ~ScheduledWorkItem() override;
 
 	virtual void print_run_status() override;
 

platforms/common/include/px4_platform_common/px4_work_queue/WorkItem.hpp

@@ -83,13 +83,14 @@ public:
 
 	const char *ItemName() const { return _item_name; }
 
+	virtual ~WorkItem();
+
 protected:
 
 	explicit WorkItem(const char *name, const wq_config_t &config);
 
 	explicit WorkItem(const char *name, const WorkItem &work_item);
 
-	virtual ~WorkItem();
 
 	/**
 	 * Remove work item from the runnable queue, if it's there

platforms/common/uORB/uORBManager.hpp

@@ -448,6 +448,8 @@ public:
 
 	static uint8_t orb_get_instance(const void *node_handle);
 
+	virtual ~Manager();
+
 #if defined(CONFIG_BUILD_FLAT)
 	/* These are optimized by inlining in NuttX Flat build */
 	static unsigned updates_available(const void *node_handle, unsigned last_generation) { return is_advertised(node_handle) ? static_cast<const DeviceNode *>(node_handle)->updates_available(last_generation) : 0; }
@@ -504,7 +506,6 @@ private: // data members
 
 private: //class methods
 	Manager();
-	virtual ~Manager();
 
 #ifdef CONFIG_ORB_COMMUNICATOR
 	/**