fly316/PX4-Autopilot
7
0
Fork 0
mirror of https://gitee.com/mirrors_PX4/PX4-Autopilot.git synced 2026-11-05 02:01:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Array overrun fix in ScalarCodec, thanks Coverity

Browse Source
This commit is contained in:
Pavel Kirienko
2014-03-22 10:14:31 +04:00
parent fe57f3f5c5
commit 166ded6ba5
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libuavcan/include/uavcan/marshal/scalar_codec.hpp
+4 -2
View File
@@ -116,7 +116,8 @@ public:
convertByteOrder<BitLen>(byte_union.bytes); convertByteOrder<BitLen>(byte_union.bytes);
// Underlying stream class assumes that more significant bits have lower index, so we need to shift some. // Underlying stream class assumes that more significant bits have lower index, so we need to shift some.
byte_union.bytes[BitLen / 8] <<= (8 - (BitLen % 8)) & 7; if (BitLen % 8)
byte_union.bytes[BitLen / 8] <<= (8 - (BitLen % 8)) & 7;
return stream_.write(byte_union.bytes, BitLen); return stream_.write(byte_union.bytes, BitLen);
} }
@@ -136,7 +137,8 @@ public:
if (read_res <= 0) if (read_res <= 0)
return read_res; return read_res;
byte_union.bytes[BitLen / 8] >>= (8 - (BitLen % 8)) & 7; // As in encode(), vice versa if (BitLen % 8)
byte_union.bytes[BitLen / 8] >>= (8 - (BitLen % 8)) & 7; // As in encode(), vice versa
convertByteOrder<BitLen>(byte_union.bytes); convertByteOrder<BitLen>(byte_union.bytes);
fixTwosComplement<BitLen>(byte_union.value); fixTwosComplement<BitLen>(byte_union.value);