From 0ec3f0d2cb1623da1b3872bd6cb181e55b9f2409 Mon Sep 17 00:00:00 2001 From: Daniel Agar Date: Tue, 9 Nov 2021 12:23:45 -0500 Subject: [PATCH] mathlib: LowPassFilter2p update cutoff freq min to match NotchFilter - numerically the cutoff frequency not being smaller than 1% of the sample frequency is probably a better choice, but we're mostly filtering 16 bit data now stored in 32 bit float --- src/lib/mathlib/math/filter/LowPassFilter2p.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/mathlib/math/filter/LowPassFilter2p.hpp b/src/lib/mathlib/math/filter/LowPassFilter2p.hpp index 88b00b7ee8..159d2bcbfb 100644 --- a/src/lib/mathlib/math/filter/LowPassFilter2p.hpp +++ b/src/lib/mathlib/math/filter/LowPassFilter2p.hpp @@ -71,7 +71,7 @@ public: _delay_element_1 = {}; _delay_element_2 = {}; - _cutoff_freq = math::constrain(cutoff_freq, 5.f, sample_freq / 2); // TODO: min based on actual numerical limit + _cutoff_freq = math::max(cutoff_freq, sample_freq * 0.001f); _sample_freq = sample_freq; const float fr = _sample_freq / _cutoff_freq;